Re: [libvirt] [PATCH 2/3] util: Clear unused part of the map in virBitmapShrink

2018-02-02 Thread Martin Kletzander
On Fri, Feb 02, 2018 at 12:43:32PM +0100, Peter Krempa wrote: On Fri, Feb 02, 2018 at 12:30:10 +0100, Martin Kletzander wrote: On Fri, Feb 02, 2018 at 10:37:33AM +0100, Peter Krempa wrote: > On Fri, Feb 02, 2018 at 08:23:33 +0100, Martin Kletzander wrote: > > Some of the other functions depend o

Re: [libvirt] [PATCH 2/3] util: Clear unused part of the map in virBitmapShrink

2018-02-02 Thread Peter Krempa
On Fri, Feb 02, 2018 at 12:30:10 +0100, Martin Kletzander wrote: > On Fri, Feb 02, 2018 at 10:37:33AM +0100, Peter Krempa wrote: > > On Fri, Feb 02, 2018 at 08:23:33 +0100, Martin Kletzander wrote: > > > Some of the other functions depend on the fact that unused bits and longs > > > are > > > alwa

Re: [libvirt] [PATCH 2/3] util: Clear unused part of the map in virBitmapShrink

2018-02-02 Thread Martin Kletzander
On Fri, Feb 02, 2018 at 10:37:33AM +0100, Peter Krempa wrote: On Fri, Feb 02, 2018 at 08:23:33 +0100, Martin Kletzander wrote: Some of the other functions depend on the fact that unused bits and longs are always zero and it's less error-prone to clear it than fix the other functions. Clearing

Re: [libvirt] [PATCH 2/3] util: Clear unused part of the map in virBitmapShrink

2018-02-02 Thread Peter Krempa
On Fri, Feb 02, 2018 at 08:23:33 +0100, Martin Kletzander wrote: > Some of the other functions depend on the fact that unused bits and longs are > always zero and it's less error-prone to clear it than fix the other > functions. Clearing the bitmap is okay with me, since if you grow it again it s