Re: [libvirt] [PATCH 2/9] util: Make structs follow our naming convention

[Michal Privoznik]

On 04/16/2018 09:55 AM, Erik Skultety wrote:
> On Fri, Apr 13, 2018 at 04:47:09PM +0200, Michal Privoznik wrote:
>> There are two structs virMacMap and virFDStreamData that don't
>> have the underscore prefix. Put it there so that they follow the
>> rest of the code.
>>
>> Signed-off-by: Michal Privoznik 
>> ---
>>  src/util/virfdstream.c | 4 ++--
>>  src/util/virmacmap.c   | 2 +-
>>  src/util/virmacmap.h   | 2 +-
>>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> these suffer from the same problem:
> daemonAdmClientPrivate
> virDomainQemuMonitorEventData
> xentoollog_logger_libvirt (no convention here at all, so I'd skip this one)
> virLXCMeminfo
> qemuBlockNodeNameBackingChainData
> daemonClientStream
> virNetMessageHeader
> virNetMessageError
> virCgroup
> virNetlinkCallbackData
> virPerf
> virPerfEvent
> virPerfEventAttr
> virRotatingFileWriterEntry
> virRotatingFileReaderEntry
> virRotatingFileWriter
> virRotatingFileReader
> virMutex
> virRWLock
> virCond
> virThreadLocal
> virThread
> virTypedParameterRemoteValue (the second typedef is completely wrong):
> typedef struct _virTypedParameterRemoteValue virTypedParameterRemoteValue;
> typedef struct virTypedParameterRemoteValue 
> *virTypedParameterRemoteValuePtr;
> virOnceControl
> vbox - basically all of the structs :P
> vzDomObj
> 
> Honestly, given the number of places where this should be fixed, I'm not sure
> whether we should really go with the patch, but at the same time, I can 
> imagine
> us having this unified once and for all.

Actually, I don't need this patch. So I'm dropping it.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/9] util: Make structs follow our naming convention

[Erik Skultety]

On Fri, Apr 13, 2018 at 04:47:09PM +0200, Michal Privoznik wrote:
> There are two structs virMacMap and virFDStreamData that don't
> have the underscore prefix. Put it there so that they follow the
> rest of the code.
>
> Signed-off-by: Michal Privoznik 
> ---
>  src/util/virfdstream.c | 4 ++--
>  src/util/virmacmap.c   | 2 +-
>  src/util/virmacmap.h   | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)

these suffer from the same problem:
daemonAdmClientPrivate
virDomainQemuMonitorEventData
xentoollog_logger_libvirt (no convention here at all, so I'd skip this one)
virLXCMeminfo
qemuBlockNodeNameBackingChainData
daemonClientStream
virNetMessageHeader
virNetMessageError
virCgroup
virNetlinkCallbackData
virPerf
virPerfEvent
virPerfEventAttr
virRotatingFileWriterEntry
virRotatingFileReaderEntry
virRotatingFileWriter
virRotatingFileReader
virMutex
virRWLock
virCond
virThreadLocal
virThread
virTypedParameterRemoteValue (the second typedef is completely wrong):
typedef struct _virTypedParameterRemoteValue virTypedParameterRemoteValue;
typedef struct virTypedParameterRemoteValue 
*virTypedParameterRemoteValuePtr;
virOnceControl
vbox - basically all of the structs :P
vzDomObj

Honestly, given the number of places where this should be fixed, I'm not sure
whether we should really go with the patch, but at the same time, I can imagine
us having this unified once and for all.

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list