Re: [libvirt] [PATCH 4/5] Add virObjectEventStateRegisterID to symsfile

2016-10-12 Thread Martin Kletzander

On Wed, Oct 12, 2016 at 05:09:44PM +0800, Michal Privoznik wrote:

On 11.10.2016 20:53, Martin Kletzander wrote:

To go with the Deregister version as well.

Signed-off-by: Martin Kletzander 
---
 src/libvirt_private.syms | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index d92d3d865307..fd63f99b568c 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -820,6 +820,7 @@ virObjectEventStateDeregisterID;
 virObjectEventStateEventID;
 virObjectEventStateNew;
 virObjectEventStateQueue;
+virObjectEventStateRegisterID;


Okay, this is interesting. I've found out that this function is declared
in object_event_private.h while virObjectEventStateDeregisterID is in
object_event.h. Any idea why is that so?


That's probably because it should not be used outside src/conf/ without
wrappers, so this should be dropped actually.  Thanks for finding out
the object_event_private.h and making me think about it.

Martin


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 4/5] Add virObjectEventStateRegisterID to symsfile

2016-10-12 Thread Michal Privoznik
On 11.10.2016 20:53, Martin Kletzander wrote:
> To go with the Deregister version as well.
> 
> Signed-off-by: Martin Kletzander 
> ---
>  src/libvirt_private.syms | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index d92d3d865307..fd63f99b568c 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -820,6 +820,7 @@ virObjectEventStateDeregisterID;
>  virObjectEventStateEventID;
>  virObjectEventStateNew;
>  virObjectEventStateQueue;
> +virObjectEventStateRegisterID;

Okay, this is interesting. I've found out that this function is declared
in object_event_private.h while virObjectEventStateDeregisterID is in
object_event.h. Any idea why is that so?

ACK meanwhile.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list