Re: [libvirt] [PATCH 6/9] Introduce virNetSASLContextDispose
On Fri, Apr 13, 2018 at 04:47:13PM +0200, Michal Privoznik wrote:
> Strictly speaking this is not needed right now. However, next
> commits will require dispose function to exist.
>
> Signed-off-by: Michal Privoznik
> ---
...
> src/rpc/virnetsaslcontext.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
> +void virNetSASLContextDispose(void *obj ATTRIBUTE_UNUSED)
> +{
> +/* nada */
One more thing, either leave the body empty, or replace the commentary with a
plain "return" call.
Erik
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 6/9] Introduce virNetSASLContextDispose
On Fri, Apr 13, 2018 at 04:47:13PM +0200, Michal Privoznik wrote: > Strictly speaking this is not needed right now. However, next The first sentence only makes sense in the context of the patch series review, that will not be the case for someone looking at it in the future - plain "Future commits rely on the presence of this callback" should suffice. Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
