Re: [libvirt] [PATCH for 5.7.0 0/2] virsh: Rename --precopy-bandwidth migration option
On 9/2/19 9:08 AM, Jiri Denemark wrote: > The (pre-copy) bandwidth was historically the only bandwidth we > supported and thus it is called just "bandwidth" in all other places. > E.g., virsh migrate-setspeed or in the migration typed parameter name. > Let's make the new option for virsh migrate consistent. > > Jiri Denemark (2): >virsh: Rename --precopy-bandwidth migration option >news: Rename --precopy-bandwidth migration option > > docs/news.xml| 4 ++-- > tools/virsh-domain.c | 6 +++--- > tools/virsh.pod | 4 ++-- > 3 files changed, 7 insertions(+), 7 deletions(-) > I was a little uncertain about the name and mentioned that when submitting the patch. Agreed that "bandwidth" is more consistent and a better choice. Reviewed-by: Jim Fehlig Regards, Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH for 5.7.0 0/2] virsh: Rename --precopy-bandwidth migration option
On Mon, Sep 02, 2019 at 05:08:12PM +0200, Jiri Denemark wrote: > The (pre-copy) bandwidth was historically the only bandwidth we > supported and thus it is called just "bandwidth" in all other places. > E.g., virsh migrate-setspeed or in the migration typed parameter name. > Let's make the new option for virsh migrate consistent. > > Jiri Denemark (2): > virsh: Rename --precopy-bandwidth migration option > news: Rename --precopy-bandwidth migration option > > docs/news.xml| 4 ++-- > tools/virsh-domain.c | 6 +++--- > tools/virsh.pod | 4 ++-- > 3 files changed, 7 insertions(+), 7 deletions(-) I'm fine with this going in for 5.7.0 Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
