Re: [libvirt] [PATCH v2] util, qemu: Fix virDoes*Exist usage

2018-11-19 Thread Martin Kletzander
On Mon, Nov 19, 2018 at 05:27:01PM +0100, Andrea Bolognani wrote: On Mon, 2018-11-19 at 15:10 +0100, Martin Kletzander wrote: Since the functions only return 0 or 1, they should return bool (missed the change in the first commit). That way it's clearer that the check for non-existing group

Re: [libvirt] [PATCH v2] util, qemu: Fix virDoes*Exist usage

2018-11-19 Thread Andrea Bolognani
On Mon, 2018-11-19 at 15:10 +0100, Martin Kletzander wrote: > Since the functions only return 0 or 1, they should return bool (missed the > change in the first commit). That way it's clearer that the check for > non-existing group should be either "== 0" instead. I don't get this part of the

Re: [libvirt] [PATCH v2] util, qemu: Fix virDoes*Exist usage

2018-11-19 Thread Martin Kletzander
On Mon, Nov 19, 2018 at 03:10:16PM +0100, Martin Kletzander wrote: Since the functions only return 0 or 1, they should return bool (missed the change in the first commit). That way it's clearer that the check for non-existing group should be either "== 0" instead. Fix this by using proper