Re: [libvirt] [PATCH v2] util: netdevbridge: fall back to ioctl from sysfs

2018-11-25 Thread Christian Ehrhardt
On Sun, Nov 25, 2018 at 10:01 PM Laine Stump wrote: > On 11/23/18 1:42 AM, Christian Ehrhardt wrote: > > > > On Tue, Nov 20, 2018 at 1:26 PM Daniel P. Berrangé > wrote: > >> On Tue, Nov 20, 2018 at 01:25:46PM +0100, Christian Ehrhardt wrote: >> > There are certain cases e.g. containers where

Re: [libvirt] [PATCH v2] util: netdevbridge: fall back to ioctl from sysfs

2018-11-25 Thread Laine Stump
On 11/23/18 1:42 AM, Christian Ehrhardt wrote: > > > On Tue, Nov 20, 2018 at 1:26 PM Daniel P. Berrangé > mailto:berra...@redhat.com>> wrote: > > On Tue, Nov 20, 2018 at 01:25:46PM +0100, Christian Ehrhardt wrote: > > There are certain cases e.g. containers where the sysfs path might >

Re: [libvirt] [PATCH v2] util: netdevbridge: fall back to ioctl from sysfs

2018-11-22 Thread Christian Ehrhardt
On Tue, Nov 20, 2018 at 1:26 PM Daniel P. Berrangé wrote: > On Tue, Nov 20, 2018 at 01:25:46PM +0100, Christian Ehrhardt wrote: > > There are certain cases e.g. containers where the sysfs path might > > exists, but might fail. Unfortunately the exact restrictions are only > > known to libvirt

Re: [libvirt] [PATCH v2] util: netdevbridge: fall back to ioctl from sysfs

2018-11-20 Thread Daniel P . Berrangé
On Tue, Nov 20, 2018 at 01:25:46PM +0100, Christian Ehrhardt wrote: > There are certain cases e.g. containers where the sysfs path might > exists, but might fail. Unfortunately the exact restrictions are only > known to libvirt when trying to write to it so we need to try it. > > But in case it