Re: [libvirt] [PATCH v2 03/12] qemu: Introduce pr-manager-helper capability

[John Ferlan]

On 03/06/2018 12:31 PM, Michal Privoznik wrote:
> On 03/02/2018 02:58 AM, John Ferlan wrote:
>>
>>
>> On 02/21/2018 01:11 PM, Michal Privoznik wrote:
>>> The capability tracks if qemu has pr-manager-helper object. At
>>> this time don't actually detect if qemu has the capability. Not
>>> just yet. Only after the code is written the feature will be
>>> enabled.
>>>
>>> Signed-off-by: Michal Privoznik 
>>> ---
>>>  src/qemu/qemu_capabilities.c | 1 +
>>>  src/qemu/qemu_capabilities.h | 1 +
>>>  2 files changed, 2 insertions(+)
>>>
>>
>> Very strange to not see the replies or xml files adjusted here.
>>
>> And why is patch 12 not merged in here?  Like it was in v1 where you got
>> an ACK from Peter?
> 
> Because Peter also said that the patches should be ordered in such way
> that after each patch nothing is broken. So I had two options:
> 
> a) rewrite all the patches from scratch, or
> b) separate the capability detection into its own patch so effectively
> there is no way to use the feature until the very last patch and thus
> there's nothing to break. This was used fairly often historically when
> we were introducing new features in multiple patches.
> 

Fair enough.  I assume that if we had 2.12 capabilities, the flag would
show up in one of the xml replies file...  I understand the point, just
strange to see it split. I'm fine with the split though.

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 03/12] qemu: Introduce pr-manager-helper capability

[Michal Privoznik]

On 03/02/2018 02:58 AM, John Ferlan wrote:
> 
> 
> On 02/21/2018 01:11 PM, Michal Privoznik wrote:
>> The capability tracks if qemu has pr-manager-helper object. At
>> this time don't actually detect if qemu has the capability. Not
>> just yet. Only after the code is written the feature will be
>> enabled.
>>
>> Signed-off-by: Michal Privoznik 
>> ---
>>  src/qemu/qemu_capabilities.c | 1 +
>>  src/qemu/qemu_capabilities.h | 1 +
>>  2 files changed, 2 insertions(+)
>>
> 
> Very strange to not see the replies or xml files adjusted here.
> 
> And why is patch 12 not merged in here?  Like it was in v1 where you got
> an ACK from Peter?

Because Peter also said that the patches should be ordered in such way
that after each patch nothing is broken. So I had two options:

a) rewrite all the patches from scratch, or
b) separate the capability detection into its own patch so effectively
there is no way to use the feature until the very last patch and thus
there's nothing to break. This was used fairly often historically when
we were introducing new features in multiple patches.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 03/12] qemu: Introduce pr-manager-helper capability

[John Ferlan]

On 02/21/2018 01:11 PM, Michal Privoznik wrote:
> The capability tracks if qemu has pr-manager-helper object. At
> this time don't actually detect if qemu has the capability. Not
> just yet. Only after the code is written the feature will be
> enabled.
> 
> Signed-off-by: Michal Privoznik 
> ---
>  src/qemu/qemu_capabilities.c | 1 +
>  src/qemu/qemu_capabilities.h | 1 +
>  2 files changed, 2 insertions(+)
> 

Very strange to not see the replies or xml files adjusted here.

And why is patch 12 not merged in here?  Like it was in v1 where you got
an ACK from Peter?

John


> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index b5eb8cf46..d0005c71d 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -459,6 +459,7 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST,
>"pl011",
>"machine.pseries.max-cpu-compat",
>"dump-completed",
> +  "pr-manager-helper",
>  );
>  
>  
> diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
> index c2ec2be19..8d315665a 100644
> --- a/src/qemu/qemu_capabilities.h
> +++ b/src/qemu/qemu_capabilities.h
> @@ -444,6 +444,7 @@ typedef enum {
>  QEMU_CAPS_DEVICE_PL011, /* -device pl011 (not user-instantiable) */
>  QEMU_CAPS_MACHINE_PSERIES_MAX_CPU_COMPAT, /* -machine 
> pseries,max-cpu-compat= */
>  QEMU_CAPS_DUMP_COMPLETED, /* DUMP_COMPLETED event */
> +QEMU_CAPS_PR_MANAGER_HELPER, /* -object pr-manager-helper */
>  
>  QEMU_CAPS_LAST /* this must always be the last item */
>  } virQEMUCapsFlags;
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list