Re: [libvirt] [PATCH v2 04/20] virlog: Introduce virLogFindOutput

2016-09-21 Thread John Ferlan
[...] doh! Like a good fluorescent lightbulb - it just dawned on me... > + > +for (i = 0; i < noutputs; i++) { > +if (dest == outputs[i]->dest && > +(dest != VIR_LOG_TO_FILE || STREQ(outputs[i]->name, name))) STREQ_NULLABLE would I believe remove the need for the VIR_

Re: [libvirt] [PATCH v2 04/20] virlog: Introduce virLogFindOutput

2016-09-21 Thread John Ferlan
On 08/18/2016 07:47 AM, Erik Skultety wrote: > Outputs are a bit trickier than filters, because if the user(config)-specified > set of outputs does contain duplicates. So, not only we would log twice, but "because the user(config) specified set of outputs can contain duplicates." > we would als