Re: [libvirt] [PATCH v2 07/15] qemu: Clear out qemuDomainDeviceDefValidateControllerPCI()

2018-02-19 Thread Andrea Bolognani
On Mon, 2018-02-19 at 10:40 +0100, Peter Krempa wrote: > > Renaming the function won't work because then the compiler will > > complain about it being unused. Unless you meant something like > > > > /* Delete once done */ > > ValidateControllerPCIOld() { > > /* Existing checks here */ > >

Re: [libvirt] [PATCH v2 07/15] qemu: Clear out qemuDomainDeviceDefValidateControllerPCI()

2018-02-19 Thread Peter Krempa
On Mon, Feb 19, 2018 at 10:22:29 +0100, Andrea Bolognani wrote: > On Mon, 2018-02-19 at 07:28 +0100, Peter Krempa wrote: > > On Fri, Feb 16, 2018 at 17:28:04 +0100, Andrea Bolognani wrote: > > > We will rewrite pretty much every single line of this function > > > over the course of the next several

Re: [libvirt] [PATCH v2 07/15] qemu: Clear out qemuDomainDeviceDefValidateControllerPCI()

2018-02-19 Thread Andrea Bolognani
On Mon, 2018-02-19 at 07:28 +0100, Peter Krempa wrote: > On Fri, Feb 16, 2018 at 17:28:04 +0100, Andrea Bolognani wrote: > > We will rewrite pretty much every single line of this function > > over the course of the next several commits, and starting from > > a clean slate rather than replacing it b

Re: [libvirt] [PATCH v2 07/15] qemu: Clear out qemuDomainDeviceDefValidateControllerPCI()

2018-02-18 Thread Peter Krempa
On Fri, Feb 16, 2018 at 17:28:04 +0100, Andrea Bolognani wrote: > We will rewrite pretty much every single line of this function > over the course of the next several commits, and starting from > a clean slate rather than replacing it bit by bit makes the > resulting diffs unmeasurably easier to re