Re: [libvirt] [PATCH v3 14/20] conf: introduce a virNWFilterBindingObjPtr struct
On Mon, Jun 18, 2018 at 10:08:00AM -0400, John Ferlan wrote:
>
>
> On 06/14/2018 08:33 AM, Daniel P. Berrangé wrote:
> > Introduce a new struct to act as the stateful owner of the
> > virNWFilterBindingDefPtr objects.
> >
> > Signed-off-by: Daniel P. Berrangé
> > ---
> > src/conf/Makefile.inc.am | 2 +
> > src/conf/virnwfilterbindingobj.c | 299 +++
> > src/conf/virnwfilterbindingobj.h | 69 +++
> > src/libvirt_private.syms | 14 ++
> > 4 files changed, 384 insertions(+)
> > create mode 100644 src/conf/virnwfilterbindingobj.c
> > create mode 100644 src/conf/virnwfilterbindingobj.h
> >
>
> While continuing, I tripped across this:
>
> > +
> > +static virNWFilterBindingObjPtr
> > +virNWFilterBindingObjParseNode(xmlDocPtr doc,
> > + xmlNodePtr root)
> > +{
> > +xmlXPathContextPtr ctxt = NULL;
> > +virNWFilterBindingObjPtr obj = NULL;
> > +
> > +if (STRNEQ((const char *)root->name, "filterbinding")) {
>
> "filterbindingstatus"
Oh fun, will fix that.
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 14/20] conf: introduce a virNWFilterBindingObjPtr struct
On 06/14/2018 08:33 AM, Daniel P. Berrangé wrote:
> Introduce a new struct to act as the stateful owner of the
> virNWFilterBindingDefPtr objects.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> src/conf/Makefile.inc.am | 2 +
> src/conf/virnwfilterbindingobj.c | 299 +++
> src/conf/virnwfilterbindingobj.h | 69 +++
> src/libvirt_private.syms | 14 ++
> 4 files changed, 384 insertions(+)
> create mode 100644 src/conf/virnwfilterbindingobj.c
> create mode 100644 src/conf/virnwfilterbindingobj.h
>
While continuing, I tripped across this:
> +
> +static virNWFilterBindingObjPtr
> +virNWFilterBindingObjParseNode(xmlDocPtr doc,
> + xmlNodePtr root)
> +{
> +xmlXPathContextPtr ctxt = NULL;
> +virNWFilterBindingObjPtr obj = NULL;
> +
> +if (STRNEQ((const char *)root->name, "filterbinding")) {
"filterbindingstatus"
> +virReportError(VIR_ERR_XML_ERROR, "%s",
> + _("unknown root element for filter binding"));
Found by adding the '%s' here to print the root->name...
> +goto cleanup;
> +}
> +
> +ctxt = xmlXPathNewContext(doc);
> +if (ctxt == NULL) {
> +virReportOOMError();
> +goto cleanup;
> +}
> +
> +ctxt->node = root;
> +obj = virNWFilterBindingObjParseXML(doc, ctxt);
> +
> + cleanup:
> +xmlXPathFreeContext(ctxt);
> +return obj;
> +}
> +
> +
John
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 14/20] conf: introduce a virNWFilterBindingObjPtr struct
On 06/14/2018 08:33 AM, Daniel P. Berrangé wrote: > Introduce a new struct to act as the stateful owner of the > virNWFilterBindingDefPtr objects. > > Signed-off-by: Daniel P. Berrangé > --- > src/conf/Makefile.inc.am | 2 + > src/conf/virnwfilterbindingobj.c | 299 +++ > src/conf/virnwfilterbindingobj.h | 69 +++ > src/libvirt_private.syms | 14 ++ > 4 files changed, 384 insertions(+) > create mode 100644 src/conf/virnwfilterbindingobj.c > create mode 100644 src/conf/virnwfilterbindingobj.h > Reviewed-by: John Ferlan John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
