Re: [libvirt] [PATCH v3 15/18] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-10-14 Thread Laine Stump
On 10/14/2016 01:20 PM, Andrea Bolognani wrote: On Thu, 2016-10-13 at 13:43 -0400, Laine Stump wrote: +if (nbuses > 0 && !addrs->buses[0].model) { +if (virDomainPCIAddressBusSetModel(>buses[0], + VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT) < 0) +

Re: [libvirt] [PATCH v3 15/18] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-10-14 Thread Andrea Bolognani
On Thu, 2016-10-13 at 13:43 -0400, Laine Stump wrote: > > > > > +if (nbuses > 0 && !addrs->buses[0].model) { > > > > > +if (virDomainPCIAddressBusSetModel(>buses[0], > > > > > +    > > > > > VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT) < 0) > > > > > +  

Re: [libvirt] [PATCH v3 15/18] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-10-13 Thread Laine Stump
On 10/13/2016 01:43 PM, Laine Stump wrote: On 10/11/2016 05:34 AM, Andrea Bolognani wrote: On Mon, 2016-10-10 at 15:43 -0400, Laine Stump wrote: 3) Although it is strongly discouraged, it is legal for a pci-bridge to be directly plugged into pcie-root, and we don't want to

Re: [libvirt] [PATCH v3 15/18] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-10-13 Thread Laine Stump
On 10/10/2016 02:14 PM, Andrea Bolognani wrote: +} else if (flags & VIR_PCI_CONNECT_TYPE_PCI_BRIDGE) { >+model = VIR_DOMAIN_CONTROLLER_MODEL_DMI_TO_PCI_BRIDGE; I'm not so clear on this bit: if we're growing the address set to plug in a pci-bridge, can we just go ahead and assume a

Re: [libvirt] [PATCH v3 15/18] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-10-13 Thread Laine Stump
On 10/11/2016 05:34 AM, Andrea Bolognani wrote: On Mon, 2016-10-10 at 15:43 -0400, Laine Stump wrote: 3) Although it is strongly discouraged, it is legal for a pci-bridge to be directly plugged into pcie-root, and we don't want to auto-add a dmi-to-pci-bridge if there is already a

Re: [libvirt] [PATCH v3 15/18] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-10-11 Thread Andrea Bolognani
On Mon, 2016-10-10 at 15:43 -0400, Laine Stump wrote: > > > 3) Although it is strongly discouraged, it is legal for a pci-bridge > > >  to be directly plugged into pcie-root, and we don't want to > > >  auto-add a dmi-to-pci-bridge if there is already a pci-bridge > > >  that's been

Re: [libvirt] [PATCH v3 15/18] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-10-10 Thread Laine Stump
On 10/10/2016 02:14 PM, Andrea Bolognani wrote: On Tue, 2016-09-20 at 15:14 -0400, Laine Stump wrote: Previously libvirt would only add pci-bridge devices automatically when an address was requested for a device that required a legacy PCI slot and none was available. This patch expands that

Re: [libvirt] [PATCH v3 15/18] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-10-10 Thread Andrea Bolognani
On Tue, 2016-09-20 at 15:14 -0400, Laine Stump wrote: > Previously libvirt would only add pci-bridge devices automatically > when an address was requested for a device that required a legacy PCI > slot and none was available. This patch expands that support to > dmi-to-pci-bridge (which is needed