Re: [libvirt] [libvirt PATCH v2 03/44] Force QMP capability probing

2018-04-10 Thread Andrea Bolognani
On Mon, 2018-04-09 at 16:42 +0100, Daniel P. Berrangé wrote: > > @@ -5114,7 +4261,7 @@ virQEMUCapsNewForBinaryInternal(virArch hostArch, > > goto error; > > } > > > > -if (qmpOnly && !qemuCaps->usedQMP) { > > +if (!qemuCaps->usedQMP) { > >

Re: [libvirt] [libvirt PATCH v2 03/44] Force QMP capability probing

2018-04-09 Thread Daniel P . Berrangé
On Thu, Apr 05, 2018 at 02:22:54PM +0200, Ján Tomko wrote: > Remove the qmpOnly attribute of virQEMUCapsNewForBinaryInternal > and instead always assume it's true. > > This effectively sets the minimum QEMU version to 1.2.0, > breaking support for QEMU in RHEL6. > > @@ -5077,8 +4225,7 @@

Re: [libvirt] [libvirt PATCH v2 03/44] Force QMP capability probing

2018-04-09 Thread Andrea Bolognani
On Thu, 2018-04-05 at 14:22 +0200, Ján Tomko wrote: > Remove the qmpOnly attribute of virQEMUCapsNewForBinaryInternal s/attribute/argument/ > and instead always assume it's true. > > This effectively sets the minimum QEMU version to 1.2.0, > breaking support for QEMU in RHEL6. I don't think we