Re: [libvirt] Emacs tip for easily adding Reviewed-by tags & friends

2018-03-20 Thread Bjoern Walk
Daniel P. Berrangé [2018-03-15, 11:36AM +]: > It is nice that git has the short-hand for adding Signed-off-by, but > adding other tags during reviews is kind of tedious and long winded. > eg "ACK" is much shorter than typing "Reviewed-by: ...blah blah blah.." > > Good

Re: [libvirt] Emacs tip for easily adding Reviewed-by tags & friends

2018-03-16 Thread Martin Kletzander
On Thu, Mar 15, 2018 at 11:36:28AM +, Daniel P. Berrangé wrote: It is nice that git has the short-hand for adding Signed-off-by, but adding other tags during reviews is kind of tedious and long winded. eg "ACK" is much shorter than typing "Reviewed-by: ...blah blah blah.." Good editors have

Re: [libvirt] Emacs tip for easily adding Reviewed-by tags & friends

2018-03-15 Thread Erik Skultety
On Thu, Mar 15, 2018 at 12:38:26PM +, Daniel P. Berrangé wrote: > On Thu, Mar 15, 2018 at 01:34:31PM +0100, Erik Skultety wrote: > > On Thu, Mar 15, 2018 at 11:36:28AM +, Daniel P. Berrangé wrote: > > > It is nice that git has the short-hand for adding Signed-off-by, but > > > adding other

Re: [libvirt] Emacs tip for easily adding Reviewed-by tags & friends

2018-03-15 Thread Cedric Bosdonnat
On Thu, 2018-03-15 at 12:38 +, Daniel P. Berrangé wrote: > On Thu, Mar 15, 2018 at 01:34:31PM +0100, Erik Skultety wrote: > > On Thu, Mar 15, 2018 at 11:36:28AM +, Daniel P. Berrangé wrote: > > > It is nice that git has the short-hand for adding Signed-off-by, but > > > adding other tags

Re: [libvirt] Emacs tip for easily adding Reviewed-by tags & friends

2018-03-15 Thread Daniel P . Berrangé
On Thu, Mar 15, 2018 at 01:34:31PM +0100, Erik Skultety wrote: > On Thu, Mar 15, 2018 at 11:36:28AM +, Daniel P. Berrangé wrote: > > It is nice that git has the short-hand for adding Signed-off-by, but > > adding other tags during reviews is kind of tedious and long winded. > > eg "ACK" is

Re: [libvirt] Emacs tip for easily adding Reviewed-by tags & friends

2018-03-15 Thread Erik Skultety
On Thu, Mar 15, 2018 at 11:36:28AM +, Daniel P. Berrangé wrote: > It is nice that git has the short-hand for adding Signed-off-by, but > adding other tags during reviews is kind of tedious and long winded. > eg "ACK" is much shorter than typing "Reviewed-by: ...blah blah blah.." > > Good