Re: [libvirt] libvirt-guest.sh bug fixes

2016-10-11 Thread Stefan Bader
On 10.10.2016 20:43, Eric Blake wrote: > On 10/10/2016 11:48 AM, Stefan Bader wrote: > >>> I did not hear about that before. But revisiting things again I think what >>> happened is that the Xen patch which I had done before (but at that time >>> forgot >>> to submit upstream) was adding quotes

Re: [libvirt] libvirt-guest.sh bug fixes

2016-10-10 Thread Eric Blake
On 10/10/2016 11:48 AM, Stefan Bader wrote: >> I did not hear about that before. But revisiting things again I think what >> happened is that the Xen patch which I had done before (but at that time >> forgot >> to submit upstream) was adding quotes there because without, the grep does >> not >>

Re: [libvirt] libvirt-guest.sh bug fixes

2016-10-10 Thread Cole Robinson
On 10/10/2016 12:32 PM, Stefan Bader wrote: > On 10.10.2016 17:06, Cole Robinson wrote: >> On 10/07/2016 03:56 AM, Stefan Bader wrote: >>> Two small changes, before I forget about submitting them... >>> >>> First one affects all environments the same. The list of UIDs which >>> is generated has

Re: [libvirt] libvirt-guest.sh bug fixes

2016-10-10 Thread Stefan Bader
On 10.10.2016 18:32, Stefan Bader wrote: > On 10.10.2016 17:06, Cole Robinson wrote: >> On 10/07/2016 03:56 AM, Stefan Bader wrote: >>> Two small changes, before I forget about submitting them... >>> >>> First one affects all environments the same. The list of UIDs which >>> is generated has each

Re: [libvirt] libvirt-guest.sh bug fixes

2016-10-10 Thread Stefan Bader
On 10.10.2016 17:06, Cole Robinson wrote: > On 10/07/2016 03:56 AM, Stefan Bader wrote: >> Two small changes, before I forget about submitting them... >> >> First one affects all environments the same. The list of UIDs which >> is generated has each element on a separate line. And using quotes >>

Re: [libvirt] libvirt-guest.sh bug fixes

2016-10-10 Thread Cole Robinson
On 10/07/2016 03:56 AM, Stefan Bader wrote: > Two small changes, before I forget about submitting them... > > First one affects all environments the same. The list of UIDs which > is generated has each element on a separate line. And using quotes > in the echo preserves those newlines. However

Re: [libvirt] libvirt-guest.sh bug fixes

2016-10-10 Thread Michal Privoznik
On 07.10.2016 15:56, Stefan Bader wrote: > Two small changes, before I forget about submitting them... > > First one affects all environments the same. The list of UIDs which > is generated has each element on a separate line. And using quotes > in the echo preserves those newlines. However the