Re: [Libwpd-devel] Doing away with WPXString

2010-11-01 Thread William Lachance
2010/11/1 William Lachance : > The problem is mainly that this change (along with const char change) > involve changes to all the various sub-projects, since I'm changing > the API/contract of libwpd. I don't really like leaving those in a > broken state. > > I'll try to get everything done (or at

Re: [Libwpd-devel] Doing away with WPXString

2010-11-01 Thread William Lachance
The problem is mainly that this change (along with const char change) involve changes to all the various sub-projects, since I'm changing the API/contract of libwpd. I don't really like leaving those in a broken state. I'll try to get everything done (or at least libwpg/libwpd/writerperfect) for t

Re: [Libwpd-devel] Doing away with WPXString

2010-11-01 Thread Fridrich Strba
I would prefer to have it pushed as it goes. I will be in Hamburg for a hack-weekend from this Friday and would like to finalize the LibreOffice plug-in. So, if it was possible to do the functionality first so that I can try to craft the plug-in and then try to beautify the stuff later :) I would n

Re: [Libwpd-devel] Doing away with WPXString

2010-10-31 Thread William Lachance
Just a quick update on this. I've begun work on it, about 1/3 through I'd say. I'm working on a branch which I will push when it's ready (hopefully next week). I realized that it's not a good idea to eliminate WPXString altogether as the functionality for explicitly inserting spaces is really usef

Re: [Libwpd-devel] Doing away with WPXString

2010-10-23 Thread Fridrich Strba
Will, On Sat, 2010-10-23 at 15:41 -0400, William Lachance wrote: > I imagine I could convert everything libwpd-related (libwpd, > writerperfect, bindings, libwpg, the abiword plugin) to this approach > (with the insertSpace function I mentioned above) in the space of an > afternoon next week. Ok,

Re: [Libwpd-devel] Doing away with WPXString

2010-10-23 Thread William Lachance
2010/10/23 Fridrich Strba : > Will, > > My first wild idea is that if you do it all properly, go for it. Like to > be sure that we don't require user to free anything she did not allocate > and that we don't return reference to a temporary from a function, try > it. const char * implies read-only,

Re: [Libwpd-devel] Doing away with WPXString

2010-10-23 Thread Fridrich Strba
Will, My first wild idea is that if you do it all properly, go for it. Like to be sure that we don't require user to free anything she did not allocate and that we don't return reference to a temporary from a function, try it. Now, concerning the binding, we don't have big issues with binding lib

Re: [Libwpd-devel] Doing away with WPXString

2010-10-23 Thread J.M. Maurer
On Sat, 2010-10-23 at 11:45 -0400, William Lachance wrote: > Hey, > > So after having come back to libwpd after a few years, I realized that > I made one mistake when designing the external API. > > For various reasons (OOo compatibility, language bindings) we don't > want to export STL structure