Re: [Lift] Issue 201 - checkbox not returning all checked

2009-11-22 Thread Ross Mellgren
Oh I didn't think of that one because the type of the argument is Seq[A] though I guess it's safe as long as possible is passed in as a List[A], since scala's match will automatically downcast during a match. -Ross On Nov 22, 2009, at 10:43 PM, David Pollak wrote: > > > On Sun, Nov 22, 2009

Re: [Lift] Issue 201 - checkbox not returning all checked

2009-11-22 Thread David Pollak
On Sun, Nov 22, 2009 at 11:03 AM, Ross Mellgren wrote: > Well, yes, in both senses of returning a ChoiceHolder containing more than > one and in the sense of calling the callback with all set ones. This was > (apparently) the intended behavior and was accidentally changed. > > We could make a new

Re: [Lift] Issue 201 - checkbox not returning all checked

2009-11-22 Thread Ross Mellgren
Well, yes, in both senses of returning a ChoiceHolder containing more than one and in the sense of calling the callback with all set ones. This was (apparently) the intended behavior and was accidentally changed. We could make a new one for a single checkbox, but then the question of what to do

Re: [Lift] Issue 201 - checkbox not returning all checked

2009-11-22 Thread Jim Barrows
On Sat, Nov 21, 2009 at 10:48 AM, Ross Mellgren wrote: > yejun on github opened up an issue: > > def checkbox[T](possible : Seq[T], actual : Seq[T], func : (Seq[T]) => Any, > attrs : (String, String)*) > > Checkbox is returning a list of checkboxes? Could we at least make checkbox return and eit

Re: [Lift] Issue 201 - checkbox not returning all checked

2009-11-21 Thread Ross Mellgren
On review board: http://reviewboard.liftweb.net/r/117/ I added a few doc comments to nearby stuff, let me know if there are inaccuracies or style changes that should be made. -Ross On Nov 21, 2009, at 9:37 PM, David Pollak wrote: > Looks like I was over-eager with the HPP stuff. > > Yeah, che

Re: [Lift] Issue 201 - checkbox not returning all checked

2009-11-21 Thread David Pollak
Looks like I was over-eager with the HPP stuff. Yeah, checkbox should return the entire list of things checked. On Sat, Nov 21, 2009 at 9:48 AM, Ross Mellgren wrote: > yejun on github opened up an issue: > > def checkbox[T](possible : Seq[T], actual : Seq[T], func : (Seq[T]) => Any, > attrs :

[Lift] Issue 201 - checkbox not returning all checked

2009-11-21 Thread Ross Mellgren
yejun on github opened up an issue: > def checkbox[T](possible : Seq[T], actual : Seq[T], func : (Seq[T]) > => Any, attrs : (String, String)*) > Func will only return first element in possible when it is checked > or List(). It is easily reproducible. Based on the type of func, I agree it lo