[Lift] Re: makeUtf8 and HttpServletRequest broken in new build???

2009-08-18 Thread Indrajit Raychaudhuri
+1 on some amount of nesting and reorganization. For example: docs, lift-archetype-basic, lift-facebook, lift-installer are all too different to be peers and probably can have different home (nested) based on 'traits' :) Cheers, Indrajit On Aug 18, 3:51 am, Timothy Perrett

[Lift] Re: makeUtf8 and HttpServletRequest broken in new build???

2009-08-18 Thread glenn
David, I just ran the basic from SNAPSHOTS and Boot.scala still has private def makeUtf8(req: HttpServletRequest) { req.setCharacterEncoding(UTF-8) } in Boot.scala. Glenn... On Aug 17, 10:10 am, David Pollak feeder.of.the.be...@gmail.com wrote: On Mon, Aug 17, 2009 at 9:42 AM, glenn

[Lift] Re: makeUtf8 and HttpServletRequest broken in new build???

2009-08-18 Thread David Pollak
On Tue, Aug 18, 2009 at 9:15 AM, glenn gl...@exmbly.com wrote: David, I just ran the basic from SNAPSHOTS and Boot.scala still has What did you type at the command line? private def makeUtf8(req: HttpServletRequest) { req.setCharacterEncoding(UTF-8) } in Boot.scala. Glenn...

[Lift] Re: makeUtf8 and HttpServletRequest broken in new build???

2009-08-18 Thread glenn
Actually, I used the Maven Eclipse plugin. File/New/Other/Maven/Maven Project. Click Next twice and select the Nexus Indexer Archetype catalog. Use lift to filter and select Group Id: repository.net.liftweb Artifact Id: lift.archetype.basic Version: 1.1-SNAPSHOT Glenn... On Aug 18, 10:32 am,

[Lift] Re: makeUtf8 and HttpServletRequest broken in new build???

2009-08-17 Thread glenn
Is anyone planning on fixing the archetype snapshots to add this change, and import provider._ in Boot.scala. Thanks in advance, Glenn... On Aug 10, 10:36 am, marius d. marius.dan...@gmail.com wrote: Your makeUTF8 should look like this:   private def makeUtf8(req: HTTPRequest): Unit =

[Lift] Re: makeUtf8 and HttpServletRequest broken in new build???

2009-08-17 Thread David Pollak
On Mon, Aug 17, 2009 at 9:42 AM, glenn gl...@exmbly.com wrote: Is anyone planning on fixing the archetype snapshots to add this change, and import provider._ in Boot.scala. I'm able to create a new Basic Lift app from archetypes... and it works just fine. Can you tell us what command you

[Lift] Re: makeUtf8 and HttpServletRequest broken in new build???

2009-08-17 Thread Timothy Perrett
I think his point is that he wants it added by default, rather than there is any problem. Personally, I don¹t see the point of adding it by default... But hey. On this note, I¹ve been thinking of perhaps having a re-shuffle in the code base to group the archetypes together in a module and add a

[Lift] Re: makeUtf8 and HttpServletRequest broken in new build???

2009-08-17 Thread Timothy Perrett
They would still output the same of course ­ I just see a need for a few more starting points and I don¹t want to clutter the main codebase so a little bit of housekeeping is in order :-) Cheers, Tim On 17/08/2009 23:43, David Pollak feeder.of.the.be...@gmail.com wrote: As long as you don't

[Lift] Re: makeUtf8 and HttpServletRequest broken in new build???

2009-08-10 Thread Tim Nelson
There were changes made to remove the requirement for lift to run in a servlet container. See: http://groups.google.com/group/liftweb/browse_thread/thread/a3486a7b9e9ffa40 On Mon, Aug 10, 2009 at 11:49 AM, glenn gl...@exmbly.com wrote: I just got a type mismatch found error in

[Lift] Re: makeUtf8 and HttpServletRequest broken in new build???

2009-08-10 Thread Jeppe Nejsum Madsen
glenn gl...@exmbly.com writes: I just got a type mismatch found error in LiftRules.early.append (makeUtf8) in Boot.scala. It's now looking for an net.liftweb.http.provider.HTTPRequest instead of a javax.servlet.http.HttpServletRequest. Is this a new change, and if so, where is the

[Lift] Re: makeUtf8 and HttpServletRequest broken in new build???

2009-08-10 Thread glenn
I realize the need to improve the code, but do you have to break existing in the process? That's bad form. Glenn... On Aug 10, 9:55 am, Tim Nelson tnell...@gmail.com wrote: There were changes made to remove the requirement for lift to run in a servlet container. See:

[Lift] Re: makeUtf8 and HttpServletRequest broken in new build???

2009-08-10 Thread Ross Mellgren
It was well warned about (many capital letters and asterisks) and you're clearly compiling against SNAPSHOTs. If you do not want new features, but guaranteed unchanging API, then you should probably use 1.1 milestones or 1.0 instead. -Ross On Aug 10, 2009, at 1:05 PM, glenn wrote: I

[Lift] Re: makeUtf8 and HttpServletRequest broken in new build???

2009-08-10 Thread David Pollak
On Mon, Aug 10, 2009 at 10:05 AM, glenn gl...@exmbly.com wrote: I realize the need to improve the code, but do you have to break existing in the process? That's bad form. The issue was discussed on list. The branch was available for inspection in the repository for 1 month. The warning

[Lift] Re: makeUtf8 and HttpServletRequest broken in new build???

2009-08-10 Thread marius d.
Your makeUTF8 should look like this: private def makeUtf8(req: HTTPRequest): Unit = {req.setCharacterEncoding(UTF-8)} just use HTTPRequest instead of HttpServletRequest. Br's, Marius On Aug 10, 7:49 pm, glenn gl...@exmbly.com wrote: I just got a type mismatch found error in