Re: [Lift] Re: SQL error

2010-03-04 Thread Jeppe Nejsum Madsen
On Thu, Mar 4, 2010 at 1:49 PM, Mads Hartmann mads...@gmail.com wrote: Ah! That fixed it, thanks a lot Jeppe ;) I'm not sure what to say in the ticket though, the column-name blob was a bad choise made by me. Yes, but lift tries to be clever and changes the column name if it matches a

Re: [Lift] Re: SQL error

2010-03-04 Thread Naftoli Gugenheim
Is blob a standard reserved word or only on MySQL? If the latter this is a potential breaking change. - Mads Hartmannmads...@gmail.com wrote: Ah! That fixed it, thanks a lot Jeppe ;) I'm not sure what to say in the ticket though, the column-name blob was a

Re: [Lift] Re: SQL error

2010-03-04 Thread Jim Barrows
On Thu, Mar 4, 2010 at 1:47 PM, Naftoli Gugenheim naftoli...@gmail.comwrote: Is blob a standard reserved word or only on MySQL? If the latter this is a potential breaking change. Blob is not apparently part of the ANSI standard reserved word for SQL. I would have sworn it was. However, it

Re: [Lift] Re: SQL error

2010-03-04 Thread Mads Hartmann Jensen
This has already been on reviewboard and comitted to master - should i send out a breaking change note? I'm not sure i get why this is a breaking change though? On 04/03/2010, at 22.07, Jim Barrows wrote: On Thu, Mar 4, 2010 at 1:47 PM, Naftoli Gugenheim naftoli...@gmail.com wrote: Is

Re: [Lift] Re: SQL error

2010-03-04 Thread Jim Barrows
On Thu, Mar 4, 2010 at 2:10 PM, Mads Hartmann Jensen mads...@gmail.comwrote: This has already been on reviewboard and comitted to master - should i send out a breaking change note? I'm not sure i get why this is a breaking change though? Not sure if it is. However it's certainly something

Re: [Lift] Re: SQL error

2010-03-04 Thread Ross Mellgren
It would be breaking only if somebody were using a database backend where it's NOT a keyword and also had a mapper field called blob, right? Seems pretty unlikely, but that's just my opinion. -Ross On Mar 4, 2010, at 4:13 PM, Jim Barrows wrote: On Thu, Mar 4, 2010 at 2:10 PM, Mads Hartmann

Re: [Lift] Re: SQL error

2010-03-04 Thread Mads Hartmann Jensen
Ah yeah I see, it would be looking for a column named blob_c then, right? So what do you say - I send out a **Potential breaking change** message that states that if 'blob' is not a keyword in your DB and you're currently using blob as a column name you should change it to blob_c? On

Re: [Lift] Re: SQL error

2010-03-04 Thread Ross Mellgren
Sounds proper to me. -Ross On Mar 4, 2010, at 4:22 PM, Mads Hartmann Jensen wrote: Ah yeah I see, it would be looking for a column named blob_c then, right? So what do you say - I send out a **Potential breaking change** message that states that if 'blob' is not a keyword in your DB and

Re: [Lift] Re: SQL error

2010-03-04 Thread David Pollak
On Thu, Mar 4, 2010 at 1:10 PM, Mads Hartmann Jensen mads...@gmail.comwrote: This has already been on reviewboard and comitted to master - should i send out a breaking change note? Yeah. Send out a breaking change note. The likelihood of breakage is low, but possible. I'm not sure i get

Re: [Lift] Re: SQL error

2010-03-04 Thread Mads Hartmann Jensen
Done :) On 04/03/2010, at 22.38, David Pollak wrote: On Thu, Mar 4, 2010 at 1:10 PM, Mads Hartmann Jensen mads...@gmail.com wrote: This has already been on reviewboard and comitted to master - should i send out a breaking change note? Yeah. Send out a breaking change note. The

Re: [Lift] Re: SQL error

2010-03-04 Thread Naftoli Gugenheim
If you didn't yet send it also to lift-announce. - Mads Hartmann Jensenmads...@gmail.com wrote: Ah yeah I see, it would be looking for a column named blob_c then, right? So what do you say - I send out a **Potential breaking change** message that states

Re: [Lift] Re: SQL error

2010-03-04 Thread Sean Ross
I know I'm new here but I'm curious as to why names conflicting with reserved words are changed rather than escaped ? JDBC drivers provide the escape syntax and a list of reserved words for the database through DatabaseMetaData. Regards, Sean. On 4 Mar 2010, at 12:54, Jeppe Nejsum Madsen