[Lift] Re: Changes to ajax handling?
Yeah that what happens when you're coding late in the night ... the null monster bites you. Marius On Jul 2, 7:47 pm, Kris Nuttycombe wrote: > Marius, that fix appears to work fine, thank you! > > Bloody nulls. :) > > Kris > > On Thu, Jul 2, 2009 at 7:17 AM, marius d. wrote: > > > Corrected and pushed. Please do an update and give it a try. > > > Br's, > > Marius > > > On Jul 2, 8:56 am, "marius d." wrote: > >> On Jul 2, 12:40 am, Kris Nuttycombe wrote: > > >> > To answer my own question, looking over the commit log 28595307 looks > >> > extremely suspicious. I can revert it locally but would prefer a > >> > mainline fix, and don't want to attempt it myself. Marius? > > >> > Kris > > >> > On Wed, Jul 1, 2009 at 3:33 PM, Kris > > >> > Nuttycombe wrote: > >> > > Hi, all, > > >> > > Have there been recent changes made to liftAjax.js? I am encountering > >> > > new errors from an ajaxSelect() today that were not present yesterday. > >> > > Firebug complains: > > >> > > Use of getBoxObjectFor() is deprecated. Try to use > >> > > element.getBoundingClientRect() if possible. > >> > > [Break on this error] undefined > >> > > liftAjax.js (line 111) > >> > > aboutToSend.responseType is null > >> > > lift_doAjaxCycle()()liftAjax.js (line 111) > >> > > lift_ajaxHandler()()liftAjax.js (line 21) > >> > > onchange(change )add_trig...Gyw%3D%3D (line 2) > >> > > [Break on this error] if (aboutToSend.responseType.toLowerCase() === > >> > > "json") > > >> That is my commt but right now I don,t see how it affects other > >> things ... But I,ll definitely look on it today. Note that there is no > >> intent for ajax behavior changes .. Just an augmentation ... > > >> > > Thanks, > > >> > > Kris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: Changes to ajax handling?
Marius, that fix appears to work fine, thank you! Bloody nulls. :) Kris On Thu, Jul 2, 2009 at 7:17 AM, marius d. wrote: > > Corrected and pushed. Please do an update and give it a try. > > Br's, > Marius > > On Jul 2, 8:56 am, "marius d." wrote: >> On Jul 2, 12:40 am, Kris Nuttycombe wrote: >> >> >> >> > To answer my own question, looking over the commit log 28595307 looks >> > extremely suspicious. I can revert it locally but would prefer a >> > mainline fix, and don't want to attempt it myself. Marius? >> >> > Kris >> >> > On Wed, Jul 1, 2009 at 3:33 PM, Kris >> >> > Nuttycombe wrote: >> > > Hi, all, >> >> > > Have there been recent changes made to liftAjax.js? I am encountering >> > > new errors from an ajaxSelect() today that were not present yesterday. >> > > Firebug complains: >> >> > > Use of getBoxObjectFor() is deprecated. Try to use >> > > element.getBoundingClientRect() if possible. >> > > [Break on this error] undefined >> > > liftAjax.js (line 111) >> > > aboutToSend.responseType is null >> > > lift_doAjaxCycle()()liftAjax.js (line 111) >> > > lift_ajaxHandler()()liftAjax.js (line 21) >> > > onchange(change )add_trig...Gyw%3D%3D (line 2) >> > > [Break on this error] if (aboutToSend.responseType.toLowerCase() === >> > > "json") >> >> That is my commt but right now I don,t see how it affects other >> things ... But I,ll definitely look on it today. Note that there is no >> intent for ajax behavior changes .. Just an augmentation ... >> >> > > Thanks, >> >> > > Kris > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: Changes to ajax handling?
Corrected and pushed. Please do an update and give it a try. Br's, Marius On Jul 2, 8:56 am, "marius d." wrote: > On Jul 2, 12:40 am, Kris Nuttycombe wrote: > > > > > To answer my own question, looking over the commit log 28595307 looks > > extremely suspicious. I can revert it locally but would prefer a > > mainline fix, and don't want to attempt it myself. Marius? > > > Kris > > > On Wed, Jul 1, 2009 at 3:33 PM, Kris > > > Nuttycombe wrote: > > > Hi, all, > > > > Have there been recent changes made to liftAjax.js? I am encountering > > > new errors from an ajaxSelect() today that were not present yesterday. > > > Firebug complains: > > > > Use of getBoxObjectFor() is deprecated. Try to use > > > element.getBoundingClientRect() if possible. > > > [Break on this error] undefined > > > liftAjax.js (line 111) > > > aboutToSend.responseType is null > > > lift_doAjaxCycle()()liftAjax.js (line 111) > > > lift_ajaxHandler()()liftAjax.js (line 21) > > > onchange(change )add_trig...Gyw%3D%3D (line 2) > > > [Break on this error] if (aboutToSend.responseType.toLowerCase() === > > > "json") > > That is my commt but right now I don,t see how it affects other > things ... But I,ll definitely look on it today. Note that there is no > intent for ajax behavior changes .. Just an augmentation ... > > > > Thanks, > > > > Kris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: Changes to ajax handling?
On Jul 2, 12:40 am, Kris Nuttycombe wrote: > To answer my own question, looking over the commit log 28595307 looks > extremely suspicious. I can revert it locally but would prefer a > mainline fix, and don't want to attempt it myself. Marius? > > Kris > > On Wed, Jul 1, 2009 at 3:33 PM, Kris > > Nuttycombe wrote: > > Hi, all, > > > Have there been recent changes made to liftAjax.js? I am encountering > > new errors from an ajaxSelect() today that were not present yesterday. > > Firebug complains: > > > Use of getBoxObjectFor() is deprecated. Try to use > > element.getBoundingClientRect() if possible. > > [Break on this error] undefined > > liftAjax.js (line 111) > > aboutToSend.responseType is null > > lift_doAjaxCycle()()liftAjax.js (line 111) > > lift_ajaxHandler()()liftAjax.js (line 21) > > onchange(change )add_trig...Gyw%3D%3D (line 2) > > [Break on this error] if (aboutToSend.responseType.toLowerCase() === "json") That is my commt but right now I don,t see how it affects other things ... But I,ll definitely look on it today. Note that there is no intent for ajax behavior changes .. Just an augmentation ... > > Thanks, > > > Kris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: Changes to ajax handling?
To answer my own question, looking over the commit log 28595307 looks
extremely suspicious. I can revert it locally but would prefer a
mainline fix, and don't want to attempt it myself. Marius?
Kris
On Wed, Jul 1, 2009 at 3:33 PM, Kris
Nuttycombe wrote:
> Hi, all,
>
> Have there been recent changes made to liftAjax.js? I am encountering
> new errors from an ajaxSelect() today that were not present yesterday.
> Firebug complains:
>
> Use of getBoxObjectFor() is deprecated. Try to use
> element.getBoundingClientRect() if possible.
> [Break on this error] undefined
> liftAjax.js (line 111)
> aboutToSend.responseType is null
> lift_doAjaxCycle()()liftAjax.js (line 111)
> lift_ajaxHandler()()liftAjax.js (line 21)
> onchange(change )add_trig...Gyw%3D%3D (line 2)
> [Break on this error] if (aboutToSend.responseType.toLowerCase() === "json") {
>
>
> Thanks,
>
> Kris
>
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"Lift" group.
To post to this group, send email to liftweb@googlegroups.com
To unsubscribe from this group, send email to
liftweb+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/liftweb?hl=en
-~--~~~~--~~--~--~---
