[Lift] Re: Code review for some Mailer enhancements

2009-08-05 Thread David Pollak
Spencer, I've taken your suggestions and rolled them into Lift... see the enclosed diff. Thanks for making the suggestion. David On Wed, Jul 8, 2009 at 3:29 PM, Spencer Uresk sur...@gmail.com wrote: As I alluded to in another email, the way Lift's Mailer class works causes some problems

[Lift] Re: Code review for some Mailer enhancements

2009-07-09 Thread Derek Chen-Becker
The code looks OK. Stylistically I would do things a little differently for getJndiSession: import net.liftweb.util.{Box,Full,Failure,Helpers} import Helpers._ private def getJndiSession: Box[Session] = jndiName.flatMap { jndiSessionName = tryo(thrown = Log.error(Cannot lookup session from