[Lift] Re: Moving to streaming upload API
Let's add it to the 1.1 backlog and see where we get. It might work out well for the refactoring of Req due to the coding of portlets, etc. On Tue, Apr 21, 2009 at 12:28 PM, Tim Perrett timo...@getintheloop.euwrote: Guys, I've been taking a close look at the way lift handles uploads. Right now were putting the entire thing (upload) into memory. This, IMO, is not a good look. I managed to crash my whole laptop as Jetty scrabbled for memory to store a massive upload I was trying. Looking at the commons upload API it appears it has pretty good support for streaming: http://commons.apache.org/fileupload/streaming.html Can we not rework the upload support in Req.scala to use a streaming methodology instead? A sweet by-product will be easily able to do CometActor based upload progress bars ;-) Thoughts? Cheers, Tim -- Lift, the simply functional web framework http://liftweb.net Beginning Scala http://www.apress.com/book/view/1430219890 Follow me: http://twitter.com/dpp Git some: http://github.com/dpp --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: Moving to streaming upload API
I would vote for adding streaming and leaving the choice to the user. Derek On Tue, Apr 21, 2009 at 1:28 PM, Tim Perrett timo...@getintheloop.euwrote: Guys, I've been taking a close look at the way lift handles uploads. Right now were putting the entire thing (upload) into memory. This, IMO, is not a good look. I managed to crash my whole laptop as Jetty scrabbled for memory to store a massive upload I was trying. Looking at the commons upload API it appears it has pretty good support for streaming: http://commons.apache.org/fileupload/streaming.html Can we not rework the upload support in Req.scala to use a streaming methodology instead? A sweet by-product will be easily able to do CometActor based upload progress bars ;-) Thoughts? Cheers, Tim --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: Moving to streaming upload API
+1, having the choice would be good. Seems like it would be simple to add it to LiftRules for user configuration. @dpp What other re-factoring of Req did you have in mind? Id have a poke about with the streaming stuff but I get the impression it might be a bit wasted depending on what you have planned ahead? Cheers, Tim On Apr 21, 8:31 pm, Derek Chen-Becker dchenbec...@gmail.com wrote: I would vote for adding streaming and leaving the choice to the user. Derek --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: Moving to streaming upload API
Uploads have remained quite mysterious and difficult for me. I'm all for anything that makes it easier to do them. Less memory usage is good, too. Chas. Tim Perrett wrote: Guys, I've been taking a close look at the way lift handles uploads. Right now were putting the entire thing (upload) into memory. This, IMO, is not a good look. I managed to crash my whole laptop as Jetty scrabbled for memory to store a massive upload I was trying. Looking at the commons upload API it appears it has pretty good support for streaming: http://commons.apache.org/fileupload/streaming.html Can we not rework the upload support in Req.scala to use a streaming methodology instead? A sweet by-product will be easily able to do CometActor based upload progress bars ;-) Thoughts? Cheers, Tim --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: Moving to streaming upload API
On Tue, Apr 21, 2009 at 12:38 PM, Timothy Perrett timo...@getintheloop.euwrote: +1, having the choice would be good. Seems like it would be simple to add it to LiftRules for user configuration. @dpp What other re-factoring of Req did you have in mind? Id have a poke about with the streaming stuff but I get the impression it might be a bit wasted depending on what you have planned ahead? HttpServletRequest has to be put in a Box and a few other things. I'm not sure how to do the streaming upload, so this is not a promise to get it into 1.1 Cheers, Tim On Apr 21, 8:31 pm, Derek Chen-Becker dchenbec...@gmail.com wrote: I would vote for adding streaming and leaving the choice to the user. Derek -- Lift, the simply functional web framework http://liftweb.net Beginning Scala http://www.apress.com/book/view/1430219890 Follow me: http://twitter.com/dpp Git some: http://github.com/dpp --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
