[Lift] Re: Need access to session variables when about to shut down a session.

2009-02-05 Thread Kris Nuttycombe
David, I'm a little confused by how to use registerCleanupFunc after your most recent set of changes. It now appears to be package-private, so what is the recommended way to register a cleanup func for a RequestVar? Previously, I'd implemented my JNDIResource class for use with the JPA stuff like

[Lift] Re: Need access to session variables when about to shut down a session.

2009-02-05 Thread Kris Nuttycombe
Just to clarify, the use case for this post-assignment initialization is this: object EM extends JNDIResource[EntityManager](java:comp/env/persistence/em) with ScalaEntityManager { object t extends JNDIResource[UserTransaction](java:comp/UserTransaction) override protected def initialize(em

[Lift] Re: Need access to session variables when about to shut down a session.

2009-02-05 Thread David Pollak
On Thu, Feb 5, 2009 at 12:13 PM, Kris Nuttycombe kris.nuttyco...@gmail.comwrote: David, I'm a little confused by how to use registerCleanupFunc after your most recent set of changes. It now appears to be package-private, so what is the recommended way to register a cleanup func for a

[Lift] Re: Need access to session variables when about to shut down a session.

2009-02-05 Thread Kris Nuttycombe
On Thu, Feb 5, 2009 at 1:43 PM, David Pollak feeder.of.the.be...@gmail.comwrote: On Thu, Feb 5, 2009 at 12:13 PM, Kris Nuttycombe kris.nuttyco...@gmail.com wrote: David, I'm a little confused by how to use registerCleanupFunc after your most recent set of changes. It now appears to be

[Lift] Re: Need access to session variables when about to shut down a session.

2009-02-05 Thread Alli
This works now smoothly. On Feb 5, 8:50 pm, Kris Nuttycombe kris.nuttyco...@gmail.com wrote: On Thu, Feb 5, 2009 at 1:43 PM, David Pollak feeder.of.the.be...@gmail.comwrote: On Thu, Feb 5, 2009 at 12:13 PM, Kris Nuttycombe kris.nuttyco...@gmail.com wrote: David, I'm a little

[Lift] Re: Need access to session variables when about to shut down a session.

2009-02-04 Thread Alli
Hey David, Two questions this time: I've been playing with your commit earlier today and cleaning up SessionVar's. I got: object sessDirHash extends SessionVar[String]() { def cleanUpFunc(sess: LiftSession) = { println(Got hash: + this.is) } In my test snippet I got: sessDirHash(this is

[Lift] Re: Need access to session variables when about to shut down a session.

2009-02-04 Thread David Pollak
That's because cleanUpFunc is gone. You must do: object sessDirHash extends SessionVar[String]() { registerCleanupFunc(session = println(Got hash: + this.is)) } On Wed, Feb 4, 2009 at 12:43 PM, Alli allilis...@gmail.com wrote: Hey David, Two questions this time: I've been playing with

[Lift] Re: Need access to session variables when about to shut down a session.

2009-02-04 Thread Alli
Sorry, for some reason the whole stuff i copy/pasted didn't get in: object sessDirHash extends SessionVar[String]() { def cleanUpFunc(sess: LiftSession) = { println(Got hash: + this.is) registerCleanUpFunc(cleanUpFunc _) } Anyway I changed it to this: object sessDirHash extends

[Lift] Re: Need access to session variables when about to shut down a session.

2009-02-04 Thread Kris Nuttycombe
Heh, this one just bit me too. I can't say I didn't warn myself, though: // This is way too dependent upon an implementation detail of the superclass. override def cleanupFunc : Box[() = Unit] = { ... } Kris On Wed, Feb 4, 2009 at 1:47 PM, David Pollak

[Lift] Re: Need access to session variables when about to shut down a session.

2009-02-04 Thread David Pollak
I've just realized that I'm a complete idiot. I need to totally re-do the clean-up mechanism. Please give me an hour. On Wed, Feb 4, 2009 at 3:06 PM, Kris Nuttycombe kris.nuttyco...@gmail.comwrote: Heh, this one just bit me too. I can't say I didn't warn myself, though: // This is way too

[Lift] Re: Need access to session variables when about to shut down a session.

2009-02-04 Thread Alli
No worries, the session vars seem to be reset to their default values before the callback gets called. I followed the code myself in Vars and LiftSession and couldn't find anything wrong. Will look at your change set tomorrow to learn better how this works. If i spot possible bugs I would like

[Lift] Re: Need access to session variables when about to shut down a session.

2009-02-03 Thread Alli
Makes a lot of sense, thanks David. Always amazes me how good and clean the design of lift is. On Feb 3, 9:49 pm, David Pollak feeder.of.the.be...@gmail.com wrote: On Tue, Feb 3, 2009 at 1:06 PM, Alli allilis...@gmail.com wrote: Evening, During the lifetime of a session, the session may

[Lift] Re: Need access to session variables when about to shut down a session.

2009-02-03 Thread David Pollak
On Tue, Feb 3, 2009 at 1:06 PM, Alli allilis...@gmail.com wrote: Evening, During the lifetime of a session, the session may have uploaded bunch of files and these need to be able to be destroyed/unlinked when a session ends. When user uploads a file it's parent dir is determined by the

[Lift] Re: Need access to session variables when about to shut down a session.

2009-02-03 Thread David Pollak
Crud. It looks like the session cleanup is done outside of the session scope. Are you using 0.11-SNAPSHOT? On Tue, Feb 3, 2009 at 4:35 PM, Alli allilis...@gmail.com wrote: Been testing this stuff and my object is like this: object ReportAddress extends SessionVar[String]() { def

[Lift] Re: Need access to session variables when about to shut down a session.

2009-02-03 Thread David Pollak
0.11-SNAPSHOT is 0.10 with bug fixes. It's very stable and will be 1.0 on 2/26. I'll commit up a fix to this problem in a few minutes. Also, what's the URL of the site? :-) On Tue, Feb 3, 2009 at 4:58 PM, Alli allilis...@gmail.com wrote: 0.10 at the moment, reckon i should upgrade to 0.11?