[Lift] Re: QA, before merging code

2009-06-18 Thread marius d.

Oliver thanks for raising this flag. I'll try to look later on today
one more time at the code as I'm not sure I fully understand the
principles of your addition. I remember doing some comments on the
topic but haven't looked on your code for a while.

Are you willing to have a quick chat on it ?


Br's,
Marius

On Jun 18, 3:00 am, Oliver Lambert olambo...@gmail.com wrote:
 Hi,

 Seems theres been a little bit of discussion about methodologies of coding
 and development processes in the latest threads which is cool
 and makes me think about my current coding efforts.

 I created a branch a while ago where I put in my take on a slightly
 alternative (or complementary?) binding process (the particular code
 adds a bind by name to BindHelpers). I was hoping for some feedback from a
 few of you (David, Marius, and anyone else) before
 merging it back with the main site, as I feel what I have done might be
 contentious and I don't want to cause any problems.

 Whats the normal process of committing changes. Is the code QA'ed in some
 way or do I just do it,and wait for people to say #!.

 cheers
 Oliver
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Lift group.
To post to this group, send email to liftweb@googlegroups.com
To unsubscribe from this group, send email to 
liftweb+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/liftweb?hl=en
-~--~~~~--~~--~--~---



[Lift] Re: QA, before merging code

2009-06-17 Thread David Pollak
On Wed, Jun 17, 2009 at 5:00 PM, Oliver Lambert olambo...@gmail.com wrote:

 Hi,

 Seems theres been a little bit of discussion about methodologies of coding
 and development processes in the latest threads which is cool
 and makes me think about my current coding efforts.

 I created a branch a while ago where I put in my take on a slightly
 alternative (or complementary?) binding process (the particular code
 adds a bind by name to BindHelpers). I was hoping for some feedback from a
 few of you (David, Marius, and anyone else) before
 merging it back with the main site, as I feel what I have done might be
 contentious and I don't want to cause any problems.


Generally, let me or Marius or Derek or one of the other been around Lift
for a while guys take a look at the code.  Then check it into the main
branch and let people give you feedback.

Please make sure to do a mvn clean install before pushing code to make sure
all compiles and passes tests.




 Whats the normal process of committing changes. Is the code QA'ed in some
 way or do I just do it,and wait for people to say #!.

 cheers
 Oliver

 



-- 
Lift, the simply functional web framework http://liftweb.net
Beginning Scala http://www.apress.com/book/view/1430219890
Follow me: http://twitter.com/dpp
Git some: http://github.com/dpp

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Lift group.
To post to this group, send email to liftweb@googlegroups.com
To unsubscribe from this group, send email to 
liftweb+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/liftweb?hl=en
-~--~~~~--~~--~--~---