[Lift] Re: Response Optimizations too aggressive

2010-03-07 Thread aw
On Mar 4, 9:50 am, David Pollak wrote: > On Thu, Mar 4, 2010 at 9:27 AM, aw wrote: > > On Mar 4, 6:56 am, Naftoli Gugenheim wrote: > > > How about > > > LiftRules.stripComments.default.set( () => !Req.isIE) > > > etc.? > > This is where Lift's FactoryMaker shines.  You can modify the behavior o

Re: [Lift] Re: Response Optimizations too aggressive

2010-03-05 Thread Timothy Perrett
This really needs to go on the wiki! gold! Cheers, Tim On 4 Mar 2010, at 17:50, David Pollak wrote: > > > On Thu, Mar 4, 2010 at 9:27 AM, aw wrote: > On Mar 4, 6:56 am, Naftoli Gugenheim wrote: > > How about > > LiftRules.stripComments.default.set( () => !Req.isIE) > > etc.? > > This is whe

Re: [Lift] Re: Response Optimizations too aggressive

2010-03-04 Thread David Pollak
On Thu, Mar 4, 2010 at 9:27 AM, aw wrote: > On Mar 4, 6:56 am, Naftoli Gugenheim wrote: > > How about > > LiftRules.stripComments.default.set( () => !Req.isIE) > > etc.? > This is where Lift's FactoryMaker shines. You can modify the behavior of stripComments on a request-by-request basis. You

[Lift] Re: Response Optimizations too aggressive

2010-03-04 Thread aw
On Mar 4, 6:56 am, Naftoli Gugenheim wrote: > How about > LiftRules.stripComments.default.set( () => !Req.isIE) > etc.? Well, this doesn't quite work because I need a Req class instance, not just the static object. Also, to me, this determination is really at the Session level rather than the Req

Re: [Lift] Re: Response Optimizations too aggressive

2010-03-04 Thread Naftoli Gugenheim
How about LiftRules.stripComments.default.set( () => !Req.isIE) etc.? - aw wrote: OK, I have disabled the stripping of comments: LiftRules.stripComments.default.set( () => false ) It seems to work for me. On Mar 4, 12:36 am, Jeppe Nejsum Madsen wrote:

Re: [Lift] Re: Response Optimizations too aggressive

2010-03-04 Thread Timothy Perrett
Personally, I don't like this API. nearly everyone has problems with it as its totally not obvious. Perhaps i'll add some more comments to the definition. Cheers, Tim On 4 Mar 2010, at 08:50, aw wrote: > OK, I have disabled the stripping of comments: > >LiftRules.stripComments.default.set

[Lift] Re: Response Optimizations too aggressive

2010-03-04 Thread aw
OK, I have disabled the stripping of comments: LiftRules.stripComments.default.set( () => false ) It seems to work for me. On Mar 4, 12:36 am, Jeppe Nejsum Madsen wrote: > aw writes: > >     > > Ross already described how to disable this, but this seems like a > genuine useful feature (t

Re: [Lift] Re: Response Optimizations too aggressive

2010-03-04 Thread Jeppe Nejsum Madsen
On Thu, Mar 4, 2010 at 8:47 AM, aw wrote: > > On Mar 3, 10:56 pm, Ross Mellgren wrote: >> There's a FactoryMaker in LiftRules that looks like it may do what you want >> -- try: >> >> LiftRules.stripComments.default = () => false >> >> -Ross > > This looks promising.  Alas:  error: reassignment t

[Lift] Re: Response Optimizations too aggressive

2010-03-03 Thread aw
On Mar 3, 10:56 pm, Ross Mellgren wrote: > There's a FactoryMaker in LiftRules that looks like it may do what you want > -- try: > > LiftRules.stripComments.default = () => false > > -Ross This looks promising. Alas: error: reassignment to val (I'm not familiar with FactoryMaker.) I see tha