On Thu, Oct 22, 2009 at 12:58 AM, Heiko Seeberger < heiko.seeber...@googlemail.com> wrote:
> > > > On 2009-10-21 13:17:36.007575, Marius Danciu wrote: > > > The fix looks correct for this feature, but I'm not convinced that this > proposed feature is the right approach. If a page contains both msg and msgs > + showall, the message would be duplicated. There is no rule that promotes > mutual exclusivity for msg and msgs+showall and if it should or should not > exist is also debatable. > > First I would like to point out that I do have exactly this requirement in > an ongoing project to show all messages (related to fields and not related) > in the top area of a page. Currently this is not (easily) possible with Msgs > and Msg, because you have to know the fields for Msg and Msg will render > differently than Msgs (span vs. div). As I have seen this requirement in > many recent projects, I believe it is not too unique, hence others could > benefit from this enhancement. > > Second, I do not understand your concerns. As long as noone sets showAll to > true, nothing will change in regards how Msg and Msgs are working today, > i.e. no messages will be duplicated. If someone deliberately decides to set > showAll to true, he will certainly have to deal with the consequences. > I agree with this position. The change has common benefits and it's not changing default behavior. (cc'ing the Lift list in case anyone else wants to chime in) > > > - Heiko > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.liftweb.net/r/55/#review135 > ----------------------------------------------------------- > > > On 2009-10-22 00:57:49.136378, Heiko Seeberger wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://reviewboard.liftweb.net/r/55/ > > ----------------------------------------------------------- > > > > (Updated 2009-10-22 00:57:49.136378) > > > > > > Review request for Derek Chen-Becker, David Pollak, Marius Danciu, Viktor > Klang, Charles Munat, Heiko Seeberger, Joni Freeman, Atsuhiko Yamanaka, > Jorge Ortiz, Naftoli Gugenheim, Kris Nuttycombe, Indrajit Raychaudhuri, and > Alex Boisvert. > > > > > > Summary > > ------- > > > > Issue 123: Enhance Msgs snippet to optionally show all messages > > > > The Msgs built-in snippet will only display messages NOT related to a > particular field. This makes using some of the ProtoUser's templates a tough > job, e.g. for editing the user or changing the password, because these will > bring up errors with and without relation to fields. > > > > This change will add an optional attribute showAll to the Msgs element > which lets Msgs display all messages if set to true. > > > > > > This addresses bug 123. > > http://github.com/dpp/liftweb/issues#issue/123 > > > > > > Diffs > > ----- > > > > lift/src/main/scala/net/liftweb/builtin/snippet/Msgs.scala ed8ae96 > > lift/src/main/scala/net/liftweb/http/S.scala a0a8661 > > > > Diff: http://reviewboard.liftweb.net/r/55/diff > > > > > > Testing > > ------- > > > > > > Thanks, > > > > Heiko > > > > > > -- Lift, the simply functional web framework http://liftweb.net Beginning Scala http://www.apress.com/book/view/1430219890 Follow me: http://twitter.com/dpp Surf the harmonics --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~----------~----~----~----~------~----~------~--~---
