Re: [Lightning-dev] Dropping Tor v2 onion services from node_announcement

2021-09-22 Thread Olaoluwa Osuntokun
Earlier this week I was helping a user debug a Tor related issue, and
realized (from the logs) that some newer Tor clients are already refusing to
connect out to v2 onion services.

On the lnd side, I think we'll move to disallow users creating a v2 onion
service in our next major release (0.14), and also possibly "upgrade" them
to a v3 onion service if their node supports it. I've made a tracking issue
here: https://github.com/lightningnetwork/lnd/issues/5771

I ran a naive script to gauge how much of the network is using Tor
generally, and also v2 onion services extract the following stats:
```
num nodes:  12844
num tor:  8793
num num v2:  66
num num v3:  8777
```

This counts advertised addresses total, so it likely over estimates, so you
can treat this as an upper bound. Thankfully only 60 or so v2 addresses seem
to be even _advertised_ on the network, so I don't think this'll cause much
disruption.

Another interesting tidbit here is that: _over half_ of all advertised
addresses on the network today are onion services. I wonder how the rise of
onion service usage (many nodes being tor-only) has affected: e2e payment
latency, general connection stability, and gossip announcement propagation.

In terms of actions we need to take at the spec level, it's likely enough to
amend the section on addrs in the node_announcement message to advise
implementations to _ignore_ the v2 addr type.

-- Laolu

On Tue, Jun 1, 2021 at 3:19 PM darosior via Lightning-dev <
lightning-dev@lists.linuxfoundation.org> wrote:

> Hi all,
>
> It's been almost 9 months since Tor v2 hidden services have been
> deprecated.
> The Tor project will drop v2 support in about a month in the latest
> release. It will then be entirely be dropped from all supported releases by
> October.
> More at https://blog.torproject.org/v2-deprecation-timeline .
>
> Bitcoin Core defaults to v3 since 0.21.0 (
> https://bitcoincore.org/en/releases/0.21.0/) and is planning to drop the
> v2 support for 0.22 (https://github.com/bitcoin/bitcoin/pull/22050),
> which means that v2 onions will gradually stop being gossiped on the
> Bitcoin network.
>
> I think we should do the same for the Lightning network, and the timeline
> is rather tight. Also, the configuration is user-facing (as opposed to
> Bitcoin Core, which generates ephemeral services) which i expect to make
> the transition trickier.
> C-lightning is deprecating the configuration of Tor v2 services starting
> next release, according to our deprecation policy we should be able to
> entirely drop its support 3 releases after this one, which should be not so
> far from the October deadline.
>
> Opinions? What is the state of other implementations with regard to Tor v2
> support?
>
> Antoine
> ___
> Lightning-dev mailing list
> Lightning-dev@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/lightning-dev
>
___
Lightning-dev mailing list
Lightning-dev@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/lightning-dev


Re: [Lightning-dev] Dropping Tor v2 onion services from node_announcement

2021-06-10 Thread Matt Corallo
There isn’t a lot to do at the spec level to deprecate them - nodes should 
start ignoring the addresses bug nodes always need to know the length/parse v2 
Onion addresses forever as well as store and forward them. We could amend the 
spec to say that nodes shouldn’t produce them but it won’t change the 
receive/process end much.

> On Jun 1, 2021, at 18:19, darosior via Lightning-dev 
>  wrote:
> 
> Hi all,
> 
> It's been almost 9 months since Tor v2 hidden services have been deprecated.
> The Tor project will drop v2 support in about a month in the latest release. 
> It will then be entirely be dropped from all supported releases by October.
> More at https://blog.torproject.org/v2-deprecation-timeline .
> 
> Bitcoin Core defaults to v3 since 0.21.0 
> (https://bitcoincore.org/en/releases/0.21.0/) and is planning to drop the v2 
> support for 0.22 (https://github.com/bitcoin/bitcoin/pull/22050), which means 
> that v2 onions will gradually stop being gossiped on the Bitcoin network.
> 
> I think we should do the same for the Lightning network, and the timeline is 
> rather tight. Also, the configuration is user-facing (as opposed to Bitcoin 
> Core, which generates ephemeral services) which i expect to make the 
> transition trickier.
> C-lightning is deprecating the configuration of Tor v2 services starting next 
> release, according to our deprecation policy we should be able to entirely 
> drop its support 3 releases after this one, which should be not so far from 
> the October deadline.
> 
> Opinions? What is the state of other implementations with regard to Tor v2 
> support?
> 
> Antoine
> ___
> Lightning-dev mailing list
> Lightning-dev@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/lightning-dev
___
Lightning-dev mailing list
Lightning-dev@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/lightning-dev


Re: [Lightning-dev] Dropping Tor v2 onion services from node_announcement

2021-06-01 Thread Peter Todd
On Tue, Jun 01, 2021 at 10:18:42PM +, darosior via Lightning-dev wrote:
> Hi all,
> 
> It's been almost 9 months since Tor v2 hidden services have been deprecated.
> The Tor project will drop v2 support in about a month in the latest release. 
> It will then be entirely be dropped from all supported releases by October.
> More at https://blog.torproject.org/v2-deprecation-timeline .
> 
> Bitcoin Core defaults to v3 since 0.21.0 
> (https://bitcoincore.org/en/releases/0.21.0/) and is planning to drop the v2 
> support for 0.22 (https://github.com/bitcoin/bitcoin/pull/22050), which means 
> that v2 onions will gradually stop being gossiped on the Bitcoin network.
> 
> I think we should do the same for the Lightning network, and the timeline is 
> rather tight. Also, the configuration is user-facing (as opposed to Bitcoin 
> Core, which generates ephemeral services) which i expect to make the 
> transition trickier.
> C-lightning is deprecating the configuration of Tor v2 services starting next 
> release, according to our deprecation policy we should be able to entirely 
> drop its support 3 releases after this one, which should be not so far from 
> the October deadline.
> 
> Opinions? What is the state of other implementations with regard to Tor v2 
> support?

One small point re: discussing this topic: remember that Tor is a centralized
system with a centralized consensus and directory authorities. So when they say
they are dropping v2 hidden services, at some point in the near future that
central infrastructure will also drop v2 hidden service support, and v2 hidden
services _will_ stop working on the Tor network. So it is pointless to keep
support for v2 hidden services beyond Tor's stated deadlines (other than things
like maybe ignoring old v2-related config options and the like).

-- 
https://petertodd.org 'peter'[:-1]@petertodd.org


signature.asc
Description: PGP signature
___
Lightning-dev mailing list
Lightning-dev@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/lightning-dev


[Lightning-dev] Dropping Tor v2 onion services from node_announcement

2021-06-01 Thread darosior via Lightning-dev
Hi all,

It's been almost 9 months since Tor v2 hidden services have been deprecated.
The Tor project will drop v2 support in about a month in the latest release. It 
will then be entirely be dropped from all supported releases by October.
More at https://blog.torproject.org/v2-deprecation-timeline .

Bitcoin Core defaults to v3 since 0.21.0 
(https://bitcoincore.org/en/releases/0.21.0/) and is planning to drop the v2 
support for 0.22 (https://github.com/bitcoin/bitcoin/pull/22050), which means 
that v2 onions will gradually stop being gossiped on the Bitcoin network.

I think we should do the same for the Lightning network, and the timeline is 
rather tight. Also, the configuration is user-facing (as opposed to Bitcoin 
Core, which generates ephemeral services) which i expect to make the transition 
trickier.
C-lightning is deprecating the configuration of Tor v2 services starting next 
release, according to our deprecation policy we should be able to entirely drop 
its support 3 releases after this one, which should be not so far from the 
October deadline.

Opinions? What is the state of other implementations with regard to Tor v2 
support?

Antoine
___
Lightning-dev mailing list
Lightning-dev@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/lightning-dev