[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

- **status**: Fixed --> Verified --- ** [issues:#1388] Support OpenType font features** **Status:** Verified **Labels:** Fixed_2_19_63 **Created:** Mon Nov 08, 2010 10:34 PM UTC by Anonymous **Last Updated:** Mon Jun 19, 2017 03:01 PM UTC **Owner:** horndude77 *Originally created by:*

Re: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

On 26 June 2017 at 09:32, Xavier Scheuer wrote: > > Hello, > > Sorry, I come after the push. > > A. In order to give this nice and long-wanted (also by users other > than me) feature some visibility, could it be documented in the > Notation Reference as well (NR 1.8.3 Fonts)?

Re: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

Hello, Sorry, I come after the push. A. In order to give this nice and long-wanted (also by users other than me) feature some visibility, could it be documented in the Notation Reference as well (NR 1.8.3 Fonts)? So the users will not only be able to use it, but also know how it (finally)

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

- **labels**: --> Fixed_2_19_63 - **status**: Started --> Fixed - **Patch**: push --> - **Comment**: I've pushed to staging. commit 8cf69a467ad7650f5ca9da6fe2dfd4c7c088b239 Issue 1388: Initial work to support opentype font features. Thank you. --- ** [issues:#1388] Support OpenType font

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

Patch counted down - please push. Hosoda-san can push this at the same time he pushes his fix for https://sourceforge.net/p/testlilyissues/issues/5147/ --- ** [issues:#1388] Support OpenType font features** **Status:** Started **Created:** Mon Nov 08, 2010 10:34 PM UTC by Anonymous **Last

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

Understood. Patch attached. Thanks. Attachments: - [0001-Initial-work-to-support-opentype-font-features.patch](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/ec7b7711/ff0d/attachment/0001-Initial-work-to-support-opentype-font-features.patch) (7.2 kB; text/x-patch) --- **

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

I'd like the following information for commiting your patch. * author's name * author's email * date of written * commit message Rietveld's patch file (https://codereview.appspot.com/download/issue323850043_20001.diff) does not contain them. `git format-patch` command genarates a patch

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

Patch can be downloaded as part of the review (https://codereview.appspot.com/download/issue323850043_20001.diff) or are you looking for something else? --- ** [issues:#1388] Support OpenType font features** **Status:** Started **Created:** Mon Nov 08, 2010 10:34 PM UTC by Anonymous **Last

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

If I understand correctly, LilyDev 4.1 cannot compile this patch. In my humble opinion, it is necessary that LilyDev 4.1 can compile it. I've uploaded an additional patch that can be compiled by LilyDev 4.1. https://sourceforge.net/p/testlilyissues/issues/5147/ Jay, would you send us the git

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

- **Patch**: countdown --> push - **Comment**: This can now be pushed - I am waiting on some approval from the other Devs (as far as I could see it was only LilyDev that was going to have problems with this change), and as Paul does not have commit access, if this gets approved one of the

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

How about the following method? * configure script checks whether Pango's version is 1.38 or above. * If Pango's version is 1.38+, configure makes that `config.hh` defines something like `HAVE_PANGO_1_38`. * In `lily/pango-font.cc`, enclose around `pango_attr_font_features_new ()` with `#ifdef

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

- **Patch**: review --> countdown - **Comment**: So as far as I can tell there is nothing wrong with this going on countdown for June 11th (we will have to update LilyDev, but I don't see that as a blocking 'thing' for this patch). Patch on countdown for June 11th --- ** [issues:#1388]

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

Yes, I think so. Alternatively there is a way to install Guile 1.8 to LilyDev 5.2. Another solution is to use Ubuntu 16.04 which has Pango 1.38.1 and Guile 1.8. --- ** [issues:#1388] Support OpenType font features** **Status:** Started **Created:** Mon Nov 08, 2010 10:34 PM UTC by Anonymous

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

So developers would need to have LilyDev 4.2 (with some version of Pango 1.40?) before we could push this patch? --- ** [issues:#1388] Support OpenType font features** **Status:** Started **Created:** Mon Nov 08, 2010 10:34 PM UTC by Anonymous **Last Updated:** Mon Jun 05, 2017 02:05 PM UTC

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

If I understand correctly, Current GUB has Pango 1.40.1. https://github.com/gperciva/gub/blob/fb232e24ade8a5cdec8bbb46b086bf8e506021a8/gub/specs/pango.py There will be no problem. LilyDev 4.1 or Debian jessie has Pango 1.36.8. https://packages.debian.org/jessie/libpango-1.0-0 We cannot use

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

- **Needs**: --> - **Patch**: new --> review - **Type**: --> Enhancement - **Comment**: Passes make, make check and a full make doc. As to the Pango version requirements, I am going to have to defer to teh rest of the dev team. My own Ubuntu 16:04 LTS system (I haven't checked my Home

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

> Jay, do you need someone else to push this for you (I can not recall who does > and who does not have commit access) or is this waiting on something else? I'd need someone else to push. It'd be useful for is someone to assess the version of pango. Sorry, I hadn't revisited this earlier

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

Update minimum pango version http://codereview.appspot.com/323850043 --- ** [issues:#1388] Support OpenType font features** **Status:** Started **Created:** Mon Nov 08, 2010 10:34 PM UTC by Anonymous **Last Updated:** Mon Jun 05, 2017 05:01 AM UTC **Owner:** horndude77 *Originally created

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

- **Comment**: Patch counted down - please push although you may need to rebase with current master. --- ** [issues:#1388] Support OpenType font features** **Status:** Started **Created:** Mon Nov 08, 2010 10:34 PM UTC by Anonymous **Last Updated:** Sat May 27, 2017 08:12 AM UTC **Owner:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

Patch counted down - please push. --- ** [issues:#1388] Support OpenType font features** **Status:** Started **Created:** Mon Nov 08, 2010 10:34 PM UTC by Anonymous **Last Updated:** Tue May 23, 2017 10:59 AM UTC **Owner:** horndude77 *Originally created by:* *anonymous *Originally created

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

- **Patch**: countdown --> push - **Comment**: Patch counted down - please push. --- ** [issues:#1388] Support OpenType font features** **Status:** Started **Created:** Mon Nov 08, 2010 10:34 PM UTC by Anonymous **Last Updated:** Sat May 20, 2017 08:15 AM UTC **Owner:** horndude77

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

- **Patch**: review --> countdown - **Comment**: Patch on countdown for May 23rd --- ** [issues:#1388] Support OpenType font features** **Status:** Started **Created:** Mon Nov 08, 2010 10:34 PM UTC by Anonymous **Last Updated:** Thu May 18, 2017 12:43 PM UTC **Owner:** horndude77

Re: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

On 18 May 2017 at 07:35, Auto mailings of changes to Lily Issues < testlilyissues-a...@lists.sourceforge.net> wrote: > > Initial work to support opentype font features > > Following up on an old patch I send to the list. One comment was to use a list > for combining multiple font features. This is

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

- **Patch**: new --> review - **Comment**: Passes make, make check and a full make doc. --- ** [issues:#1388] Support OpenType font features** **Status:** Started **Created:** Mon Nov 08, 2010 10:34 PM UTC by Anonymous **Last Updated:** Thu May 18, 2017 11:55 AM UTC **Owner:** horndude77

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

- Description has changed: Diff: - **assigned_to**: horndude77 - **Needs**: --> - **Type**: --> Enhancement --- ** [issues:#1388] Support OpenType font features** **Status:** Started **Created:** Mon Nov 08, 2010 10:34 PM UTC by Anonymous **Last Updated:** Thu May 18, 2017

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

--- ** [issues:#1388] Support OpenType font features** **Status:** Started **Created:** Mon Nov 08, 2010 10:34 PM UTC by Anonymous **Last Updated:** Mon May 04, 2015 12:23 PM UTC **Owner:** nobody *Originally created by:* *anonymous *Originally created by:*

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

Initial work to support opentype font features Following up on an old patch I send to the list. One comment was to use a list for combining multiple font features. This is now implemented. A possible issue is the pango API needed is somewhat newer. I'll investigate where I need to set that in an