[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4807 Wrong glissando slopes with accidental in target chord

- Description has changed: Diff: --- old +++ new @@ -1,3 +1,5 @@ +http://codereview.appspot.com/342100043 + As Harm reported, glissando slopes may be wrongly calculated, if there is an accidental on the target chord. This worked fine in v2.16.2. - **Patch**: review -->

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5318 Context regression tests

- **Patch**: review --> countdown - **Comment**: Patch on countdown for May 20th --- ** [issues:#5318] Context regression tests** **Status:** Started **Created:** Thu May 03, 2018 02:37 AM UTC by Dan Eble **Last Updated:** Sun May 13, 2018 12:27 PM UTC **Owner:** Dan Eble Context

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5320 beam.cc: avoid calculating an invalid reference

- **labels**: --> Fixed_2_21_0 - **status**: Started --> Fixed - **Patch**: push --> - **Type**: Enhancement --> Crash - **Comment**: Pushed to staging as commit d63756608d265d7a99444af1123b7be8a06f3cc2 Author: David Kastrup Date: Wed May 9 13:48:35 2018 +0200 Issue 5320:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5321 Parser: E_BACKSLASH should be two backslashes

- **labels**: --> Fixed_2_21_0 - **status**: Started --> Fixed - **Patch**: push --> - **Type**: Enhancement --> Defect - **Comment**: Pushed to staging as commit aa37e5ad9ab0d5a90c3d2ef0f250683089846f96 Author: David Kastrup Date: Wed May 9 15:36:41 2018 +0200 Issue

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5326 Generalize the special case of creating a Timing context

- **summary**: Issue : Generalize the special case of creating a Timing context --> Generalize the special case of creating a Timing context - Description has changed: Diff: --- old +++ new @@ -1,5 +1,3 @@ -Issue : Generalize the special case of creating a Timing context -into the

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5326 Issue XXXX: Generalize the special case of creating a Timing context

--- ** [issues:#5326] Issue : Generalize the special case of creating a Timing context** **Status:** Started **Created:** Mon May 21, 2018 12:39 PM UTC by Dan Eble **Last Updated:** Mon May 21, 2018 12:39 PM UTC **Owner:** nobody Issue : Generalize the special case of creating a

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5326 Generalize the special case of creating a Timing context

- **Patch**: new --> review - **Comment**: Passes make, make check and a full make doc. --- ** [issues:#5326] Generalize the special case of creating a Timing context** **Status:** Started **Created:** Mon May 21, 2018 12:39 PM UTC by Dan Eble **Last Updated:** Mon May 21, 2018 12:42 PM UTC

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5327 Allow Scheme/identifiers for duration multipliers

No good dead goes unpunished. Documentation and harmonization. http://codereview.appspot.com/346810043 --- ** [issues:#5327] Allow Scheme/identifiers for duration multipliers** **Status:** Started **Created:** Tue May 22, 2018 08:46 PM UTC by David Kastrup **Last Updated:** Wed May 23, 2018

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5326 Generalize the special case of creating a Timing context

- **Patch**: review --> push - **Comment**: Patch counted down - please push --- ** [issues:#5326] Generalize the special case of creating a Timing context** **Status:** Started **Created:** Mon May 21, 2018 12:39 PM UTC by Dan Eble **Last Updated:** Tue May 22, 2018 12:15 PM UTC **Owner:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5323 sort input files

The questions on this still have not been resolved so am leaving this on review. @Bernhard can you look at the Rietveld comments please? --- ** [issues:#5323] sort input files** **Status:** Started **Created:** Fri May 18, 2018 01:03 PM UTC by Bernhard M. Wiedemann **Last Updated:** Sun May

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5326 Generalize the special case of creating a Timing context

That was fast. I am somewhat sqeamish about the approach but don't see an obvious problem with it. Not requiring a special case for the Timing/Score pairing is good, of course. So my choice would have been to go with it and see whether or not that buys us problems. I just failed to timely

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5323 sort input files

sorting .o files instead of .cc http://codereview.appspot.com/347770043 --- ** [issues:#5323] sort input files** **Status:** Started **Created:** Fri May 18, 2018 01:03 PM UTC by Bernhard M. Wiedemann **Last Updated:** Wed May 23, 2018 12:28 PM UTC **Owner:** Bernhard M. Wiedemann sort

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5328 mf2pt1 uses random uniqueID

--- ** [issues:#5328] mf2pt1 uses random uniqueID** **Status:** New **Labels:** reproducible **Created:** Wed May 23, 2018 02:13 PM UTC by Bernhard M. Wiedemann **Last Updated:** Wed May 23, 2018 02:13 PM UTC **Owner:** nobody **Attachments:** -

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5326 Generalize the special case of creating a Timing context

- **labels**: --> Fixed_2_21_0 - **status**: Started --> Fixed - **Patch**: push --> - **Comment**: Pushed to staging: commit 648ac00067d409792605113c46639326aed27547 (HEAD -> pushed/issue-5326-context-create-timing, origin/staging) Author: Dan Eble Date:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5327 Allow Scheme/identifiers for duration multipliers

- Description has changed: Diff: - **Needs**: --> - **Patch**: new --> review - **Type**: --> Enhancement - **Comment**: Passes make, make check and a full make doc. --- ** [issues:#5327] Allow Scheme/identifiers for duration multipliers** **Status:** Started **Created:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5327 Allow Scheme/identifiers for duration multipliers

--- ** [issues:#5327] Allow Scheme/identifiers for duration multipliers** **Status:** Started **Created:** Tue May 22, 2018 08:46 PM UTC by David Kastrup **Last Updated:** Tue May 22, 2018 08:46 PM UTC **Owner:** nobody Allow Scheme/identifiers for duration multipliers Also contains

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5329 Improve make-bracket-bar-line

No, the problem arised only, if ]-bar was forced to have a thick span-bar, thus the test-case above. We don't have a regtest for this combination. And I think it would be too much to cover every possible combination of bar-lines/span-bars. But that's only me ... --- ** [issues:#5329] Improve

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5329 Improve make-bracket-bar-line

- **Patch**: review --> countdown - **Comment**: Patch on countdown for May 29th. --- ** [issues:#5329] Improve make-bracket-bar-line** **Status:** Started **Created:** Thu May 24, 2018 09:08 PM UTC by Thomas Morley **Last Updated:** Fri May 25, 2018 04:54 PM UTC **Owner:** Thomas Morley

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5323 sort input files

- **Patch**: review --> countdown - **Comment**: Patch on countdown for May 29th. --- ** [issues:#5323] sort input files** **Status:** Started **Created:** Fri May 18, 2018 01:03 PM UTC by Bernhard M. Wiedemann **Last Updated:** Thu May 24, 2018 12:07 PM UTC **Owner:** Bernhard M. Wiedemann

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5330 Allow use of Identity-H CMap and CID versions of Emmentaler

--- ** [issues:#5330] Allow use of Identity-H CMap and CID versions of Emmentaler** **Status:** New **Created:** Sat May 26, 2018 12:54 PM UTC by Knut Petersen **Last Updated:** Sat May 26, 2018 12:54 PM UTC **Owner:** Knut Petersen **Attachments:** -

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5330 Allow use of Identity-H CMap and CID versions of Emmentaler

Allow use of Identity-H CMap and CID versions of Emmentaler When -O TeX or -O TeX-GS is given, lilypond generates postscript code that instructs ghostscript to use the Identity-H CMap and CID versions of the emmentaler fonts. Used e.g. by 'make doc'. Without '-O TeX' or '-O TeX-GS' we still use

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5330 Allow use of Identity-H CMap and CID versions of Emmentaler

Any notion of what problems this might alleviate? Is there a conceivable rationale for "Without '-O TeX' or '-O TeX-GS' we still use the traditional postscript code." apart from being cautious by default? Without a tangible reason, it might make stuff more predictable by not differentiating

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5323 sort input files

- **Needs**: --> - **Patch**: new --> review - **Type**: --> Enhancement - **Comment**: Passes make, make check and a full make doc. --- ** [issues:#5323] sort input files** **Status:** Started **Created:** Fri May 18, 2018 01:03 PM UTC by Bernhard M. Wiedemann **Last Updated:** Wed May

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5329 Improve make-bracket-bar-line

--- ** [issues:#5329] Improve make-bracket-bar-line** **Status:** Started **Created:** Thu May 24, 2018 09:08 PM UTC by Thomas Morley **Last Updated:** Thu May 24, 2018 09:08 PM UTC **Owner:** nobody Improve make-bracket-bar-line The previously used ly:stencil-scale -1 1 resulted in

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5329 Improve make-bracket-bar-line

A test-case: ~~~ \version "2.19.81" \defineBarLine "]" #'("]" "" ".") \new StaffGroup << \new Staff { R1 \bar "]" } \new Staff { R1 } >> ~~~ current 2.19.81-output attached Attachments: -

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5323 sort input files

--- ** [issues:#5323] sort input files** **Status:** Started **Created:** Fri May 18, 2018 01:03 PM UTC by Bernhard M. Wiedemann **Last Updated:** Fri May 18, 2018 01:03 PM UTC **Owner:** nobody sort input files to have reproducible link order so that the lilypond binary always contains

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4807 Wrong glissando slopes with accidental in target chord

- **labels**: Regression --> Regression, Fixed_2_21_0 - **status**: Started --> Fixed - **Patch**: push --> - **Comment**: commit 4d958aa0ac05f7bc4c1b294e8697274a015d38fb Author: Malte Meyn Date: Sat May 12 10:53:45 2018 +0200 Issue 4807/2: add chord glissandi to

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5340 Simplify Spacing_spanner::get_columns

--- ** [issues:#5340] Simplify Spacing_spanner::get_columns** **Status:** Started **Created:** Mon Jun 11, 2018 11:02 AM UTC by Dan Eble **Last Updated:** Mon Jun 11, 2018 11:02 AM UTC **Owner:** nobody Simplify Spacing_spanner::get_columns The old algorithm filtered the system's list of

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5341 Urgent corrections to stencil-integral.cc (skylines)

--- ** [issues:#5341] Urgent corrections to stencil-integral.cc (skylines)** **Status:** Started **Created:** Mon Jun 11, 2018 04:19 PM UTC by Torsten Hämmerle **Last Updated:** Mon Jun 11, 2018 04:19 PM UTC **Owner:** Torsten Hämmerle Garbage collection issue spotted by DAK:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5336 Expose hidden dynamic_casts in Grob_array and Grob_info

- **Patch**: countdown --> push - **Comment**: Patch counted down - please push. --- ** [issues:#5336] Expose hidden dynamic_casts in Grob_array and Grob_info** **Status:** Started **Created:** Tue Jun 05, 2018 03:03 AM UTC by Dan Eble **Last Updated:** Thu Jun 07, 2018 03:47 PM UTC

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5333 musicxml2ly: hidden timesigs and tempo marks with text.

- **Patch**: countdown --> push - **Comment**: Patch counted down - please push. Alex if you do not have commit access can you attach a git-formatted patch (based against current master) and I can push it for you. --- ** [issues:#5333] musicxml2ly: hidden timesigs and tempo marks with

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5334 Use system* instead of system when invoking browser

The patch is ok. It eliminates an obvious and easily exploitable security problem. --- ** [issues:#5334] Use system* instead of system when invoking browser** **Status:** Started **Created:** Sat Jun 02, 2018 06:03 PM UTC by pkx166h **Last Updated:** Sun Jun 10, 2018 03:24 PM UTC **Owner:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5335 Use covariant return types on virtual Grob::clone()

- **labels**: --> Fixed_2_21_0 - **status**: Started --> Fixed - **Patch**: push --> - **Comment**: commit 23534338bce94508ddbfbbbd4a746619eb403fd5 (HEAD -> pushed/issue-5335-grob-clone-covariance, origin/staging) Author: Dan Eble Date: Sun Jun 3 19:23:14 2018 -0400 Issue 5335/2:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5336 Expose hidden dynamic_casts in Grob_array and Grob_info

- **labels**: --> Fixed_2_21_0 - **status**: Started --> Fixed - **Patch**: push --> - **Comment**: commit aec018d7d4ed58e6d67e4621019a6cf2936b212f (HEAD -> pushed/issue-5336-grob-array-downcasting, origin/staging) Author: Dan Eble Date: Mon Jun 4 17:51:24 2018 -0400 Issue 5336:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5338 Fix out-of-sync LilyScriptEncoding / ps script defs

- **Patch**: new --> review --- ** [issues:#5338] Fix out-of-sync LilyScriptEncoding / ps script defs** **Status:** Started **Created:** Fri Jun 08, 2018 09:49 AM UTC by Knut Petersen **Last Updated:** Sun Jun 10, 2018 01:02 PM UTC **Owner:** Knut Petersen Fix out-of-sync LilyScriptEncoding

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5338 Fix out-of-sync LilyScriptEncoding / ps script defs

Passes make, make check and a full make doc. Reg test diff attached Attachments: - [5338_regtestdiff.png](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/39a197cb/73ff/attachment/5338_regtestdiff.png) (49.4 kB; image/png) --- ** [issues:#5338] Fix out-of-sync

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5335 Use covariant return types on virtual Grob::clone()

- **Patch**: countdown --> push - **Comment**: Patch counted down - please push. --- ** [issues:#5335] Use covariant return types on virtual Grob::clone()** **Status:** Started **Created:** Mon Jun 04, 2018 12:35 AM UTC by Dan Eble **Last Updated:** Thu Jun 07, 2018 03:47 PM UTC **Owner:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5337 Create Bottom contexts in a more general way

- **Patch**: review --> countdown - **Comment**: Patch on countdown for June 13th. --- ** [issues:#5337] Create Bottom contexts in a more general way** **Status:** Started **Created:** Tue Jun 05, 2018 04:59 PM UTC by Dan Eble **Last Updated:** Thu Jun 07, 2018 04:36 PM UTC **Owner:** Dan

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5340 Simplify Spacing_spanner::get_columns

- Description has changed: Diff: - **Needs**: --> - **Patch**: new --> review - **Comment**: Passes make, make check and a full make doc. --- ** [issues:#5340] Simplify Spacing_spanner::get_columns** **Status:** Started **Created:** Mon Jun 11, 2018 11:02 AM UTC by Dan

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5338 Fix out-of-sync LilyScriptEncoding / ps script defs

- Description has changed: Diff: --- old +++ new @@ -3,8 +3,7 @@ Commit 12fe78825798191ecb7e5a4ee3064679773ae1ab broke encodingdefs.ps. -This patch will not pass 'make check', but this is ok -as the current state is wrong. +This patch will pass 'make test-baseline/check', but visually

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5334 Use system* instead of system when invoking browser

- **Patch**: needs_work --> new --- ** [issues:#5334] Use system* instead of system when invoking browser** **Status:** Started **Created:** Sat Jun 02, 2018 06:03 PM UTC by pkx166h **Last Updated:** Sun Jun 10, 2018 03:20 PM UTC **Owner:** pkx166h **Attachments:** -

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5338 Fix out-of-sync LilyScriptEncoding / ps script defs

--- ** [issues:#5338] Fix out-of-sync LilyScriptEncoding / ps script defs** **Status:** Started **Created:** Fri Jun 08, 2018 09:49 AM UTC by Knut Petersen **Last Updated:** Fri Jun 08, 2018 09:49 AM UTC **Owner:** nobody Fix out-of-sync LilyScriptEncoding / ps script defs Commit

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5333 musicxml2ly: hidden timesigs and tempo marks with text.

- **Patch**: review --> countdown - **Comment**: Patch on countdown for June 10th --- ** [issues:#5333] musicxml2ly: hidden timesigs and tempo marks with text.** **Status:** Started **Created:** Fri Jun 01, 2018 11:49 AM UTC by Alex Myltsev **Last Updated:** Tue Jun 05, 2018 05:11 AM UTC

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5335 Use covariant return types on virtual Grob::clone()

- **Patch**: review --> countdown - **Comment**: Patch on countdown for June 10th --- ** [issues:#5335] Use covariant return types on virtual Grob::clone()** **Status:** Started **Created:** Mon Jun 04, 2018 12:35 AM UTC by Dan Eble **Last Updated:** Tue Jun 05, 2018 05:45 AM UTC **Owner:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5337 Create Bottom contexts in a more general way

- Description has changed: Diff: - **Needs**: --> - **Patch**: new --> review - **Comment**: Passes make, make check and and a full make doc. --- ** [issues:#5337] Create Bottom contexts in a more general way** **Status:** Started **Created:** Tue Jun 05, 2018 04:59 PM UTC

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5336 Expose hidden dynamic_casts in Grob_array and Grob_info

- **Patch**: review --> countdown - **Comment**: Patch on countdown for June 10th --- ** [issues:#5336] Expose hidden dynamic_casts in Grob_array and Grob_info** **Status:** Started **Created:** Tue Jun 05, 2018 03:03 AM UTC by Dan Eble **Last Updated:** Tue Jun 05, 2018 06:33 AM UTC

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5323 sort input files

- **Patch**: countdown --> review - **Comment**: Setting down to review - no update about the Rietveld comment - I have posted a note there too. If tihs still has no decision by next countdown I will set this patch to needs_work. --- ** [issues:#5323] sort input files** **Status:** Started

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5347 Add and use a Transform data type

- Description has changed: Diff: - **Needs**: --> - **Patch**: new --> review - **Comment**: Passes make, make check and a full make doc. --- ** [issues:#5347] Add and use a Transform data type** **Status:** Started **Created:** Sat Jun 16, 2018 09:03 AM UTC by David

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5346 Fix GC issue in skyline rotations

Sorry for reporting so late, but there's a problem with the rotation centre, see attached image: Attachments: - [issue-5346-skyline-rot.png](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/6083b388/f57c/attachment/issue-5346-skyline-rot.png) (65.1 kB; image/png) --- **

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5341 Urgent corrections to stencil-integral.cc (skylines)

- **Patch**: review --> countdown - **Comment**: Patch on countdown for June 19th. --- ** [issues:#5341] Urgent corrections to stencil-integral.cc (skylines)** **Status:** Started **Created:** Mon Jun 11, 2018 04:19 PM UTC by Torsten Hämmerle **Last Updated:** Wed Jun 13, 2018 08:52 AM UTC

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5342 lilypond-invoke-editor only should only handle textedit URIs

- **status**: Started --> Invalid - **assigned_to**: Knut Petersen --> pkx166h - **Comment**: It b was a mistake (by me) to have created this - see https://sourceforge.net/p/testlilyissues/issues/5334/ Setting invalid. --- ** [issues:#5342] lilypond-invoke-editor only should only handle

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5334 Use system* instead of system when invoking browser

- **Patch**: countdown --> push - **Comment**: Patch counted down - I'll push. --- ** [issues:#5334] Use system* instead of system when invoking browser** **Status:** Started **Created:** Sat Jun 02, 2018 06:03 PM UTC by pkx166h **Last Updated:** Wed Jun 13, 2018 02:41 PM UTC **Owner:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5343 Remove Moment::as_scheme

- **Patch**: review --> countdown - **Comment**: Patch on countdown for June 19th. --- ** [issues:#5343] Remove Moment::as_scheme** **Status:** Started **Created:** Wed Jun 13, 2018 02:12 PM UTC by David Kastrup **Last Updated:** Wed Jun 13, 2018 04:54 PM UTC **Owner:** David Kastrup

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5346 Fix GC issue in skyline rotations

- **Patch**: review --> countdown - **Comment**: Patch on countdown for June 19th. --- ** [issues:#5346] Fix GC issue in skyline rotations** **Status:** Started **Created:** Fri Jun 15, 2018 03:32 PM UTC by David Kastrup **Last Updated:** Fri Jun 15, 2018 04:32 PM UTC **Owner:** David

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5346 Fix GC issue in skyline rotations

Could you please keep tests like that not private but add them to the regtests? Particularly when you are working on that area? This could have been caught by either me or James then. I doubt I'll be able to fix this before tomorrow as I have to leave for a family celebration soonish. ---

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5347 Add and use a Transform data type

--- ** [issues:#5347] Add and use a Transform data type** **Status:** Started **Created:** Sat Jun 16, 2018 09:03 AM UTC by David Kastrup **Last Updated:** Sat Jun 16, 2018 09:03 AM UTC **Owner:** nobody Add and use a Transform data type As of now, this is just used in stencil-integral.

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5334 Use system* instead of system when invoking browser

- **labels**: --> Fixed_2_21_0 - **status**: Started --> Fixed - **Patch**: push --> - **Comment**: ~~~ author Don Armstrong Sat, 2 Jun 2018 18:56:52 +0100 (18:56 +0100) committer James Lowe Sat, 16 Jun 2018 11:05:02 +0100 (11:05 +0100) commit

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5346 Fix GC issue in skyline rotations

This wasn't private at all since I actually had added this very example to the regtests: input/regression/skyline-grob-rotation.ly It should have shown up in the standard regtest procedures, I'll check this. By the way: grob rotation (the printed stencil) uses rotate_degrees, i.e. the offset

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5340 Simplify Spacing_spanner::get_columns

- **Patch**: countdown --> push - **Comment**: Patch counted down - please push. --- ** [issues:#5340] Simplify Spacing_spanner::get_columns** **Status:** Started **Created:** Mon Jun 11, 2018 11:02 AM UTC by Dan Eble **Last Updated:** Wed Jun 13, 2018 02:42 PM UTC **Owner:** Dan Eble

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5338 Fix out-of-sync LilyScriptEncoding / ps script defs

- **Patch**: countdown --> push --- ** [issues:#5338] Fix out-of-sync LilyScriptEncoding / ps script defs** **Status:** Started **Created:** Fri Jun 08, 2018 09:49 AM UTC by Knut Petersen **Last Updated:** Sat Jun 16, 2018 08:49 AM UTC **Owner:** Knut Petersen Fix out-of-sync

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5333 musicxml2ly: hidden timesigs and tempo marks with text.

- **labels**: --> Fixed_2_21_0 - **status**: Started --> Fixed - **Patch**: push --> - **Comment**: ~~~ author Alexander Myltsev Wed, 27 Apr 2016 16:04:43 +0100 (18:04 +0300) committer James Lowe Sat, 16 Jun 2018 10:58:59 +0100 (10:58 +0100) commit

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5345 Crash with specific combination of pitch and omitted note head

- Description has changed: Diff: --- old +++ new @@ -1,3 +1,17 @@ +Issue 5345: Stop crash while merging ledger lines + +The old code (part of issue 4979) used quite broken code for merging +intervals that could crash eating all memory under certain conditions +and failed to account for

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5348 Fix bad rotation center from issue 5346

--- ** [issues:#5348] Fix bad rotation center from issue 5346** **Status:** Started **Created:** Sat Jun 16, 2018 08:39 PM UTC by David Kastrup **Last Updated:** Sat Jun 16, 2018 08:39 PM UTC **Owner:** nobody Fix bad rotation center from issue 5346 http://codereview.appspot.com/341380043

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5340 Simplify Spacing_spanner::get_columns

- **labels**: --> Fixed_2_21_0 - **status**: Started --> Fixed - **Patch**: push --> - **Comment**: commit bb34e5bbfdcf8d10877b5b85a339416f0a03c39b (HEAD -> pushed/issue-5340-used-columns-in-range, origin/staging) Author: Dan Eble Date: Mon Jun 11 06:47:48 2018 -0400 Issue 5340:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5348 Fix bad rotation center from issue 5346

`out/bin/lilypond -ddebug-skylines input/regression/skyline-grob-rotation.ly` looks fixed with this patch. I'll give it an expedited push if there is some corroboration. --- ** [issues:#5348] Fix bad rotation center from issue 5346** **Status:** Started **Created:** Sat Jun 16, 2018 08:39

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5346 Fix GC issue in skyline rotations

No problem with "fuming off", but what bothers me a bit is that these positioning differences actually do not show up in the standard regtests. I didn't expect that at all. But when using the png comparison regtests (make-regtest-png.sh), the differences will become visible - even the slight

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5348 Fix bad rotation center from issue 5346

- **labels**: --> Fixed_2_21_0 - Description has changed: Diff: - **status**: Started --> Fixed - **Needs**: --> - **Patch**: new --> - **Type**: Enhancement --> Critical - **Comment**: Pushed to staging as commit 92e15f3cbc30036c823961812f06134ab9e2893b Author: David

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5346 Fix GC issue in skyline rotations

> It should have shown up in the standard regtest procedures, I'll check this. Sorry for fuming off here: I searched for the file name of your regtest image and you named it different from the test so I thought it wasn't there and I had no time looking for it. I think the problem is that our

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5346 Fix GC issue in skyline rotations

> but what bothers me a bit is that these positioning differences actually do > not show up in the standard regtests. I didn't expect that at all. Well, me neither. Hence the fume. I needed hitting in the face with it to even start looking for an explanation. It's likely a potential problem

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5344 Avoid repeated calculation of accepted contexts

Dan, test results here: https://cloud.indie.host/s/iMYNwKodaWDxCjY --- ** [issues:#5344] Avoid repeated calculation of accepted contexts** **Status:** Started **Created:** Thu Jun 14, 2018 10:05 PM UTC by Dan Eble **Last Updated:** Sun Jun 17, 2018 08:31 PM UTC **Owner:** Dan Eble Avoid

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5345 Crash with specific combination of pitch and omitted note head

- **Patch**: new --> review - **Comment**: Passes make, make check and a full make doc. --- ** [issues:#5345] Crash with specific combination of pitch and omitted note head** **Status:** Started **Created:** Fri Jun 15, 2018 12:11 AM UTC by Simon Albrecht **Last Updated:** Mon Jun 18, 2018

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5344 Avoid repeated calculation of accepted contexts

Dan, Sorry I didn't spot this until later. I'll re-run the test and let you know. --- ** [issues:#5344] Avoid repeated calculation of accepted contexts** **Status:** Started **Created:** Thu Jun 14, 2018 10:05 PM UTC by Dan Eble **Last Updated:** Sun Jun 17, 2018 08:31 PM UTC **Owner:** Dan

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5349 Use more const Grobs in the Paper_column interface

--- ** [issues:#5349] Use more const Grobs in the Paper_column interface** **Status:** Started **Created:** Mon Jun 18, 2018 11:56 PM UTC by Dan Eble **Last Updated:** Mon Jun 18, 2018 11:56 PM UTC **Owner:** nobody Use more const Grobs in the Paper_column interface

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5350 Avoid unnecessary copying of Paper_score vectors

--- ** [issues:#5350] Avoid unnecessary copying of Paper_score vectors** **Status:** Started **Created:** Tue Jun 19, 2018 03:22 AM UTC by Dan Eble **Last Updated:** Tue Jun 19, 2018 03:22 AM UTC **Owner:** nobody Avoid unnecessary copying of Paper_score vectors

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5341 Urgent corrections to stencil-integral.cc (skylines)

- Attachments has changed: Diff: --- old +++ new @@ -0,0 +1 @@ +Reg_test_2018-06-13 09-41-41.png (20.8 kB; image/png) - **Needs**: --> - **Patch**: new --> review - **Type**: --> Enhancement - **Comment**: Passes make, make check and a full make doc - reg test diff attached

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5338 Fix out-of-sync LilyScriptEncoding / ps script defs

- **Patch**: review --> countdown - **Comment**: Patch on countdown for Jun 13. --- ** [issues:#5338] Fix out-of-sync LilyScriptEncoding / ps script defs** **Status:** Started **Created:** Fri Jun 08, 2018 09:49 AM UTC by Knut Petersen **Last Updated:** Sun Jun 10, 2018 01:02 PM UTC

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5334 Use system* instead of system when invoking browser

- **Patch**: review --> countdown - **Comment**: Knut, thanks. Do we still need https://sourceforge.net/p/testlilyissues/issues/5342/ ? (Don's) Patch on countdown for June 13. --- ** [issues:#5334] Use system* instead of system when invoking browser** **Status:** Started **Created:** Sat

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5334 Use system* instead of system when invoking browser

> Do we still need https://sourceforge.net/p/testlilyissues/issues/5342/ ? No --- ** [issues:#5334] Use system* instead of system when invoking browser** **Status:** Started **Created:** Sat Jun 02, 2018 06:03 PM UTC by pkx166h **Last Updated:** Wed Jun 13, 2018 02:41 PM UTC **Owner:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5340 Simplify Spacing_spanner::get_columns

- **Patch**: review --> countdown - **Comment**: Patch on countdown for Jun 13. --- ** [issues:#5340] Simplify Spacing_spanner::get_columns** **Status:** Started **Created:** Mon Jun 11, 2018 11:02 AM UTC by Dan Eble **Last Updated:** Tue Jun 12, 2018 11:35 AM UTC **Owner:** Dan Eble

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5337 Create Bottom contexts in a more general way

- **Patch**: countdown --> push - **Comment**: Patch counted down - please push. --- ** [issues:#5337] Create Bottom contexts in a more general way** **Status:** Started **Created:** Tue Jun 05, 2018 04:59 PM UTC by Dan Eble **Last Updated:** Sun Jun 10, 2018 03:18 PM UTC **Owner:** Dan Eble

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5343 Remove Moment::as_scheme

- Description has changed: Diff: - **Needs**: --> - **Patch**: new --> review - **Comment**: Passes make, make check and a full make doc --- ** [issues:#5343] Remove Moment::as_scheme** **Status:** Started **Created:** Wed Jun 13, 2018 02:12 PM UTC by David Kastrup **Last

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5341 Urgent corrections to stencil-integral.cc (skylines)

Rotation coding temporarily deactivated as discussed http://codereview.appspot.com/341350043 --- ** [issues:#5341] Urgent corrections to stencil-integral.cc (skylines)** **Status:** Started **Created:** Mon Jun 11, 2018 04:19 PM UTC by Torsten Hämmerle **Last Updated:** Tue Jun 12, 2018 02:30

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5345 Crash with specific combination of pitch and omitted note head

Oh wow. I did not think of bijecting, and "don't merge non-overkapping ledger lines" is a theme that might be related to omitted note heads. The pitch would require a ledger line as noted by Lukas, and its double occurence would warrant some sort of merging. This helps a lot. --- **

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5345 Crash with specific combination of pitch and omitted note head

Well, the patch contains this part: + + // When the extents of two ledgers at the same + // vertical position overlap horizontally, we merge + // them together to produce a single stencil. In rare +

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5333 musicxml2ly: hidden timesigs and tempo marks with text.

Here are the two commits reviewed above. Attachments: - [0001-musicxml2ly-support-text-bpm-tempo-marks.patch](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/15e541b4/8cc6/attachment/0001-musicxml2ly-support-text-bpm-tempo-marks.patch) (3.9 kB; application/octet-stream) -

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5345 Crash with specific combination of pitch and omitted note head

Well, I haven't started serious analysis yet, but my hunch is that an array basically containing {a, b} is iteratively changed into {a, b, a}, {a, b, a, a}, {a, b, a, a, a} or similar. Basically it is extended all the while and the iteration never finishes. --- ** [issues:#5345] Crash with

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5345 Crash with specific combination of pitch and omitted note head

- **Type**: Crash --> Critical --- ** [issues:#5345] Crash with specific combination of pitch and omitted note head** **Status:** Accepted **Created:** Fri Jun 15, 2018 12:11 AM UTC by Simon Albrecht **Last Updated:** Fri Jun 15, 2018 09:33 AM UTC **Owner:** nobody Reported by Lukas-Fabian

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5345 Crash with specific combination of pitch and omitted note head

Looks to me like a problem with a missing pure-impure-container -- checking the extent has a side effect, so you create a new layout, and off you go. But I haven't checked out the exact code. --- ** [issues:#5345] Crash with specific combination of pitch and omitted note head**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5337 Create Bottom contexts in a more general way

- **labels**: --> Fixed_2_21_0 - **status**: Started --> Fixed - **Patch**: push --> - **Comment**: commit 1c751c5c50c56b85253bba402e24dc16a725a33d (HEAD -> pushed/issue-5337-context-bottom, origin/staging) Author: Dan Eble Date: Sat May 26 07:08:09 2018 -0400 Issue 5337: Create

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5344 Avoid repeated calculation of accepted contexts

- Description has changed: Diff: --- old +++ new @@ -3,6 +3,6 @@ Encapsulate the list of accepted contexts into Acceptance_set, which is owned by both Context_def and Context. The merging of context mods that used to occur anew for every path_to_acceptable_context () call -now occurs

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5344 Avoid repeated calculation of accepted contexts

- **Patch**: new --> needs_work --- ** [issues:#5344] Avoid repeated calculation of accepted contexts** **Status:** Started **Created:** Thu Jun 14, 2018 10:05 PM UTC by Dan Eble **Last Updated:** Fri Jun 15, 2018 12:39 AM UTC **Owner:** Dan Eble Avoid repeated calculation of accepted

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5344 Avoid repeated calculation of accepted contexts

--- ** [issues:#5344] Avoid repeated calculation of accepted contexts** **Status:** Started **Created:** Thu Jun 14, 2018 10:05 PM UTC by Dan Eble **Last Updated:** Thu Jun 14, 2018 10:05 PM UTC **Owner:** nobody Avoid repeated calculation of accepted contexts Encapsulate the list of

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5345 Crash with specific combination of pitch and omitted note head

--- ** [issues:#5345] Crash with specific combination of pitch and omitted note head** **Status:** Accepted **Created:** Fri Jun 15, 2018 12:11 AM UTC by Simon Albrecht **Last Updated:** Fri Jun 15, 2018 12:11 AM UTC **Owner:** nobody Reported by Lukas-Fabian Moser [in this

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5346 Fix GC issue in skyline rotations

- Description has changed: Diff: - **Needs**: --> - **Patch**: new --> review - **Comment**: Passes make, make check and a full make doc. --- ** [issues:#5346] Fix GC issue in skyline rotations** **Status:** Started **Created:** Fri Jun 15, 2018 03:32 PM UTC by David

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5346 Fix GC issue in skyline rotations

--- ** [issues:#5346] Fix GC issue in skyline rotations** **Status:** Started **Created:** Fri Jun 15, 2018 03:32 PM UTC by David Kastrup **Last Updated:** Fri Jun 15, 2018 03:32 PM UTC **Owner:** nobody Fix GC issue in skyline rotations This was issue 5341 initially and is a fix for a

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5344 Avoid repeated calculation of accepted contexts

test that \with \denies ... has local effect http://codereview.appspot.com/346080043 --- ** [issues:#5344] Avoid repeated calculation of accepted contexts** **Status:** Started **Created:** Thu Jun 14, 2018 10:05 PM UTC by Dan Eble **Last Updated:** Sun Jun 17, 2018 05:51 PM UTC **Owner:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5344 Avoid repeated calculation of accepted contexts

Stop uniquifying \accepts; clarify copying http://codereview.appspot.com/346080043 --- ** [issues:#5344] Avoid repeated calculation of accepted contexts** **Status:** Started **Created:** Thu Jun 14, 2018 10:05 PM UTC by Dan Eble **Last Updated:** Sun Jun 17, 2018 01:06 PM UTC **Owner:** Dan

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5344 Avoid repeated calculation of accepted contexts

James, when you run `make check`, it would be interesting to know whether there are any differences in the profiling results. When I ran `make check` myself, the results showed 3 cases with a reduction in cell count above the threshold distance. I don't remake my test baseline very

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5347 Add and use a Transform data type

- **Needs**: --> - **Patch**: new --> needs_work - **Type**: --> - **Comment**: Oh for sake. This patch has the original GC problem back. I'll need another iteration. --- ** [issues:#5347] Add and use a Transform data type** **Status:** Started **Created:** Sat Jun 16, 2018

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5347 Add and use a Transform data type

Refix GC issue http://codereview.appspot.com/344970043 --- ** [issues:#5347] Add and use a Transform data type** **Status:** Started **Created:** Sat Jun 16, 2018 09:03 AM UTC by David Kastrup **Last Updated:** Sun Jun 17, 2018 12:41 PM UTC **Owner:** David Kastrup Add and use a Transform

<    3   4   5   6   7   8   9   10   11   12   >