[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5580 Replace deprecated functions from string module

Yeah, eventually a cleanup of those would be nice, and also a global policy on whether there is a space before a function call or not. But I wouldn't want to tackle this until we have migrated to Python 3, which will be difficult enough without a global reformatting... --- ** [issues:#5580]

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5580 Replace deprecated functions from string module

Yes, they do. Consistency of '' and "" with the surrounding code makes sense (maybe it would be nice to be consistent in the whole file/project, but that’s another question and would probably need a large number of changes for little benefit). I didn’t know that they are basically the same.

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5580 Replace deprecated functions from string module

Do my answers make sense, can I go forward with pushing? If you have more questions, please let me know. --- ** [issues:#5580] Replace deprecated functions from string module** **Status:** Started **Created:** Sat Oct 19, 2019 12:10 PM UTC by Jonas Hahnfeld **Last Updated:** Wed Oct 23, 2019

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5580 Replace deprecated functions from string module

I’m very late to the review party and don’t know much about python but maybe you (Jonas) could look at my questions before pushing? --- ** [issues:#5580] Replace deprecated functions from string module** **Status:** Started **Created:** Sat Oct 19, 2019 12:10 PM UTC by Jonas Hahnfeld **Last