[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

- **labels**: --> Fixed_2_21_2 - **status**: Started --> Fixed - **Patch**: push --> - **Comment**: ~~~ commit 4860434b122611df632dfd9aaa21c430e4b67819 Author: Han-Wen Nienhuys AuthorDate: Sat May 2 11:46:02 2020 +0200 Commit: Han-Wen Nienhuys CommitDate: Sat May 9 11:28:51 2020

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

- **Patch**: countdown --> push - **Comment**: Patch counted down please push - don't forget this goes on top of another patch. (needs https://codereview.appspot.com/555760043/) --- ** [issues:#3778] SVG backend: Use bounding box as skylines for markup / Compute SVG skyline based on

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

- **Patch**: review --> countdown - **Comment**: Patch on countdown for May 9th --- ** [issues:#3778] SVG backend: Use bounding box as skylines for markup / Compute SVG skyline based on original data** **Status:** Started **Created:** Sun Jan 05, 2014 05:39 AM UTC by Anonymous **Last

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

- Description has changed: Diff: --- old +++ new @@ -1,4 +1,3 @@ - https://codereview.appspot.com/545970043 (needs https://codereview.appspot.com/555760043/) - **Patch**: new --> review - **Comment**: Passes make, make check and a full make doc. --- ** [issues:#3778] SVG

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

- **summary**: SVG backend: Use bounding box as skylines for markup --> SVG backend: Use bounding box as skylines for markup / Compute SVG skyline based on original data - Description has changed: Diff: --- old +++ new @@ -1,4 +1,14 @@ -https://codereview.appspot.com/582010043 +

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

- **Needs**: --> - **Patch**: new --> review - **Type**: --> - **Comment**: Patch for https://codereview.appspot.com/545970043 does not apply What I am not clear on here is does Hanwen's patch replace the one that was made by Kevin? and if not what am I to do with kevin's patch that was

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

Compute SVG skyline based on original data Since stencil data is used as input to formatting decisions, this will make SVG output more similar to PS/PDF output. https://codereview.appspot.com/545970043 --- ** [issues:#3778] SVG backend: Use bounding box as skylines for markup** **Status:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

- **Patch**: countdown --> review - **Comment**: Seems that Hanwen wants some more discussion on this (see Rietveld) setting back to review. --- ** [issues:#3778] SVG backend: Use bounding box as skylines for markup** **Status:** Started **Created:** Sun Jan 05, 2014 05:39 AM UTC by

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

- **Patch**: review --> countdown - **Comment**: Patch on countdown for May 4th --- ** [issues:#3778] SVG backend: Use bounding box as skylines for markup** **Status:** Started **Created:** Sun Jan 05, 2014 05:39 AM UTC by Anonymous **Last Updated:** Wed Apr 29, 2020 09:20 AM UTC **Owner:**

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

- **Needs**: --> - **Patch**: new --> review - **Type**: --> - **Comment**: Passes Make, make check and a full make doc --- ** [issues:#3778] SVG backend: Use bounding box as skylines for markup** **Status:** Started **Created:** Sun Jan 05, 2014 05:39 AM UTC by Anonymous **Last

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

Remove regression test https://codereview.appspot.com/582010043 --- ** [issues:#3778] SVG backend: Use bounding box as skylines for markup** **Status:** Started **Created:** Sun Jan 05, 2014 05:39 AM UTC by Anonymous **Last Updated:** Wed Apr 29, 2020 08:19 AM UTC **Owner:** Kevin Barry

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

- **Patch**: new --> needs_work - **Comment**: This fails make check The error I get is ~~~ ... Reading out-test/collated-files.tely... Running texi2pdf on file /tmp/tmpdvht1kgb.texi to detect default page settings. Dissecting... Writing snippets... Processing... Processing

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

- **summary**: SVG backend: error in text skylining --> SVG backend: Use bounding box as skylines for markup - Description has changed: Diff: --- old +++ new @@ -1,6 +1,28 @@ -*Originally created by:* *anonymous +https://codereview.appspot.com/582010043 -*Originally created by:*

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

Issue 3778: Use bounding box as skylines for markup in svg backend As there is no routine for determining skylines for utf-8-string stencils, they normally fall back to the grob's bounding box, which is fine. However, when there is a mixture of utf-8-string and other types of stencil (which have