Re: [PATCH v2] Fix crash when a stencil routine is missing

2009-07-07 Thread Werner LEMBERG
The new option, -dwarning-as-error, does *not* turn every warning into an error. It only turns specific warnings (that don't exist without this patch) into errors. Then the name is indeed too generic and should be temporarily renamed to something more specific until the code has been

Re: First release of ly/tablature.ly

2009-07-07 Thread Marc Hohl
Joe Neeman schrieb: On Tue, 2009-06-23 at 12:53 -0600, Carl D. Sorensen wrote: http://codereview.appspot.com/67174/diff/1/2#newcode237 Line 237: \layout { It seems to me that we have 3 versions of tablature now: the default version in engraver-init.ly, the version that appears if the user

build numbers in GUB

2009-07-07 Thread Graham Percival
Hi Patrick-the-incredible-helper, When you build something in GUB, what build number (2.13.3-x) do you get? I always get -0, even when I build a new package without changing the version number. I suspect that this causes slight breakage in certain scripts. (this is a relatively low-priority

Re: [PATCH v2] Fix crash when a stencil routine is missing

2009-07-07 Thread Patrick McCarty
On Tue, Jul 07, 2009 at 08:16:45AM +0200, Werner LEMBERG wrote: The new option, -dwarning-as-error, does *not* turn every warning into an error. It only turns specific warnings (that don't exist without this patch) into errors. Then the name is indeed too generic and should be

Re: build numbers in GUB

2009-07-07 Thread Jan Nieuwenhuizen
On di, 2009-07-07 at 01:16 -0700, Patrick McCarty wrote: On Tue, Jul 07, 2009 at 01:01:22AM -0700, Graham Percival wrote: Hi Patrick-the-incredible-helper, When you build something in GUB, what build number (2.13.3-x) do you get? I always get -0, even when I build a new package without

Re: First release of ly/tablature.ly

2009-07-07 Thread Carl D. Sorensen
On 7/7/09 1:56 AM, Marc Hohl m...@hohlart.de wrote: Joe Neeman schrieb: On Tue, 2009-06-23 at 12:53 -0600, Carl D. Sorensen wrote: http://codereview.appspot.com/67174/diff/1/2#newcode237 Line 237: \layout { It seems to me that we have 3 versions of tablature now: the default version

Re: build numbers in GUB

2009-07-07 Thread Han-Wen Nienhuys
On Tue, Jul 7, 2009 at 5:16 AM, Patrick McCartypnor...@gmail.com wrote: On Tue, Jul 07, 2009 at 01:01:22AM -0700, Graham Percival wrote: When you build something in GUB, what build number (2.13.3-x) do you get?  I always get -0, even when I build a new package without changing the version

Re: [PATCH v2] Fix crash when a stencil routine is missing

2009-07-07 Thread Joe Neeman
On Tue, 2009-07-07 at 01:24 -0700, Patrick McCarty wrote: On Tue, Jul 07, 2009 at 08:16:45AM +0200, Werner LEMBERG wrote: The new option, -dwarning-as-error, does *not* turn every warning into an error. It only turns specific warnings (that don't exist without this patch) into

Re: First release of ly/tablature.ly

2009-07-07 Thread Marc Hohl
[...] I don't particularly mind breaking existing scores (as long as there is a convert-ly rule to at least warn about the problem), but I don't think the situation in the patch is particularly friendly. We've a long tradition of choosing sensible behaviour over backwards compatibility and I see

Re: First release of ly/tablature.ly

2009-07-07 Thread Carl D. Sorensen
On 7/7/09 12:20 PM, Marc Hohl m...@hohlart.de wrote: [...] I don't particularly mind breaking existing scores (as long as there is a convert-ly rule to at least warn about the problem), but I don't think the situation in the patch is particularly friendly. We've a long tradition of

Improvements for the SVG backend

2009-07-07 Thread joeneeman
http://codereview.appspot.com/91075/diff/1/3 File scm/output-svg.scm (right): http://codereview.appspot.com/91075/diff/1/3#newcode140 Line 140: (match:substring match 1))) Why not just (set-attribute 'font-weight bold)? Similarly below. http://codereview.appspot.com/91075/diff/1/3#newcode155

Re: Improvements for the SVG backend

2009-07-07 Thread pnorcks
On 2009/07/07 21:10:54, Patrick McCarty wrote: http://codereview.appspot.com/91075/diff/1/3#newcode155 Line 155: (set! alist (reverse alist)) You can use reverse! here Oddly, this did not work. I tried (reverse! alist) (apply entity 'text expr alist))) Never mind. Patch Set 3

[PATCH v3] Fix crash when a stencil routine is missing

2009-07-07 Thread Patrick McCarty
Hello, The third revision of my patch set (Patch Set 5) is on Rietveld: http://codereview.appspot.com/83046/show The change from Patch Set 4 is the generalization of -dwarning-as-error. Note that this is a series of 8 commits that contain more in-depth commit summaries. They can be found

Re: GUB question about removing packages

2009-07-07 Thread Patrick McCarty
On Mon, Jul 6, 2009 at 1:26 AM, Jan Nieuwenhuizenjanneke-l...@xs4all.nl wrote: I have just been removing the package files manually, but there is probably a better (but undocumented) way to do this. Try bin/gpkg --help :-) Okay, thanks Jan. :-) This doesn't achieve what I was hoping for

Frescobaldi editor

2009-07-07 Thread Maximilian Albert
Hi, has anyone tried the Frescobaldi editor for Lilypond? http://www.frescobaldi.org/ I've only had time to play with it for 5 minutes so far but it looks like an extremely easy to use and quit feature-rich editor which is specifically taylored to editing Lilypond files in a simple way.

Patch: Delete intermediate ps files

2009-07-07 Thread Maximilian Albert
Hi, am I missing something or is the only thing that is needed to solve the first part of issue #685 (see http://code.google.com/p/lilypond/issues/detail?id=685 ) a one-line change as in the attached patch? As for the second part, are log files still created by default? This doesn't seem to be