[PATCH] Re: Bass figure extenders' length depends on length of bass figure

2010-11-24 Thread Reinhold Kainhofer
Am Mittwoch, 24. November 2010, um 16:33:13 schrieb Reinhold Kainhofer: If you use bass figure extenders and you print the accidental after the figure, the extender of those figures will be too long compared to the other figures. In particular, if you have 6 5+ 3 6 5+ 3 then the extender

FiguredBass: Extenders for figures of different width should still stop at the same position (issue3280042)

2010-11-24 Thread Carl . D . Sorensen
LGTM. Carl http://codereview.appspot.com/3280042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: 2.13.40 regtests

2010-11-24 Thread Neil Puttock
On 24 November 2010 15:47, Phil Holmes m...@philholmes.net wrote: So if a completely new bit of graphics appears, the regtest checker wouldn't spot it?  Not sure that's too good. It might not, depending on whether the new grob influences bounding boxes for other grobs. What's the checker

Re: FiguredBass: Extenders for figures of different width should still stop at the same position (issue3280042)

2010-11-24 Thread n . puttock
LGTM. http://codereview.appspot.com/3280042/diff/1/lily/figured-bass-engraver.cc File lily/figured-bass-engraver.cc (right): http://codereview.appspot.com/3280042/diff/1/lily/figured-bass-engraver.cc#newcode467 lily/figured-bass-engraver.cc:467: group.figure_item_-set_property (text,

New Greek PO file for 'lilypond' (version 2.13.7)

2010-11-24 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'lilypond' has been submitted by the Greek team of translators. The file is available at: http://translationproject.org/latest/lilypond/el.po (We can arrange things so that

Line breaks in @file{} entries?

2010-11-24 Thread Mark Polesky
Valentin, I'm a little puzzled by your recent patch 1b832d7 Doc: clean up @file{} entries. In the commit description, you say you're escaping such characters as `.', `/' or `-'. But the only thing I see in the diff are some 900 additions of @/ which is the texinfo command to allow line

[PATCH] Delay part-combine texts until a real note is encountered

2010-11-24 Thread Reinhold Kainhofer
In the part-combiner, if one voice has a full-bar rest and the other voice has some rests and then sets in with a solo during the measure, the part-combined result is terribly broken (by design), so one has to override the part- combiner to start the Solo at the beginning of the measure. In real

Re: [Patch:] Tablature: provide custom fret labels

2010-11-24 Thread Neil Puttock
On 24 November 2010 07:40, Marc Hohl m...@hohlart.de wrote: I attached a patch to remove the unnecessary markup definition. Thanks, applied. Cheers, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org

[PATCH] Fix #1427 (segfault with \markup inside \book(part) identifier)

2010-11-24 Thread Neil Puttock
Hi everybody, Please review this patch: http://codereview.appspot.com/3319041 Thanks, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [Patch] Add support for tempo ranges (issue3248042)

2010-11-24 Thread n . puttock
On 2010/11/24 01:16:46, Carl wrote: I think this number-or-pair? would be sufficient for this case. It's certainly as specific as a list? or cheap-list? check. That sounds OK to me. Cheers, Neil http://codereview.appspot.com/3248042/ ___

Fix #1427. (issue3319041)

2010-11-24 Thread reinhold . kainhofer
I can't comment on the code itself (from a first look it makes sense, but I haven't dug too deep). What is missing, though, is a regtest... http://codereview.appspot.com/3319041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Fix #1427. (issue3319041)

2010-11-24 Thread n . puttock
Reviewers: Reinhold, Message: On 2010/11/25 00:16:22, Reinhold wrote: I can't comment on the code itself (from a first look it makes sense, but I haven't dug too deep). What is missing, though, is a regtest... I've held off doing a regtest until somebody can confirm this is the right course

Re: Fix #1427. (issue3319041)

2010-11-24 Thread n . puttock
On 2010/11/25 00:21:21, Neil Puttock wrote: I've held off doing a regtest until somebody can confirm this is the right course of action, though if you insist... :) OK, regtest's on hold while I work out why the following doesn't work: mypart = \bookpart { \relative c' { c1 } } \book {

Modify fret calculation algorithm (issue3320041)

2010-11-24 Thread Carl . D . Sorensen
Reviewers: steve yegge steve.yegge_gmail.com, patrick schmidt p.l.schmidt_gmx.de, Message: Here's a patch to the fret calculator that answers the first two of Steve's requests, I think. http://article.gmane.org/gmane.comp.gnu.lilypond.general/60177 It turns a -0 fingering into an open string