Hi, I'm (attempting to) packaging the development lilypond for openSUSE
and I'm having difficulty with building the info documentation with
images. Jan added the parts to the spec file to do this quite a while
ago and now I can't seem to find lilypond/html/input/lsr and
2010/12/27 Trevor Daniels t.dani...@treda.co.uk
If you want to use normal spacing simply revert this setting:
\revert Score.SpacingSpanner #'packed-spacing
Thanks for this!
I know next to nothing about ancient notation, but whoever wrote
gregorian.ly clearly intended this behaviour as the
Janek Warchoł wrote Tuesday, December 28, 2010 3:28 PM
2010/12/27 Trevor Daniels t.dani...@treda.co.uk
I know next to nothing about ancient notation, but whoever wrote
gregorian.ly clearly intended this behaviour as the file contains
the override
\override SpacingSpanner #'packed-spacing =
Hello,
From: bug-lilypond-bounces+james.lowe=datacore@gnu.org
[bug-lilypond-bounces+james.lowe=datacore@gnu.org] on behalf of Trevor
Daniels [t.dani...@treda.co.uk]
Sent: 28 December 2010 16:37
To: Janek Warchoł
Cc: lilypond-devel@gnu.org; Lilypond
2010/12/27 Han-Wen Nienhuys hanw...@gmail.com
Why don't you try to find some scans of reputable editions to see what
the standard behavior is in this case?
Because i believe the situation is quite different.
Would it be feasible for an engraver to have different flags for many
different stem
On Tue, Dec 28, 2010 at 05:12:56PM +0200, Dave Plater wrote:
lilypond/html/input/lsr and
lilypond/html/Documentation/user
...
Am I doing something wrong and something isn't building or has something
changed that I don't know about?
Yes; those directories were removed 1-2 years ago. I
http://codereview.appspot.com/2726043/diff/1/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
http://codereview.appspot.com/2726043/diff/1/ly/music-functions-init.ly#newcode250
ly/music-functions-init.ly:250: 'origin location))
On 2010/11/25 22:50:40, Neil Puttock wrote:
Please review:
http://codereview.appspot.com/3838042/
Tie break-visibility of OctavateEight to the one of the associated clef
It does not make sense to handle break-visibility of OctavateEight
grobs independently from the clef they are assigned to.
This patch lets
I have now uploaded a final patch for cue notes with custom clef, which I think
is in a state so that it can be included in lilypond master:
http://codereview.appspot.com/2726043/
Any further objectsions/suggestions? Or can I push to master?
I have included almost all comments so far, except
Hi Reinhold,
I'd prefer a callback to copy the Clef's setting, then it's documented
automatically (and can be changed if absolutely necessary).
Cheers,
Neil
http://codereview.appspot.com/3838042/
___
lilypond-devel mailing list
On 12/28/10 12:28 PM, Janek Warchoł lemniskata.bernoull...@gmail.com
wrote:
2010/12/27 Han-Wen Nienhuys hanw...@gmail.com
Why don't you try to find some scans of reputable editions to see what
the standard behavior is in this case?
Because i believe the situation is quite different.
Would
Reviewers: Neil Puttock,
Message:
On 2010/12/28 22:06:43, Neil Puttock wrote:
I'd prefer a callback to copy the Clef's setting, then it's documented
automatically (and can be changed if absolutely necessary).
Hmm, I can't really think of a situation where you want to show or hide
the
On Tue, Dec 28, 2010 at 01:24:32PM -, Phil Holmes wrote:
- Original Message - From: Graham Percival
Ironically, although the current printed policy seems to be too
inclusive for Critical issues, my main concern is that bug squad
members are classifying stuff as High instead of
Hi Reinhold,
You're missing definitions for explicitCueClefVisibility and
quoted-music-clef.
Cheers,
Neil
http://codereview.appspot.com/2726043/diff/21001/Documentation/changes.tely
File Documentation/changes.tely (right):
On 2010/12/28 20:26:54, Reinhold wrote:
Okay, I just copied this from cueDuring. I notice that lots of
definitions in
music-functions-init.ly contain 'origin location. So, can we remove it
from all
those definitions without breaking anything?
It should be safe to remove 'origin from all
Okay, new patch uploaded, which uses a callback to inherit the
OctavateEight's break-visibility from the parent clef. This has the
advantage that one can still override the visibility independent from
the clef (although I don't think there is a real-life use for that)
Okay to push?
On 2010/12/28 23:02:25, Reinhold wrote:
Hmm, I can't really think of a situation where you want to show or
hide the
octavation eight independently of the associated clef
Neither can I. :)
(actually, I never
understood why it was a separate grob in the first place).
It makes it easier
On 2010/12/28 23:43:46, Reinhold wrote:
Okay, new patch uploaded, which uses a callback to inherit the
OctavateEight's
break-visibility from the parent clef. This has the advantage that one
can still
override the visibility independent from the clef (although I don't
think there
is a
On 2010/12/29 00:01:45, Neil Puttock wrote:
Looks OK, though it would be simpler to define the callback in
output-lib.scm.
I had the same idea, so that patch is already uploaded ;-) This has the
advantage that it might also be used for other grobs
http://codereview.appspot.com/3838042/
Thanks, Neil, for all your comments (and indent nitpicks ;) ).
I have included/fixed all of them (and some other minor issues) and
posted the patch again (needs my other patch for the OctavateEight
break-visibility to get octavated cue clefs right). Any further
comments?
Cheers,
Reinhold
LGTM.
http://codereview.appspot.com/3838042/diff/2002/scm/output-lib.scm
File scm/output-lib.scm (right):
http://codereview.appspot.com/3838042/diff/2002/scm/output-lib.scm#newcode238
scm/output-lib.scm:238: (let ((parent (ly:grob-parent grob 0)))
(ly:grob-parent grob X)
LGTM.
http://codereview.appspot.com/2726043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2010/12/28 23:32:18, Neil Puttock wrote:
On 2010/12/28 20:26:54, Reinhold wrote:
Okay, I just copied this from cueDuring. I notice that lots of
definitions in
music-functions-init.ly contain 'origin location. So, can we remove
it from
all
those definitions without breaking anything?
On 2010/12/29 02:25:44, Keith wrote:
I'm not a programmer, but accustomed to doing code review as a systems
engineer.
I very much appreciate the review. Thanks!
Change stringTunings entries from semitones to pitches
This lays the foundation for creating a TabKey grob
Presumably the
Thanks again for the review. Here are my responses to your comments.
Thanks,
Carl
http://codereview.appspot.com/3842041/diff/6001/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
On 12/28/10 4:18 PM, Graham Percival gra...@percival-music.ca wrote:
On Tue, Dec 28, 2010 at 01:24:32PM -, Phil Holmes wrote:
- Original Message - From: Graham Percival
I think one of these was mine. This is the thing I want to discuss
before creating a patch. I think the
Everything I know how to check looks good.
http://codereview.appspot.com/3842041/diff/6001/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
27 matches
Mail list logo
