Pushed as two commits, one to revert the earlier fix:
76490755dae238028e919653057f231b25be3445
and one to apply the new fix
2aa1d6f450a7f051aa4b0ddcaf89593f7ff23a60
http://codereview.appspot.com/4313047/
___
lilypond-devel mailing list
On Apr 8, 2011, at 5:27 PM, n.putt...@gmail.com wrote:
LGTM, just needs a regtest.
http://codereview.appspot.com/4384046/diff/5001/lily/page-spacing.cc
File lily/page-spacing.cc (right):
http://codereview.appspot.com/4384046/diff/5001/lily/page-spacing.cc#newcode88
Not sure why, but the doc page CG 12.5 Website build
is broken on kainhofer.com:
http://kainhofer.com/~lilypond/Documentation/contributor/website-build.html
- Mark
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Third Draft.
Regards
http://codereview.appspot.com/4388041/diff/4001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/4388041/diff/4001/Documentation/notation/rhythms.itely#newcode3240
- Original Message -
From: Mark Polesky markpole...@yahoo.com
To: lilypond-devel lilypond-devel@gnu.org
Sent: Saturday, April 09, 2011 4:46 PM
Subject: broken page on kainhofer
Not sure why, but the doc page CG 12.5 Website build
is broken on kainhofer.com:
4th Draft posted.
Still to do:
Showing how 'breakbefore' works, as it was evident from recent mails
that I need to go back and read the LM to see how to show this in an
@lilypond.
Also the last third of this patch still needs to be 'done' - we've left
this until we get the first parts sorted.
Thanks again to everyone here for helping to finish what I
started. I'll leave the style/content issues to the rest of
you; the comments below are just nitpicks.
- Mark
http://codereview.appspot.com/4124056/diff/18001/Documentation/notation/input.itely
File Documentation/notation/input.itely
LGTM
http://codereview.appspot.com/4388041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: ,
Message:
Small patch that takes new grobs in account :
Accidental suggestions, dynamics, ligatures and spanned trills.
Regards,
Bertrand
Description:
Add some polyphonically directed grobs
Accidental suggestions, dynamics, ligatures and spanned trills added to
LGTM.
Carl
http://codereview.appspot.com/4387046/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: ,
Message:
A few nitpicks.
Description:
Autobeam nitpicks (following Carl's fix).
Please review this at http://codereview.appspot.com/4385050/
Affected files:
M scm/time-signature-settings.scm
Index: scm/time-signature-settings.scm
diff --git a/scm/time-signature-settings.scm
LGTM
Carl
http://codereview.appspot.com/4385050/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/04/10 02:47:42, Carl wrote:
LGTM
Carl
If you have push access, go ahead and push. If not, send it to me and
I'll push it.
No further review is necessary.
Thanks,
Carl
http://codereview.appspot.com/4385050/
___
lilypond-devel
On 11-04-09 07:57 PM, bordage.bertr...@gmail.com wrote:
Reviewers: ,
Message:
Small patch that takes new grobs in account :
Accidental suggestions, dynamics, ligatures and spanned trills.
Regards,
Bertrand
Description:
Add some polyphonically directed grobs
Accidental suggestions, dynamics,
Yes, I noticed the same changes. That's exactly what I expected.
Thanks,
Bertrand
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/4124056/diff/18001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/4124056/diff/18001/Documentation/notation/input.itely#newcode548
Documentation/notation/input.itely:548:
On Sat, Apr 09, 2011 at 07:28:00AM +0200, David Kastrup wrote:
How do I notice that somebody fixed the bug by accident if I am not
allowed to add a check for the bug to the regtests?
Am I supposed to keep a _private_ regtest for bugs I report, checking it
periodically to make sure that the
LGTM
http://codereview.appspot.com/4384050/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Tuesday, 07:00
Add some polyphonically directed grobs
http://codereview.appspot.com/4387046/
Issue 1471: Invalidate alterations upon key change rather than forgetting them.
http://codereview.appspot.com/4384050
Cheers,
- Graham
___
lilypond-devel
19 matches
Mail list logo