Ok, I worked hard on this and did a brand new patch :
http://codereview.appspot.com/4536068/
http://codereview.appspot.com/4543055/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
This looks generally good to me.
I'm concerned about the name duration-log-list. I've commented more
on it below.
Thanks,
Carl
http://codereview.appspot.com/4536068/diff/1/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):
Reviewers: ,
Message:
Just one regtest change :
in multi-measure-rest.ly, the two longas of the third measure are
tranformed into a maxima (as expected).
Regards,
Bertrand
Description:
Adds longas, maximas and non-standard tweaks to MultiMeasureRest
Please review this at
This name is nice and generic, which is good. Bit it has no
information content
as far as I can see. Can we make it more explicit by changing either
the name
(to something like usable-duration-logs) or the description (to
something like
List of duration-logs that can be used in
http://codereview.appspot.com/4536068/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (right):
http://codereview.appspot.com/4536068/diff/1/scm/define-grobs.scm#newcode1305
scm/define-grobs.scm:1305: (duration-log-list . (0 -1 -2 -3))
On 2011/05/18 13:54:43, Bertrand Bordage wrote:
Just
I applied it to the more recent git HEAD without any problem.
By maxima, I mean the glyph rests.M3.
I chose to use maximas because they are easier to read than two longas
with many space in between.
In such cases, this is mandatory :
{ \compressFullBarRests \time 4/1 R\longa*10 }
Sorry, I misread your first sentence. Forget the first line of my
previous post.
http://codereview.appspot.com/4536068/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
