Re: MIDI: intelligently combine overlapping notes. (issue4520050)

2011-05-25 Thread k-ohara5a5a
I have been successfully testing this patch for http://code.google.com/p/lilypond/issues/detail?id=1647 and want to push it within a couple of days. Now is a good time to review (even though Michael Duggan wrote the core of this patch seven years ago) because it gets us thinking about how to

Re: Pure properties

2011-05-25 Thread m...@apollinemike.com
That does help - thank you! ~Mike On May 25, 2011, at 5:28 AM, Benjamin Peterson wrote: mike at apollinemike.com mike at apollinemike.com writes: Hey all, I think I've asked this question before, but I can't find the response - sorry if I'm repeating myself! Could someone please

Re: Images broken in web-big-page.html

2011-05-25 Thread Phil Holmes
- Original Message - From: Reinhold Kainhofer reinh...@kainhofer.com To: Lilypond-devel@gnu.org Sent: Monday, May 23, 2011 7:59 PM Subject: Images broken in web-big-page.html The web-big-page.html (found at http://kainhofer.com/~lilypond/Documentation/web-big-page.html ) has all its

Re: MIDI: intelligently combine overlapping notes. (issue4520050)

2011-05-25 Thread percival . music . ca
LGTM http://codereview.appspot.com/4520050/diff/16001/input/regression/midi-unisons.ly File input/regression/midi-unisons.ly (right): http://codereview.appspot.com/4520050/diff/16001/input/regression/midi-unisons.ly#newcode6 input/regression/midi-unisons.ly:6: @code{timidity -idvvv file.midi

Re: Loose-lines honor padding between systems (issue4553060)

2011-05-25 Thread Carl . D . Sorensen
IIRC, part of the motivation for the new spacing algorithm was the desire to put staves in fixed positions on the page, regardless of what else was around. Does this patch eliminate this possibility? If so, is it possible to disable it? I guess by setting padding to 0?

stable/2.14 lacking predefined-mandolin-fretboards.ly

2011-05-25 Thread Graham Percival
Hi Carl, Attempting make doc in stable/2.14 dies with this: /main/src/lilypond/build/out/lybook-db/3c/lily-095253df.ly:1198:9: error: cannot find file: `predefined-mandolin-fretboards.ly' Could you cherry-pick whatever commit(s) dealt with this? Cheers, - Graham

Re: Branches?

2011-05-25 Thread Graham Percival
On Mon, May 23, 2011 at 08:02:57AM -0600, Carl Sorensen wrote: I don't think anything is officially happening with release/unstable and release/2.14 To clarify, there is no such thing as release/2.14. We currently have: - master: everybody should be using this. - lilypond/translations:

Re: Pure properties

2011-05-25 Thread Joe Neeman
On Wed, May 25, 2011 at 1:05 AM, m...@apollinemike.com m...@apollinemike.com wrote: On May 24, 2011, at 11:08 AM, Joe Neeman wrote: A pure callback is one that has no side-effects. In define-grobs.scm, you will find a list of pure callbacks, along with an associative list that allows you to

Re: Making website build almost completely quiet (issue4515042)

2011-05-25 Thread percival . music . ca
LGTM http://codereview.appspot.com/4515042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Making website build almost completely quiet (issue4515042)

2011-05-25 Thread Phil Holmes
- Original Message - From: percival.music...@gmail.com To: philehol...@googlemail.com; m...@philholmes.net Cc: lilypond-devel@gnu.org; re...@codereview.appspotmail.com Sent: Wednesday, May 25, 2011 4:50 PM Subject: Re: Making website build almost completely quiet (issue4515042) LGTM

Re: Making website build almost completely quiet (issue4515042)

2011-05-25 Thread Graham Percival
On Wed, May 25, 2011 at 05:02:42PM +0100, Phil Holmes wrote: Could you push, please? Sure, please do git format-origin patch (I think -- it's been a while! actual command is in the CG) and send me the file. Cheers, - Graham ___ lilypond-devel

Re: stable/2.14 lacking predefined-mandolin-fretboards.ly

2011-05-25 Thread Carl Sorensen
On 5/25/11 9:01 AM, James Lowe james.l...@datacore.com wrote: Carl et al )-Original Message- )From: lilypond-devel-bounces+james.lowe=datacore@gnu.org )[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On )Behalf Of Graham Percival )Sent: 25 May 2011 11:55 )To:

Re: Loose-lines honor padding between systems (issue4553060)

2011-05-25 Thread k-ohara5a5a
On 2011/05/25 13:43:55, Carl wrote: IIRC, part of the motivation for the new spacing algorithm was the desire to put staves in fixed positions on the page, regardless of what else was around. Does this patch eliminate this possibility? No. This patch merely includes a spring component,

Re: Loose-lines honor padding between systems (issue4553060)

2011-05-25 Thread Carl . D . Sorensen
On 2011/05/25 18:08:59, Keith wrote: On 2011/05/25 13:43:55, Carl wrote: IIRC, part of the motivation for the new spacing algorithm was the desire to put staves in fixed positions on the page, regardless of what else was around. Does this patch eliminate this possibility? No.

Re: stable/2.14 lacking predefined-mandolin-fretboards.ly

2011-05-25 Thread Keith OHara
Carl Sorensen c_sorensen at byu.edu writes: Pushed, along with some other patches I wanted to cherry-pick. Should be ready for a release now, I think. Not quite. The commit Fix determine-frets so that it preserves note order causes regression test tablature-negative-fret.ly to fails with

Re: Fix determine-frets so that it preserves note order (issue4518045)

2011-05-25 Thread k-ohara5a5a
http://codereview.appspot.com/4518045/diff/1/scm/translation-functions.scm File scm/translation-functions.scm (right): http://codereview.appspot.com/4518045/diff/1/scm/translation-functions.scm#newcode351 scm/translation-functions.scm:351: (note-pitch note) string)) (car

Re: Fix determine-frets so that it preserves note order (issue4518045)

2011-05-25 Thread Carl . D . Sorensen
On 2011/05/26 03:26:32, Keith wrote: `make check` was crashing on an unbound variable 'note'. Given line 345 above the fix was so obvious that I just pushed it. Thanks for the fix. I had found that fix as well, and was getting ready to push it. But there's still another problem. Right

Re: stable/2.14 lacking predefined-mandolin-fretboards.ly

2011-05-25 Thread Carl Sorensen
On 5/25/11 1:36 PM, Keith OHara k-ohara5...@oco.net wrote: Carl Sorensen c_sorensen at byu.edu writes: Pushed, along with some other patches I wanted to cherry-pick. Should be ready for a release now, I think. Not quite. The commit Fix determine-frets so that it preserves note

Re: Branches?

2011-05-25 Thread Werner LEMBERG
Currently unused: - release/unstable: unused, and in any case it's Graham-only. What about renaming this accordingly? Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel