On 2011/05/28 16:13:43, benko.pal wrote:
aargh, that's not too readable.
what I actually suggest is replacing lines 204-207 of
http://codereview.appspot.com/4490045/diff/12001/lily/completion-note-heads-engraver.cc
File lily/completion-note-heads-engraver.cc (right):
204 if
http://codereview.appspot.com/4490045/diff/12001/lily/completion-note-heads-engraver.cc
File lily/completion-note-heads-engraver.cc (right):
http://codereview.appspot.com/4490045/diff/12001/lily/completion-note-heads-engraver.cc#newcode207
lily/completion-note-heads-engraver.cc:207:
New patches from Karin uploaded.
I've got a warning while applying patch 0003 (about autosplit-remainder)
to my repository, but it looks like its not fatal... I don't understand
what it means, can anyone more experienced take a look and say whether
there is anything to worry about?
aargh, that's not too readable.
what I actually suggest is replacing lines 204-207 of
http://codereview.appspot.com/4490045/diff/12001/lily/completion-note-heads-engraver.cc
File lily/completion-note-heads-engraver.cc (right):
204 if ((left_to_do_ - note_dur.get_length ()) Rational (0))
On 2011/05/29 08:53:30, benko.pal wrote:
I must miss something, to me it's still a boolean.
and (still to me) it's not an inline conditional, but
an assignment of a boolean expression to a boolean
variable.
No, it is I that missed something. I'm sorry for the noise.
Thanks,
Carl
http://codereview.appspot.com/4490045/diff/12001/lily/completion-note-heads-engraver.cc
File lily/completion-note-heads-engraver.cc (right):
http://codereview.appspot.com/4490045/diff/12001/lily/completion-note-heads-engraver.cc#newcode207
lily/completion-note-heads-engraver.cc:207:
2011/5/28 carl.d.soren...@gmail.com:
On 2011/05/28 16:13:43, benko.pal wrote:
aargh, that's not too readable.
what I actually suggest is replacing lines 204-207 of
http://codereview.appspot.com/4490045/diff/12001/lily/completion-note-heads-engraver.cc
File
On 2011/05/29 12:14:18, Carl wrote:
On 2011/05/29 08:53:30, benko.pal wrote:
I must miss something, to me it's still a boolean.
and (still to me) it's not an inline conditional, but
an assignment of a boolean expression to a boolean
variable.
I just used inline conditionals as an example
karin.hoeth...@googlemail.com writes:
I just used inline conditionals as an example of a code style where
conditions are inlined. More generally, there seem to be two views on
readability:
One could be summarized as Don't do more than one thing in one line
(for example inline conditions
[I'm CCing the FreeType and lilypond devel lists since this is a
problem which has not been reported to FreeType, and which has caused
problems with PS files created by lilypond.]
Peter,
the font `verdana.ttf' version 5.03 (shipped with Windows 7, I
believe) contains the following two
Werner LEMBERG writes:
the font `verdana.ttf' version 5.03 (shipped with Windows 7, I
believe)
We found it in several installations of Windows_7 SP1, not [yet]
on a plain Windows_7 installation.
Jan.
--
Jan Nieuwenhuizen jann...@gnu.org | GNU LilyPond http://lilypond.org
Freelance IT
On 2011/05/28 19:40:26, Graham Percival wrote:
Could we get that example as a regtest?
The regtest comparison shows some warnings in rest-polyphonic2.ly in a
different
place. I don't know if that's significant. Nothing else changed.
I ran the regtests and they look squeaky clean. Lemme
On Sun, May 29, 2011 at 08:27:20PM +, k-ohara5...@oco.net wrote:
Reviewers: Graham Percival,
Message:
On 2011/05/28 19:16:34, Graham Percival wrote:
input/regression/midi/key-initial.ly:2: \version 2.13.53
should this version number be increased? Did we have
midiChannelMapping in
On Sun, May 29, 2011 at 08:09:53PM +0200, Jan Nieuwenhuizen wrote:
In trying to nail down the notorious #1562, I started a ghostscript-9.0
branch in GUB, which uses ghostscript 9.02, freetype-2.4.4 and includes
a small ghostscript installer fixlet.
It would be nice if you could find a time
This fails the sniff test because it removes some careful-looking code
no explanation as to how the job of the old code is being done.
What happens if the line on the next page is does not, in fact, have the
same vertical reference point?
\relative c''' { \override Staff . Glissando #'breakable
On 5/29/11 3:48 PM, Graham Percival gra...@percival-music.ca wrote:
On Sun, May 29, 2011 at 08:09:53PM +0200, Jan Nieuwenhuizen wrote:
In trying to nail down the notorious #1562, I started a ghostscript-9.0
branch in GUB, which uses ghostscript 9.02, freetype-2.4.4 and includes
a small
The code looks fine in general, but I question two of the properties
that have been added for MultiMeasureRest.
http://codereview.appspot.com/4536068/diff/19001/lily/multi-measure-rest.cc
File lily/multi-measure-rest.cc (right):
17 matches
Mail list logo
