Re: What's the deal with String_convert::reverse?

2011-08-24 Thread David Kastrup
k...@aspodata.se (Karl Hammar) writes: Reinhold: Am Tuesday, 23. August 2011, 22:30:24 schrieb David Kastrup: ... Is this used anywhere? A git grep didn't show any usage, but maybe I'm missing something. Make does not complain about this patch (on my box). - static string reverse

Re: Fix memleak: temporary skyline objects for systems were never deleted (issue 4923048)

2011-08-24 Thread David Kastrup
reinhold.kainho...@gmail.com writes: Reviewers: , Message: This patch fixes a memleak: Some temporary skylines were never deleted... Please review Description: Fix memleak: temporary skyline objects for systems were never deleted Please review this at

Re: Fixes heights and pure heights of stems. (issue 4898044)

2011-08-24 Thread Mike Solomon
On Aug 24, 2011, at 12:09 AM, Janek Warchoł wrote: 2011/8/16 Han-Wen Nienhuys hanw...@gmail.com: #2) sounds neat, but maybe Janek (who has spent some time messing around with flags) wants to weigh in. As i've said in a private mail to Mike, i don't have anything against doing so. Mike,

Re: Lilypond's SVG output

2011-08-24 Thread Marek Klein
Hello, 2011/8/18 Sandor Spruit a.g.l.spr...@uu.nl Hello, I recently had an informal discussion with some collegues on the use of SVG, in general. They are in music research, I am a developer working on a completely unrelated topic - so please forgive me my ignorance w.r.t. music-related

Re: Feta flag problem

2011-08-24 Thread Janek Warchoł
2011/8/24 Mike Solomon mike...@ufl.edu: Hey all, I recently finished a new work for harpsichord and had forgotten about the feta flag problem I reported before until I saw the printed output. On Mac OS X, the output looks good (see attached). you mean the pdf? It looks bad viewed on my

Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047)

2011-08-24 Thread Ian Hulin
Hi Graham, Carl, On Tue 23 Aug 2011 19:34:37 BST, Carl Sorensen wrote: On 8/23/11 12:21 PM, ianhuli...@gmail.com ianhuli...@gmail.com wrote: LGTM Maybe we should have some GOP rules for C++ about this? Only have multiple exit points from routines if you absolutely have to. Multiple

Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047)

2011-08-24 Thread David Kastrup
Ian Hulin ianhuli...@gmail.com writes: I'm not asking for a grand re-write on this, but for single-exit to be the preferred style for new code and patches where this would not provoke changes on a GCR (Grand Code Re-write) scale. I disagree. Structured exits decrease the level of nesting and

Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047)

2011-08-24 Thread Reinhold Kainhofer
Am Wednesday, 24. August 2011, 10:49:30 schrieben Sie: Hi Graham, Carl, On Tue 23 Aug 2011 19:34:37 BST, Carl Sorensen wrote: On 8/23/11 12:21 PM, ianhuli...@gmail.com ianhuli...@gmail.com wrote: Maybe we should have some GOP rules for C++ about this? Only have multiple exit points from

Re: Fixes heights and pure heights of stems. (issue 4898044)

2011-08-24 Thread Janek Warchoł
2011/8/24 Mike Solomon mike...@ufl.edu: On Aug 24, 2011, at 12:09 AM, Janek Warchoł wrote: 2011/8/16 Han-Wen Nienhuys hanw...@gmail.com: #2) sounds neat, but maybe Janek (who has spent some time messing around with flags) wants to weigh in. As i've said in a private mail to Mike, i don't

Re: Fixes heights and pure heights of stems. (issue 4898044)

2011-08-24 Thread Mike Solomon
On Aug 24, 2011, at 1:46 PM, Janek Warchoł wrote: 2011/8/24 Mike Solomon mike...@ufl.edu: On Aug 24, 2011, at 12:09 AM, Janek Warchoł wrote: 2011/8/16 Han-Wen Nienhuys hanw...@gmail.com: #2) sounds neat, but maybe Janek (who has spent some time messing around with flags) wants to weigh

bug reports for valgrind warnings?

2011-08-24 Thread Reinhold Kainhofer
I let valgrind run lilypond (both with optimization turned on and off) on all our regtests, and some of them (3-4) showed some warnings like invalid read access or uninitialized values. Shall I open a bug report for each regtest where valgrind shows a warning (the guile GC warnings are of

Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047)

2011-08-24 Thread Dan Eble
On 2011-08-24, at 05:10 , Reinhold Kainhofer wrote: Am Wednesday, 24. August 2011, 10:49:30 schrieben Sie: Hi Graham, Carl, On Tue 23 Aug 2011 19:34:37 BST, Carl Sorensen wrote: On 8/23/11 12:21 PM, ianhuli...@gmail.com ianhuli...@gmail.com wrote: Maybe we should have some GOP rules for

Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047)

2011-08-24 Thread David Kastrup
Dan Eble d...@faithful.be writes: There can be a run-time performance difference between branching or not branching. For the times you actually care, if you're not going to use compiler-specific features to mark conditions as likely or unlikely, you should test the likely case first so that

Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047)

2011-08-24 Thread Han-Wen Nienhuys
On Tue, Aug 23, 2011 at 3:21 PM, ianhuli...@gmail.com wrote: LGTM Maybe we should have some GOP rules for C++ about this? Can we not? Professionally, I work with an enormous style guide, and having a lot of style prescribed needlessly complicates code reviews, because it makes people hammer

Re: Fix memleak: temporary skyline objects for systems were never deleted (issue 4923048)

2011-08-24 Thread Han-Wen Nienhuys
On Wed, Aug 24, 2011 at 3:38 AM, David Kastrup d...@gnu.org wrote: reinhold.kainho...@gmail.com writes: Reviewers: , Message: This patch fixes a memleak: Some temporary skylines were never deleted... Please review Description: Fix memleak: temporary skyline objects for systems were

Re: Fix memleak: temporary skyline objects for systems were never deleted (issue 4923048)

2011-08-24 Thread David Kastrup
Han-Wen Nienhuys hanw...@gmail.com writes: Skylines are smobs.  The usual way to delete them would be to unprotect them once they have been registered by some garbage-collectable object (or a SCM variable that is being used for accessing them). They are simple smobs, though, so this pattern

Broken beams' slopes

2011-08-24 Thread Mike Solomon
Hey all, I'll be leaving on vacation in a week-ish, and as my summer-of-lily comes to a close, I can likely do one more medium-scale thing before I have to start correcting parallel fifths. I'd like to work on broken beam slopes such that a beam can break across lines and pick up where it left

Re: Broken beams' slopes

2011-08-24 Thread David Kastrup
Mike Solomon mike...@ufl.edu writes: Hey all, I'll be leaving on vacation in a week-ish, and as my summer-of-lily comes to a close, I can likely do one more medium-scale thing before I have to start correcting parallel fifths. I'd like to work on broken beam slopes such that a beam can

Re: Broken beams' slopes

2011-08-24 Thread Mike Solomon
On Aug 24, 2011, at 5:42 PM, David Kastrup wrote: Mike Solomon mike...@ufl.edu writes: Hey all, I'll be leaving on vacation in a week-ish, and as my summer-of-lily comes to a close, I can likely do one more medium-scale thing before I have to start correcting parallel fifths. I'd like

Re: bug reports for valgrind warnings?

2011-08-24 Thread Graham Percival
On Wed, Aug 24, 2011 at 02:08:41PM +0200, Reinhold Kainhofer wrote: Shall I open a bug report for each regtest where valgrind shows a warning (the guile GC warnings are of course filtered out using a suppressions file)? I wouldn't be surprised if you get some duplicate bugs, though -- I

Re: Broken beams' slopes

2011-08-24 Thread David Kastrup
Mike Solomon mike...@ufl.edu writes: On Aug 24, 2011, at 5:42 PM, David Kastrup wrote: Mike Solomon mike...@ufl.edu writes: I'll be leaving on vacation in a week-ish, and as my summer-of-lily comes to a close, I can likely do one more medium-scale thing before I have to start correcting

Re: bug reports for valgrind warnings?

2011-08-24 Thread Reinhold Kainhofer
Am Mittwoch, 24. August 2011, 18:18:33 schrieben Sie: On Wed, Aug 24, 2011 at 02:08:41PM +0200, Reinhold Kainhofer wrote: Shall I open a bug report for each regtest where valgrind shows a warning (the guile GC warnings are of course filtered out using a suppressions file)? I wouldn't be

Re: Fix memleak: temporary skyline objects for systems were never deleted (issue 4923048)

2011-08-24 Thread Reinhold Kainhofer
Am Mittwoch, 24. August 2011, 15:38:21 schrieb Han-Wen Nienhuys: On Wed, Aug 24, 2011 at 3:38 AM, David Kastrup d...@gnu.org wrote: Skylines are smobs. The usual way to delete them would be to unprotect them once they have been registered by some garbage-collectable object (or a SCM

Memleaks or not?

2011-08-24 Thread Reinhold Kainhofer
Running lilypond on a lot of files in one run, I observe that lilypond's memory usage slowly goes up with time, i.e. it seems that lilypond does not properly free all memory used for one score, before it starts with the next one. In particular, running lilypond on all 1010 regtests the output

limited access to e-mail

2011-08-24 Thread Janek Warchoł
Hi all, i am on choral workshops for a week. I hope to be able to set up a remote desktop to connect to my Lilydev-enabled machine and do some work, but nevertheless my access to development process will be limited. Therefore please don't feel ignored if i answer only to some e-mails for the

Re: Fix memleak: temporary skyline objects for systems were never deleted (issue 4923048)

2011-08-24 Thread Han-Wen Nienhuys
On Wed, Aug 24, 2011 at 10:57 AM, David Kastrup d...@gnu.org wrote: Han-Wen Nienhuys hanw...@gmail.com writes: Skylines are smobs.  The usual way to delete them would be to unprotect them once they have been registered by some garbage-collectable object (or a SCM variable that is being used

Re: Deprecate \fermataMarkup for full-bar rests. (issue 4672059)

2011-08-24 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4672059/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: MusicXML exporter (was Re: Lilypond lobbying?)

2011-08-24 Thread Jan Nieuwenhuizen
Pierre THIERRY writes: [cc lilypond-devel] If memory serves, so far we have US$200, C$100 and €200. If I were to work alone on this bounty, that would allow me to allocate approximately 20hrs, which should clearly be enough to write a nice XML exporting in some schema mimicking Lilypond's

Re: MusicXML exporter (was Re: Lilypond lobbying?)

2011-08-24 Thread Michael Ellis
On Wed, Aug 24, 2011 at 5:14 PM, Jan Nieuwenhuizen jann...@gnu.org wrote: Pierre THIERRY writes: [cc lilypond-devel] If memory serves, so far we have US$200, C$100 and €200. If I were to work alone on this bounty, that would allow me to allocate approximately 20hrs, which should clearly

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-08-24 Thread pkx166h
On 2011/08/08 22:09:09, Trevor Daniels wrote: LGTM Although I'm not sure about editing the other language files. Best wait for Francisco to comment. Francisco, can you tell me if this patch is ok to go as I have touched some of the translated docs to remove this snippet. Thanks

Re: GOP-PROP 10: scheme indentation (probable decision)

2011-08-24 Thread Neil Puttock
On 24 August 2011 22:26, Graham Percival gra...@percival-music.ca wrote: No complaints from last time, with the possible exception of Neil wanting a different behavior for (else...) I haven't had time to test it thoroughly since my last comments, but there are some other issues which will need

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-08-24 Thread pkx166h
On 2011/08/08 22:09:09, Trevor Daniels wrote: LGTM Although I'm not sure about editing the other language files. Best wait for Francisco to comment. Francisco, can you tell me if this patch is ok to go as I have touched some of the translated docs to remove this snippet. Thank

Re: Creates a Flag grob. (issue 4922042)

2011-08-24 Thread n . puttock
http://codereview.appspot.com/4922042/diff/17001/lily/flag.cc File lily/flag.cc (right): http://codereview.appspot.com/4922042/diff/17001/lily/flag.cc#newcode147 lily/flag.cc:147: what style of flag glyph is typeset on a what

Re: MusicXML exporter (was Re: Lilypond lobbying?)

2011-08-24 Thread Reinhold Kainhofer
Am Wednesday, 24. August 2011, 23:33:02 schrieb Michael Ellis: On Wed, Aug 24, 2011 at 5:14 PM, Jan Nieuwenhuizen jann...@gnu.org wrote: It's only about an hour of work (see below) to convert a simple and prepared .ly score to musicxml, see below. That sounds encouraging. So how far away

Re: MusicXML exporter (was Re: Lilypond lobbying?)

2011-08-24 Thread Kieren MacMillan
Hi all, In short, the only way to make it extendable for the future (so that one day we can also export the layout) is to handle (MusicXML) export similar to MIDI generation, namely via translators that collect all events and all settings as they appear in the score. +1. KMac.

Re: MusicXML exporter (was Re: Lilypond lobbying?)

2011-08-24 Thread Michael Ellis
On Wed, Aug 24, 2011 at 6:34 PM, Kieren MacMillan kieren_macmil...@sympatico.ca wrote: Hi all, In short, the only way to make it extendable for the future (so that one day we can also export the layout) is to handle (MusicXML) export similar to MIDI generation, namely via translators

Re: MusicXML exporter (was Re: Lilypond lobbying?)

2011-08-24 Thread Carl Sorensen
On 8/24/11 5:31 PM, Michael Ellis michael.f.el...@gmail.com wrote: On Wed, Aug 24, 2011 at 6:34 PM, Kieren MacMillan kieren_macmil...@sympatico.ca wrote: Hi all, In short, the only way to make it extendable for the future (so that one day we can also export the layout) is to handle

Re: MusicXML exporter (was Re: Lilypond lobbying?)

2011-08-24 Thread Kieren MacMillan
Hi Carl, Do you want 1) XML that captures only the music (and could be imported into some other program which will make the layout decisions)? No: this is trivial to obtain from #2 or #3, via XSLT. 2) XML that captures both the music and the layout (and could therefore be printed by some

Re: MusicXML exporter (was Re: Lilypond lobbying?)

2011-08-24 Thread David Kastrup
Kieren MacMillan kieren_macmil...@sympatico.ca writes: Do you want 1) XML that captures only the music (and could be imported into some other program which will make the layout decisions)? No: this is trivial to obtain from #2 or #3, via XSLT. You are using trivial like a mathematician,

Re: MusicXML exporter (was Re: Lilypond lobbying?)

2011-08-24 Thread Carl Sorensen
On 8/24/11 6:00 PM, Kieren MacMillan kieren_macmil...@sympatico.ca wrote: Hi Carl, My question is this: In what format is the final, typeset music stream such that extracting the music information only would be massively easier than extracting the music and layout information? I don't

Re: MusicXML exporter (was Re: Lilypond lobbying?)

2011-08-24 Thread Kieren MacMillan
David, No: this is trivial to obtain from #2 or #3, via XSLT. You are using trivial like a mathematician, strictly interchangeable with doable. Actually, I was using trivial in two ways: 1. As a mathematician (yes, I've had several papers published in peer-reviewed journals), I was — as you

Re: Nested context properties -- an implementation sketch

2011-08-24 Thread Reinhold Kainhofer
Am Sunday 14 August 2011, 17:31:11 schrieb David Kastrup: a) a revert will only cancel the last _matching_ override, and the match includes the complete specified property path, _and_ the prospective use of \once. \revert will not cancel \once\override and vice versa. b) At the end of a

PATCH: 48-hour countdown to 20:00 MDT 20110826

2011-08-24 Thread Colin Campbell
For Friday, August 26 (and where did the Summer go?) Issue 509 http://code.google.com/p/lilypond/issues/detail?id=509: collision nested tuplet numbers - R Issue 4808082 http://codereview.appspot.com/4808082/: Prevents nested tuplets from colliding. Issue 1328

Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047)

2011-08-24 Thread Dan Eble
On 2011-08-24, at 09:25 , David Kastrup wrote: Modern compilers pay very little attention to how you arrange the source code of equivalent constructs. My experience trying to finagle optimized code out of gcc was more than a year ago, and the compiler was probably a bit older than that (not