LGTM
http://codereview.appspot.com/5133043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Sun, Oct 02, 2011 at 02:10:47AM +0200, Julien Rioux wrote:
> Thanks, I got it to work a bit further: It uploaded to Rietveld,
> generated some comment on the googlepage, but errored in the end.
> File "/home/jrioux/git/git-cl/projecthosting_upload.py", line 79,
> in generate_devel_error
>
LGTM
http://codereview.appspot.com/5133043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
I agree with everything Trevor said, including pushing after you've
changed it and it compiles.
http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
http://codereview.appspot.com/4839061/diff
"m...@apollinemike.com" writes:
> On Oct 1, 2011, at 9:29 PM, David Kastrup wrote:
>>
>> This sounds really really icky. The sort of code I hope never to
>> need to deal with. Could you file a suitable "Enhancement" issue so
>> that redoing this in a less hackish manner does not get forgotten?
Here is a list of patches which have had no changes for four weeks or
more. I propose to mark them abandoned on Monday, unless their status
changes. If you update your patches, they should be marked New, to
trigger the review process. If you agree that the patch is abandoned,
you should prob
On Oct 1, 2011, at 9:29 PM, David Kastrup wrote:
> "m...@apollinemike.com" writes:
>
>> But I just pushed the actual cure.
>>
>> The problem was that positions stores two Y positions - a left and a
>> right. If the left is higher than right, than the interval is read as
>> empty. So, the cent
On 30/09/2011 1:59 PM, Graham Percival wrote:
Following Nicholas' suggestion from last February, I've fixed the
git-cl upload:
https://github.com/gperciva/git-cl/commit/86d891d0817b0d4946fd22bd03554ea2685337b9
I suggest that everybody using git-cl upgrade to this.
Also note that I've added a
This should address the comments posted at
http://codereview.appspot.com/5169041/
http://codereview.appspot.com/5131045/diff/5001/Documentation/GNUmakefile
File Documentation/GNUmakefile (left):
http://codereview.appspot.com/5131045/diff/5001/Documentation/GNUmakefile#oldcode250
Documentation/G
On 2011/09/27 09:12:44, Graham Percival wrote:
the email came through without trouble; the problem is the uploading.
Wait for Janek to do it. I've made issue 1491 release-critical.
I can't edit the code review created by Janek since I am not the owner.
I have been successful (to some extend
Patch posted here:
http://code.google.com/p/lilypond/issues/detail?id=1266#c3
On Fri, Sep 30, 2011 at 9:50 PM, Seafire wrote:
> This issue bothers me, so I took a look at it.
>
> It appears that extremal_head_ of the Dot_position struct found in
> dot-configuration.hh/.cc and dot-column.cc exist
A couple of nitpicks, otherwise LGTM (but untested).
(I'll abandon my patch - yours is better :)
Trevor
http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/positioning-multi-measure-rests.ly
File Documentation/snippets/new/positioning-multi-measure-rests.ly
(right):
http:/
A few comments, but otherwise LGTM. If you agree the changes and it
compiles please push.
Trevor
http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
http://codereview.appspot.com/4839061/
Reviewers: Neil Puttock,
Message:
Second draft with Neil's suggestions. Thank you Neil.
http://codereview.appspot.com/5133043/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):
http://codereview.appspot.com/5133043/diff/1/Documentation/changes.tely#newcode65
Documentati
"m...@apollinemike.com" writes:
> But I just pushed the actual cure.
>
> The problem was that positions stores two Y positions - a left and a
> right. If the left is higher than right, than the interval is read as
> empty. So, the center needs to be calculated manually.
>
> Interval is not real
On Oct 1, 2011, at 7:48 PM, David Kastrup wrote:
> "m...@apollinemike.com" writes:
>
>> On Oct 1, 2011, at 7:22 PM, Neil Puttock wrote:
>>
>>> On 1 October 2011 18:19, Peekay Ex wrote:
>>>
Neil what command do you run when you do a test-baseline so that I
might get something like yo
"m...@apollinemike.com" writes:
> On Oct 1, 2011, at 7:22 PM, Neil Puttock wrote:
>
>> On 1 October 2011 18:19, Peekay Ex wrote:
>>
>>> Neil what command do you run when you do a test-baseline so that I
>>> might get something like you do?
>>
>> I don't. :) I couldn't work out which file was
On Oct 1, 2011, at 7:22 PM, Neil Puttock wrote:
> On 1 October 2011 18:19, Peekay Ex wrote:
>
>> Neil what command do you run when you do a test-baseline so that I
>> might get something like you do?
>
> I don't. :) I couldn't work out which file was failing, so I did what
> I usually do: run
Neil,
On Sat, Oct 1, 2011 at 6:22 PM, Neil Puttock wrote:
> On 1 October 2011 18:19, Peekay Ex wrote:
>
>> Neil what command do you run when you do a test-baseline so that I
>> might get something like you do?
>
> I don't. :) I couldn't work out which file was failing, so I did what
> I usually
On Oct 1, 2011, at 7:22 PM, Neil Puttock wrote:
> On 1 October 2011 18:19, Peekay Ex wrote:
>
>> Neil what command do you run when you do a test-baseline so that I
>> might get something like you do?
>
> I don't. :) I couldn't work out which file was failing, so I did what
> I usually do: run
On 1 October 2011 18:19, Peekay Ex wrote:
> Neil what command do you run when you do a test-baseline so that I
> might get something like you do?
I don't. :) I couldn't work out which file was failing, so I did what
I usually do: run all the regression tests until it crashes.
The output I've p
Hello,
On Sat, Oct 1, 2011 at 6:01 PM, m...@apollinemike.com
wrote:
> On Oct 1, 2011, at 6:53 PM, Neil Puttock wrote:
>
>> Hey guys,
>>
>> I can't complete test-baseline due to an assertion error running
>> mozart-hrn-3.ly. Here's the backtrace:
>>
>> Drawing systems...lilypond: ../flower/includ
On 1 October 2011 18:16, Graham Percival wrote:
> The problem is verified; I see exactly the same behaviour as Neil
> with 4f49b000d6e257724e311b406e2346b8388c1f0e
Here's a minimal snippet which fails:
\version "2.15.14"
\relative c' {
\times 2/3 { f8 e d }
}
Cheers,
Neil
_
On Sat, Oct 01, 2011 at 07:04:25PM +0200, m...@apollinemike.com wrote:
>
> On Oct 1, 2011, at 7:01 PM, m...@apollinemike.com wrote:
>
> > On Oct 1, 2011, at 6:53 PM, Neil Puttock wrote:
> >
> >> Drawing systems...lilypond: ../flower/include/interval.hh:226: T
> >> Interval_t::center() const [wit
On 1 October 2011 18:04, m...@apollinemike.com wrote:
> A follow-up: I can't figure out how the error could come about.
> Interval::center should, in Tuplet_number::calc_y_offset, always be getting
> an interval for which it can find the center (it uses robust_scm2interval).
> Does anyone wi
On Oct 1, 2011, at 7:01 PM, m...@apollinemike.com wrote:
> On Oct 1, 2011, at 6:53 PM, Neil Puttock wrote:
>
>> Hey guys,
>>
>> I can't complete test-baseline due to an assertion error running
>> mozart-hrn-3.ly. Here's the backtrace:
>>
>> Drawing systems...lilypond: ../flower/include/interv
On Oct 1, 2011, at 6:53 PM, Neil Puttock wrote:
> Hey guys,
>
> I can't complete test-baseline due to an assertion error running
> mozart-hrn-3.ly. Here's the backtrace:
>
> Drawing systems...lilypond: ../flower/include/interval.hh:226: T
> Interval_t::center() const [with T = double]: Assertio
Hey guys,
I can't complete test-baseline due to an assertion error running
mozart-hrn-3.ly. Here's the backtrace:
Drawing systems...lilypond: ../flower/include/interval.hh:226: T
Interval_t::center() const [with T = double]: Assertion `!is_empty
()' failed.
Program received signal SIGABRT, Abor
On 2011/09/27 04:35:56, Graham Percival wrote:
http://codereview.appspot.com/4839061/diff/7002/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
http://codereview.appspot.com/4839061/diff/7002/Documentation/notation/changing-defaults.i
On Sat, Oct 01, 2011 at 02:16:20PM +0200, Bertrand Bordage wrote:
>2011/10/1 m...@apollinemike.com
> Actually, IRC is probably a better option (I just said Skype cuz it's
> the first thing that came to my mind). I'll keep all ya'll posted.
>
>For many reasons, I would prefer IR
Arthur Reutenauer writes:
> On Wed, Sep 28, 2011 at 05:31:31PM +0200, Werner LEMBERG wrote:
>> For hyphenation, there exists the libhyphen library (used e.g. in
>> OpenOffice).
>
> It implements the original hyphenation algorithm of TeX with
> extensions (I don't know what those are), but it do
On Wed, Sep 28, 2011 at 05:31:31PM +0200, Werner LEMBERG wrote:
> For hyphenation, there exists the libhyphen library (used e.g. in
> OpenOffice).
It implements the original hyphenation algorithm of TeX with
extensions (I don't know what those are), but it does not have the rules
for hyphenating
Is there any chance of making Feta unicode 3.1 (U+1D1xx) compatible? What
about possible support for other Unicode-compatible fonts?
http://www.alanwood.net/unicode/musical_symbols.html
- Alex
--
It is referred to as the Fibonacci meal. Today's dinner is the sum of
yesterday's leftovers and the
On Sat, Oct 01, 2011 at 02:12:44AM +0200, olafbuddenha...@gmx.net wrote:
> It might be true that Python is more readable for newcomers than make
> (though reading your examples, I'm not at all convinced of that...) --
> but how much does that really matter?
Many people already have some familiarit
2011/10/1 m...@apollinemike.com
> Bertrand's bringing two people from his fan club
>
Unfortunately, one of them can't come. Only Cécile will come.
Actually, IRC is probably a better option (I just said Skype cuz it's the
> first thing that came to my mind). I'll keep all ya'll posted.
>
For
Hi,
On Sun, Sep 25, 2011 at 07:01:04PM +0200, Karl Hammar wrote:
> Instead I've made two scripts depend_ly and depen_tex [1] which finds
> out what depends on what (think gcc -M), and make [2] takes care of
> the rest.
I think that's precisely the right thing to do :-)
> Would it be good to mak
Hi,
On Sun, Sep 25, 2011 at 03:12:14AM +0100, Graham Percival wrote:
> I will admit there is one aspect in which I *am* spoiled, though: I am
> totally spoiled by python's readable code. I am so accustomed to
> writing stuff like
> cmd = compiler + ' -o ' + exe_name + src_files
> or
>
On Oct 1, 2011, at 12:43 PM, Graham Percival wrote:
> On Sat, Oct 01, 2011 at 12:22:37PM +0200, m...@apollinemike.com wrote:
>> Just a note to letchya'll know that there'll be 7(ish) people attending
>> Extreme Makeover: Markup Edition in Paris over the weekend of the 15th.
>
> Wow, I didn't r
On Oct 1, 2011, at 12:48 PM, David Kastrup wrote:
> "m...@apollinemike.com" writes:
>
>> Hey all,
>>
>> Just a note to letchya'll know that there'll be 7(ish) people
>> attending Extreme Makeover: Markup Edition in Paris over the weekend
>> of the 15th. The idea is to make the behavior of mark
On Oct 1, 2011, at 12:43 PM, Graham Percival wrote:
> On Sat, Oct 01, 2011 at 12:22:37PM +0200, m...@apollinemike.com wrote:
>> Just a note to letchya'll know that there'll be 7(ish) people attending
>> Extreme Makeover: Markup Edition in Paris over the weekend of the 15th.
>
> Wow, I didn't
"m...@apollinemike.com" writes:
> Hey all,
>
> Just a note to letchya'll know that there'll be 7(ish) people
> attending Extreme Makeover: Markup Edition in Paris over the weekend
> of the 15th. The idea is to make the behavior of markups more robust
> (likely by treating them like objects (not
On Sat, Oct 01, 2011 at 12:22:37PM +0200, m...@apollinemike.com wrote:
>Just a note to letchya'll know that there'll be 7(ish) people attending
>Extreme Makeover: Markup Edition in Paris over the weekend of the 15th.
Wow, I didn't realize we had so many people in Paris. Who don't I
know?
Hey all,
Just a note to letchya'll know that there'll be 7(ish) people attending Extreme
Makeover: Markup Edition in Paris over the weekend of the 15th. The idea is to
make the behavior of markups more robust (likely by treating them like objects
(not in the pejorative sense of the term "treat
43 matches
Mail list logo
