LGTM.
On 2013/02/28 05:57:45, dak wrote:
I think we have a special span bar at the start,
The bar at the start is a SystemStartBar, which was not affected by the
recent span-bar bug. You might want an extra measure, and a final bar,
then. Also, some note in the texidoc saying that this test
"Phil Holmes" writes:
> There's lots of improvements that could be made: parallelism, using
> something other than diff, but it basically works.
>
> Thoughts?
CMP(1) User Commands CMP(1)
NAME
cmp - compare two files byte by byte
SYNOPSI
On 1 mars 2013, at 20:15, Phil Holmes wrote:
> 4 files attached. To try this out: create a new directory and place
> NoTagline.ly in it. Create a subdirectory called input and put some regtest
> files in there. Run MakeOldPix.sh. Make a change to lilypond. Run
> MakeNewPix.sh. Run Compa
4 files attached. To try this out: create a new directory and place
NoTagline.ly in it. Create a subdirectory called input and put some regtest
files in there. Run MakeOldPix.sh. Make a change to lilypond. Run
MakeNewPix.sh. Run ComparePix.sh. Om my tests there were some false
alarms, bu
On 2013/03/01 17:00:28, mike7 wrote:
On 1 mars 2013, at 17:30, mailto:d...@gnu.org wrote:
> On 2013/03/01 14:45:27, mike7 wrote:
>
>> > "doubleSlurs" is not generic but rather specific. I'd use
something
>> > like
>> > if (double_property_name_ && to_boolean (get_property
>> > (double_prope
On 1 mars 2013, at 17:30, d...@gnu.org wrote:
> On 2013/03/01 14:45:27, mike7 wrote:
>
>> > "doubleSlurs" is not generic but rather specific. I'd use something
>> > like
>> > if (double_property_name_ && to_boolean (get_property
>> > (double_property_name_)))
>> > instead, then we can, if desir
On 2013/03/01 14:45:27, mike7 wrote:
> "doubleSlurs" is not generic but rather specific. I'd use something
> like
> if (double_property_name_ && to_boolean (get_property
> (double_property_name_)))
> instead, then we can, if desired, have a separate doublePhrasingSlur
> property at some point o
Thanks for the review!
Cheers,
MS
> Thanks for the rebase!
>
>
> https://codereview.appspot.com/7437048/diff/1/lily/slur-engraver.cc
> File lily/slur-engraver.cc (right):
>
> https://codereview.appspot.com/7437048/diff/1/lily/slur-engraver.cc#newcode51
> lily/slur-engraver.cc:51: event_name_ =
Thanks for the rebase!
https://codereview.appspot.com/7437048/diff/1/lily/slur-engraver.cc
File lily/slur-engraver.cc (right):
https://codereview.appspot.com/7437048/diff/1/lily/slur-engraver.cc#newcode51
lily/slur-engraver.cc:51: event_name_ = "slur-event";
As a matter of style, I'd declare al
On 2013/03/01 10:56:57, MikeSol wrote:
Implements inheritence in slur engravers to avoid code dups
Mike, can you make that a separate review placed on issue 2689? Things
become too tangled up to review on their respective merits otherwise.
https://codereview.appspot.com/7424049/
>> #(define segfault-engraver
>
> I think, this is expectable. [...]
Definitely not! You might get an error, but a segfault is *always* a
severe bug which must be fixed.
Werner
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://list
Hi Rekado,
I think, this is expectable. The stop-translation-step is too late ...
you should create grobs in process-music.
If you want this to happen as a last action, you should look at the
order of all engravers. The last instanciated engraver should be
processed last, IIRC
HTH, Jan-Peter
12 matches
Mail list logo
