Re: Issue 3514: Clean up CG "Major release checklist". (issue 10759043)

2013-08-23 Thread markpolesky
Here's a revised doc patch that I started last month. Feel free to review. Thanks. - Mark https://codereview.appspot.com/10759043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCHES; Countdown for August 27th - 06:00 GMT

2013-08-23 Thread James
Hello, *Countdown – August 24th – 06:00 GMT* * * * * * * * * 3465 Critical keith Ohara Push Pitched trill layout Regress

Re: where are diminished and half-diminished symbols defined?

2013-08-23 Thread Frédéric Bron
> Where in the source are the chord symbols for diminished > (like °) and half-diminished (like ø) defined? Are they > glyphs, characters, markups or what? I looked but I can't > find them. And why is the half-diminished sign so much > bigger than the diminished? Is that intentional? > > \chord

Re: Tie Crusade - what to do now

2013-08-23 Thread Urs Liska
"Janek Warchoł" schrieb: >Hi, > >2013/8/20 Frédéric Bron : >>> For the programmers, i'd like to ask you to look at the branch >>> dev/tie-crusade/comments >>> and read the comments we've added to the code together with Franek. >> >> Just in case some would need, we can read all the added comm

where are diminished and half-diminished symbols defined?

2013-08-23 Thread Mark Polesky
Where in the source are the chord symbols for diminished (like °) and half-diminished (like ø) defined?  Are they glyphs, characters, markups or what?  I looked but I can't find them.  And why is the half-diminished sign so much bigger than the diminished?  Is that intentional? \chords {   c:dim  

Re: regression testing

2013-08-23 Thread James
Frederic, Upload the patch as normal and I can test this. James On 23 August 2013 14:47, Frédéric Bron wrote: > When I run the regression tests on master, 3257 run nicely. > Some fail (more than 100, difficult to count on the html page) like > input/regression/context-mod-context.log which pr

Re: What tests are run by patchy?

2013-08-23 Thread David Kastrup
Frédéric Bron writes: >> const string & as return type is madness. For one thing, it's >> guaranteed _not_ to be an efficiency gain in C++11. For another, it >> produces _serious_ destructor/lifetime issues. > > Of course I am not speaking of new strings created in the function! > That would be

regression testing

2013-08-23 Thread Frédéric Bron
When I run the regression tests on master, 3257 run nicely. Some fail (more than 100, difficult to count on the html page) like input/regression/context-mod-context.log which produces the output found below. Is it an issue on my platform (Fedora 19, g++ 4.8.1, Guile 1.8.8) or are those normal regre

Re: What tests are run by patchy?

2013-08-23 Thread Frédéric Bron
> Which textbooks would that be? I think for example at Scott Meyers books (Effective C++, More effective C++...). I also read this in the 4th edition (includes C++11) of the C++ programming language (Stroustrup): "How do we choose among the ways of passing arguments? My rules of thumb are: [1] U

Re: What tests are run by patchy?

2013-08-23 Thread David Kastrup
Frédéric Bron writes: >> Have you double-checked the code g++ generates? I should not be overly >> surprised if current versions don't actually do much copying unless >> required. > > I know what you mean: "premature optimization is the root of all > evil". But here, it is just following standar

Re: What tests are run by patchy?

2013-08-23 Thread Frédéric Bron
>> Also I check for compiler warnings but lilypond builds with a lot of >> compiler warnings which does not help. I think we should try to remove >> all warnings. >> > Such as what? Maybe there are new in g++ 4.8.1. I get 260 lines of warnings with make. Here all the warnings I get (duplicates rem

Re: What tests are run by patchy?

2013-08-23 Thread Frédéric Bron
> Have you double-checked the code g++ generates? I should not be overly > surprised if current versions don't actually do much copying unless > required. I know what you mean: "premature optimization is the root of all evil". But here, it is just following standard practice as recommended by all

Re: What tests are run by patchy?

2013-08-23 Thread James
Frederic, On 23 August 2013 13:08, Frédéric Bron wrote: > > Also I check for compiler warnings but lilypond builds with a lot of > compiler warnings which does not help. I think we should try to remove > all warnings. > > > Such as what? James ___ li

Re: What tests are run by patchy?

2013-08-23 Thread Frédéric Bron
> I would at least normally expect that you do a 'make' to see that it builds > against current tree - sometimes on the morning of the PATCH countdown, that > is hard because someone may push a patch and the new tree is merged before > the test scripts are run and you submitted a patch based on the

Re: What tests are run by patchy?

2013-08-23 Thread David Kastrup
Frédéric Bron writes: >> it does a make a make check (reg test comparison) and by default a full make >> doc. > > Good point. I am preparing a large patch to replace 'string' by 'const > string&' where it makes sense (to avoid string copy when possible) and > although I am going to run make check

Re: What tests are run by patchy?

2013-08-23 Thread James
Frederic On 23 August 2013 10:10, Frédéric Bron wrote: > > it does a make a make check (reg test comparison) and by default a full > make > > doc. > > Good point. I am preparing a large patch to replace 'string' by 'const > string&' where it makes sense (to avoid string copy when possible) and

Re: What tests are run by patchy?

2013-08-23 Thread Frédéric Bron
> it does a make a make check (reg test comparison) and by default a full make > doc. Good point. I am preparing a large patch to replace 'string' by 'const string&' where it makes sense (to avoid string copy when possible) and although I am going to run make check my-self before submitting, I am

Re: untangling the remaining regressions

2013-08-23 Thread David Kastrup
Keith OHara writes: > David Kastrup gnu.org> writes: > >> "Keith OHara" oco.net> writes: >> >> > 'cross-staff' marks grobs whose positioning (relative to their parent) >> > depends on the spacing of staves on the page. These grobs have to be >> > positioned last, after all grobs moving with t

Re: What tests are run by patchy?

2013-08-23 Thread James
Frederic 2013/8/23 Frédéric Bron > > Patchy the autobot says: passes tests. > > What tests are run by patchy? > - compilation? > - regressions? > > Frédéric > > ___ > lilypond-devel mailing list > lilypond-devel@gnu.org > https://lists.gnu.org/mailman

Re: What tests are run by patchy?

2013-08-23 Thread Phil Holmes
- Original Message - From: "Frédéric Bron" To: Sent: Friday, August 23, 2013 9:31 AM Subject: What tests are run by patchy? Patchy the autobot says: passes tests. What tests are run by patchy? - compilation? - regressions? Frédéric ___

What tests are run by patchy?

2013-08-23 Thread Frédéric Bron
> Patchy the autobot says: passes tests. What tests are run by patchy? - compilation? - regressions? Frédéric ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: untangling the remaining regressions

2013-08-23 Thread Keith OHara
David Kastrup gnu.org> writes: > "Keith OHara" oco.net> writes: > > > 'cross-staff' marks grobs whose positioning (relative to their parent) > > depends on the spacing of staves on the page. These grobs have to be > > positioned last, after all grobs moving with their parent Staff are > > posi