Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

On 28 août 2013, at 05:28, "Keith OHara" wrote: > On Mon, 26 Aug 2013 23:57:58 -0700, Mike Solomon wrote: > >> On 27 août 2013, at 09:01, "Keith OHara" wrote: >> >>> On Mon, 26 Aug 2013 22:37:17 -0700, Mike Solomon >>> wrote: >>> I'd argue that (2) is better. >>> >>> What, then, is

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

On Mon, 26 Aug 2013 23:57:58 -0700, Mike Solomon wrote: On 27 août 2013, at 09:01, "Keith OHara" wrote: On Mon, 26 Aug 2013 22:37:17 -0700, Mike Solomon wrote: I'd argue that (2) is better. What, then, is your argument ? What I put below - namely, that it is consistent with the previo

Re: push-access

On Tue, Aug 27, 2013 at 09:42:37PM +0200, David Kastrup wrote: > Thomas Morley writes: > > > Actually trying to push I followed CG and did > > > > git checkout staging > > git pull -r > > git merge dev/handle-grace > > Uh what? So much for stating that CG is our best reference. The CG has at l

Re: Trap pure-y-common spanning multiple staves; issue 3359 (issue 13013046)

On 2013/08/27 17:44:52, Keith wrote: On 2013/08/27 07:59:59, janek wrote: > could you expand the commit message (or add a comment in > the source) to explain why we want this? Good point. I put that comment where the test might make more sense, if we can figure out how to put it there with t

Re: push-access

2013/8/27 Thomas Morley : > 2013/8/27 David Kastrup : >> Thomas Morley writes: >> >>> 2013/8/27 Thomas Morley : 2013/8/27 Graham Percival : > On Tue, Aug 27, 2013 at 01:36:24PM +0200, Thomas Morley wrote: >> To be sure: am I right that it will succeed only _after_ Graham >> grante

Re: colorful make output! yum!

Hi, thank you for all your feedback. Btw, Franek, Harm tried compiling lilypond with your patch and the > colors didn't show - there were just verbatim color codes. > Interestinglty, git log and diff worked with colors. Any ideas? > It may be problem with echo invocation, and option -e (interpre

Re: push-access

2013/8/27 David Kastrup : > Thomas Morley writes: > >> 2013/8/27 Thomas Morley : >>> 2013/8/27 Graham Percival : On Tue, Aug 27, 2013 at 01:36:24PM +0200, Thomas Morley wrote: > To be sure: am I right that it will succeed only _after_ Graham > granted membership? Approved no

Re: push-access

Thomas Morley writes: > 2013/8/27 Thomas Morley : >> 2013/8/27 Graham Percival : >>> On Tue, Aug 27, 2013 at 01:36:24PM +0200, Thomas Morley wrote: To be sure: am I right that it will succeed only _after_ Graham granted membership? >>> >>> Approved now. >>> >>> Cheers, >>> - Graham >> >

Re: push-access

2013/8/27 Thomas Morley : > 2013/8/27 Graham Percival : >> On Tue, Aug 27, 2013 at 01:36:24PM +0200, Thomas Morley wrote: >>> To be sure: am I right that it will succeed only _after_ Graham >>> granted membership? >> >> Approved now. >> >> Cheers, >> - Graham > > Thanks! > Afaics, all works and I'v

Re: Trap pure-y-common spanning multiple staves; issue 3359 (issue 13013046)

Reviewers: janek, Message: On 2013/08/27 07:59:59, janek wrote: could you expand the commit message (or add a comment in the source) to explain why we want this? Good point. I put that comment where the test might make more sense, if we can figure out how to put it there with the new organizat

Re: push-access

"Phil Holmes" writes: > - Original Message - > From: "Thomas Morley" > To: "Graham Percival" > Cc: "lilypond-devel" > Sent: Tuesday, August 27, 2013 1:32 PM > Subject: Re: push-access > > >> 2013/8/27 Graham Percival : >>> On Tue, Aug 27, 2013 at 01:36:24PM +0200, Thomas Morley wrote:

Re: push-access

- Original Message - From: "Thomas Morley" To: "Graham Percival" Cc: "lilypond-devel" Sent: Tuesday, August 27, 2013 1:32 PM Subject: Re: push-access 2013/8/27 Graham Percival : On Tue, Aug 27, 2013 at 01:36:24PM +0200, Thomas Morley wrote: To be sure: am I right that it will succ

Re: Issue 3457: Add snippet `Using \partcombine with lyrics'. (issue 11328043)

2013/7/19 : > On 2013/07/19 19:35:13, Mark Polesky wrote: >> Is there no way to extract the averages of the NoteColumn >> X-positions between two voices? So given these voices: > > Please check out > http://code.google.com/p/lilypond/issues/detail?id=3232>. Its > original title was "LilyPond sho

Re: push-access

2013/8/27 Graham Percival : > On Tue, Aug 27, 2013 at 01:36:24PM +0200, Thomas Morley wrote: >> To be sure: am I right that it will succeed only _after_ Graham >> granted membership? > > Approved now. > > Cheers, > - Graham Thanks! Afaics, all works and I've push-access. Next step: I'll reread CG

Re: push-access

On Tue, Aug 27, 2013 at 01:36:24PM +0200, Thomas Morley wrote: > To be sure: am I right that it will succeed only _after_ Graham > granted membership? Approved now. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.g

Re: push-access

Thomas Morley writes: > Hi, > > as mentioned on the tracker for issue 3508 I'll surely need some help. > > For now I performed steps 1-6 from CG > http://lilypond.org/doc/v2.17/Documentation/contributor/commit-access > successfully without any problem, afaics. > > Trying step 7: > git pull --verb

push-access

Hi, as mentioned on the tracker for issue 3508 I'll surely need some help. For now I performed steps 1-6 from CG http://lilypond.org/doc/v2.17/Documentation/contributor/commit-access successfully without any problem, afaics. Trying step 7: git pull --verbose returns: harm@harm-laptop ~/lilypond

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

On 27 août 2013, at 11:09, d...@gnu.org wrote: > On 2013/08/27 06:58:05, mike7 wrote: >> On 27 août 2013, at 09:01, "Keith OHara" > wrote: > >> > How are skylines asked-for, and is it possible to know if they were > asked for >> while interpreting the markup ? >> > {

Re: Parse composite music in context modifications in \notemode (issue 12773047)

I like this! Please put this example into commit message and/or a comment in the code :) best, Janek 2013/8/27 : > Reviewers: janek, > > Message: > > On 2013/08/27 07:43:41, janek wrote: >> >> Hi, > > >> could you write a 2-sentence explanation why we want to do this? > > >> Janek > > > \new St

Re: Parse composite music in context modifications in \notemode (issue 12773047)

Reviewers: janek, Message: On 2013/08/27 07:43:41, janek wrote: Hi, could you write a 2-sentence explanation why we want to do this? Janek \new Staff \with { \transposition f' } { g a b c' } Description: Parse composite music in context modifications in \notemode Please review this at

Re: Let parser accept symbols after \new, \context, \unset and implicit \set (issue 13180044)

ok, thanks. 2013/8/27 : > Reviewers: janek, > > Message: > > On 2013/08/27 07:48:08, janek wrote: >> >> Looks like a good thing to do, but what does this change mean? > > > It means it lets the parser accept symbols after \new, \context, \unset > and implicit \set. After the symbol list changes

Re: Let parser accept symbols after \new, \context, \unset and implicit \set (issue 13180044)

Reviewers: janek, Message: On 2013/08/27 07:48:08, janek wrote: Looks like a good thing to do, but what does this change mean? It means it lets the parser accept symbols after \new, \context, \unset and implicit \set. After the symbol list changes of issue 2883 (which made x.y equivalent to #

Re: Issue 3457: Add NullVoice context (using \partcombine with lyrics). (issue 11328043)

LGTM. interesting approach. https://codereview.appspot.com/11328043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

On 2013/08/27 06:58:05, mike7 wrote: On 27 août 2013, at 09:01, "Keith OHara" wrote: > How are skylines asked-for, and is it possible to know if they were asked for while interpreting the markup ? > {c4-\markup \whiteout \pad-to-box #(-0.5 . 9) #(-0.5 . 1.5) \con

Trap pure-y-common spanning multiple staves; issue 3359 (issue 13013046)

the code LGTM; however, could you expand the commit message (or add a comment in the source) to explain why we want this? I think that this comment http://code.google.com/p/lilypond/issues/detail?id=3359#c11 is a good material and just needs a few rewords. thanks, Janek https://codereview.appsp

removed unused code: functions that are declared but never defined and stream.hh (issue 12800047)

LGTM https://codereview.appspot.com/12800047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

removed unused header tie-column-format.hh (issue 13116044)

LGTM https://codereview.appspot.com/13116044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 3514: Clean up CG "Major release checklist". (issue 10759043)

LGTM https://codereview.appspot.com/10759043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Let parser accept symbols after \new, \context, \unset and implicit \set (issue 13180044)

Looks like a good thing to do, but what does this change mean? Will we be a) able to do things that were previously impossible or b) is there no user-visible difference? I think the answer is b), but i'd like to make sure. https://codereview.appspot.com/13180044/ ___

Parse composite music in context modifications in \notemode (issue 12773047)

Hi, could you write a 2-sentence explanation why we want to do this? Janek https://codereview.appspot.com/12773047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: stencils: let some stencils carry a box-extent; issue 3255 (issue 9295044)

LGTM. https://codereview.appspot.com/9295044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel