PATCHES: Countdown for October 7 - 06:00 GMT

2013-10-04 Thread James
*Countdown – October 7th – 06:00 GMT* * * * * * * * * * * * * * * * * * * 3578http://code.google.com/p/lilypond/issues/detail?id=3578q=label%3APatch-pushsort=-owner%20patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Summary%20Modified Enhancement Julien Rioux push Patch: Build:

Re: Add backup option to convert-ly (Issue 3572) (issue 14040043)

2013-10-04 Thread dak
https://codereview.appspot.com/14040043/diff/6001/scripts/convert-ly.py File scripts/convert-ly.py (right): https://codereview.appspot.com/14040043/diff/6001/scripts/convert-ly.py#newcode241 scripts/convert-ly.py:241: while os.path.exists(back_up) and os.path.isfile(back_up): I'd do a

Re: Add backup option to convert-ly (Issue 3572) (issue 14040043)

2013-10-04 Thread Phil Holmes
- Original Message - From: d...@gnu.org To: philehol...@googlemail.com; julien.ri...@gmail.com; ianhuli...@gmail.com; m...@philholmes.net Cc: lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com Sent: Friday, October 04, 2013 3:24 PM Subject: Re: Add backup option to convert-ly

Re: Add backup option to convert-ly (Issue 3572) (issue 14040043)

2013-10-04 Thread dak
On 2013/10/04 14:41:28, email_philholmes.net wrote: - Original Message - From: mailto:d...@gnu.org To: philehol...@googlemail.com; julien.ri...@gmail.com; ianhuli...@gmail.com; mailto:m...@philholmes.net Cc: lilypond-devel@gnu.org; mailto:re...@codereview-hr.appspotmail.com Sent:

Re: Add backup option to convert-ly (Issue 3572) (issue 14040043)

2013-10-04 Thread Phil Holmes
- Original Message - From: d...@gnu.org To: philehol...@googlemail.com; julien.ri...@gmail.com; ianhuli...@gmail.com; m...@philholmes.net; em...@philholmes.net Cc: lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com Sent: Friday, October 04, 2013 3:53 PM Subject: Re: Add backup

Re: Add backup option to convert-ly (Issue 3572) (issue 14040043)

2013-10-04 Thread dak
On 2013/10/04 15:09:48, email_philholmes.net wrote: convert-ly -edn file.ly I'm really confused here. -n is the option for no-version. How is this related to backup? Sorry, probably confused this with -b. The rest of the comment stands. https://codereview.appspot.com/14040043/

Re: Add backup option to convert-ly (Issue 3572) (issue 14040043)

2013-10-04 Thread dak
On 2013/10/04 15:47:17, dak wrote: On 2013/10/04 15:09:48, http://email_philholmes.net wrote: convert-ly -edn file.ly I'm really confused here. -n is the option for no-version. How is this related to backup? Sorry, probably confused this with -b. The rest of the comment stands.

Re: Add backup option to convert-ly (Issue 3572) (issue 14040043)

2013-10-04 Thread Eluze
Phil Holmes wrote And while we are at it: the loop has the condition while os.path.exists(back_up) and os.path.isfile(back_up): for skipping over existing files. The second part of the condition is nonsensical since it means that a name will be used for backing up even if it is already

Re: Add backup option to convert-ly (Issue 3572) (issue 14040043)

2013-10-04 Thread David Kastrup
Eluze elu...@gmail.com writes: Phil Holmes wrote And while we are at it: the loop has the condition while os.path.exists(back_up) and os.path.isfile(back_up): for skipping over existing files. The second part of the condition is nonsensical since it means that a name will be used for

Re: Add backup option to convert-ly (Issue 3572) (issue 14040043)

2013-10-04 Thread Eluze
dak wrote Eluze lt; eluzew@ gt; writes: now reading a little bit more I found that A path is an unambiguous pointer to a resource in the file system. It can either point to a file or to a directory. this seems exactly what we don't want, we don't deal with directories here - so it's

Re: Add backup option to convert-ly (Issue 3572) (issue 14040043)

2013-10-04 Thread Eluze
dak wrote Eluze lt; eluzew@ gt; writes: now reading a little bit more I found that A path is an unambiguous pointer to a resource in the file system. It can either point to a file or to a directory. this seems exactly what we don't want, we don't deal with directories here - so it's

Issue 3572: convert-ly should produce several backup files for each invokation (issue 14383044)

2013-10-04 Thread dak
Reviewers: , https://codereview.appspot.com/14383044/diff/1/Documentation/usage/updating.itely File Documentation/usage/updating.itely (right): https://codereview.appspot.com/14383044/diff/1/Documentation/usage/updating.itely#newcode172 Documentation/usage/updating.itely:172: @item -h,--help