On Dec 15, 2013, at 12:58 AM, Keith OHara wrote:
> On Sat, 14 Dec 2013 00:49:43 -0800, Mike Solomon wrote:
>
>> On Dec 14, 2013, at 9:35 AM, David Kastrup wrote:
>>
>>> Most of the contortions seem focused about when or when not and how to
>>> pass begin/end columns. It would seem to make s
On Sat, Dec 14, 2013 at 09:46:54AM +, lilyli...@googlemail.com wrote:
>
> On 2013/12/14 03:51:33, Graham Percival wrote:
> >Umm, isn't the whole point of this to be a warning? Why are you
> removing the
> >warning CSS tag?
>
> It's the whole point of this patch to raise this information to t
LGTM.
https://codereview.appspot.com/39320044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
https://codereview.appspot.com/42330044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
if requested, I can either update dev/janek/metafont-cleanup
or push as a new branch.
Please do so!
https://codereview.appspot.com/42330044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2013/12/14 22:32:06, Devon Schudy wrote:
This interface is unlike any other in Lilypond,
This was intended not as an interface to a built-in bulletproof engine,
but rather a template that users can adopt and change.
Maybe calling it a 'built-in' template, and its attempt to be as general
as
On Sat, 14 Dec 2013 14:58:52 -0800, Keith OHara wrote:
Several considered line-breaks might have the same 'start' and 'end' around the
hairpin, but the upper-level axis-group structure caches results for each
start/end pair so just one skyline is generated for each distinct pair request.
Th
On Sat, 14 Dec 2013 00:49:43 -0800, Mike Solomon wrote:
On Dec 14, 2013, at 9:35 AM, David Kastrup wrote:
Most of the contortions seem focused about when or when not and how to
pass begin/end columns. It would seem to make sense to turn them into
dynamic parameters *begin* *end* that you ca
This interface is unlike any other in Lilypond, in ways that make it
less flexible and may surprise users:
* It has two separate files that need to be included in the right
places.
* It requires the user to use certain specific variable names.
* The second include file doesn't just add definiti
Han-Wen Nienhuys writes:
> On Sat, Dec 14, 2013 at 6:32 PM, David Kastrup wrote:
>>
>> The only place where it is "pushed" is when creating a _new_ book, and
>> then it is cleared out immediately before it. What kind of pushing is
>> that supposed to be? What does that even mean? A paper bloc
On Sat, Dec 14, 2013 at 6:32 PM, David Kastrup wrote:
>
> The only place where it is "pushed" is when creating a _new_ book, and
> then it is cleared out immediately before it. What kind of pushing is
> that supposed to be? What does that even mean? A paper block in a book
> definition manipula
Reviewers: Jean-Charles,
Message:
On 2013/12/14 16:15:14, Jean-Charles wrote:
LGTM, except one typo.
https://codereview.appspot.com/41990043/diff/1/Documentation/learning/templates.itely
File Documentation/learning/templates.itely (right):
https://codereview.appspot.com/41990043/diff/1/Do
The only place where it is "pushed" is when creating a _new_ book, and
then it is cleared out immediately before it. What kind of pushing is
that supposed to be? What does that even mean? A paper block in a book
definition manipulated the top book entry, except when looking at a book
identifier
>>> However, if you don't mind, i'd prefer to leave it as is - i have
>>> _already_ spent about 4 hours cleaning up and rebasing commits to
make
>>> them somewhat ordered for review, and i'm quite tired.
>>
>>
>> I do mind. this is not the sort of thing that can be done in a
>> follow up patch.
Reviewers: ,
Message:
continuation of
http://codereview.appspot.com/38530043
belonging to
http://code.google.com/p/lilypond/issues/detail?id=3705
if requested, I can either update dev/janek/metafont-cleanup or push as
a new branch.
Description:
splitting file movement and whitespace-only change
LGTM, except one typo.
https://codereview.appspot.com/41990043/diff/1/Documentation/learning/templates.itely
File Documentation/learning/templates.itely (right):
https://codereview.appspot.com/41990043/diff/1/Documentation/learning/templates.itely#newcode53
Documentation/learning/templates.itel
- Original Message -
From: "David Kastrup"
To: "Carl Peterson"
Cc: "James" ; "Lilypond Dev" ;
"Phil Holmes"
Sent: Saturday, December 14, 2013 2:27 PM
Subject: Re: Enable manual-specific styling of documentation; issue 3714
(issue 36480048)
Carl Peterson writes:
On Sat, Dec 14
Carl Peterson writes:
> On Sat, Dec 14, 2013 at 1:50 AM, James wrote:
>> On 14/12/13 05:57, Carl Peterson wrote:
>>> I have updated the patch in Rietvald
>>
>>
>> But not the tracker. So the patch will not get tested.
>>
>> Please remember to either use git-cl or change the tracker to patch-new
On Sat, Dec 14, 2013 at 1:50 AM, James wrote:
> On 14/12/13 05:57, Carl Peterson wrote:
>> I have updated the patch in Rietvald
>
>
> But not the tracker. So the patch will not get tested.
>
> Please remember to either use git-cl or change the tracker to patch-new
> whenever you make a change in R
one nit, patch is in test at the moment before I noticed this.
https://codereview.appspot.com/42070044/diff/1/Documentation/contributor/programming-work.itexi
File Documentation/contributor/programming-work.itexi (right):
https://codereview.appspot.com/42070044/diff/1/Documentation/contributor/
- Original Message -
From: "David Kastrup"
To: "Urs Liska"
Cc: "Graham Percival" ; "Phil Holmes"
; "LilyPond Development Team"
Sent: Saturday, December 14, 2013 10:04 AM
Subject: Re: Website questions: Manual->Web
Urs Liska writes:
Am 14.12.2013 05:01, schrieb Graham Percival:
Am 14.12.2013 11:04, schrieb David Kastrup:
t's not totally clear whether it has other
functions at the moment that could disrupt the regular operations when
removed.
Would be removing it (locally), making a full make website (and make
doc?) and walking through the whole site manually be enoug
On Dec 14, 2013, at 12:00 PM, d...@gnu.org wrote:
>
> https://codereview.appspot.com/42190043/diff/1/lily/unpure-pure-container.cc
> File lily/unpure-pure-container.cc (right):
>
> https://codereview.appspot.com/42190043/diff/1/lily/unpure-pure-container.cc#newcode45
> lily/unpure-pure-container
Urs Liska writes:
> Am 14.12.2013 05:01, schrieb Graham Percival:
>> On Fri, Dec 13, 2013 at 03:40:03PM -, Phil Holmes wrote:
>>> I _think_ the odd place of "web" in the manuals hierarchy is down to
>>> it being the only part of the documentation that built using "make
>>> website" - it has s
https://codereview.appspot.com/42190043/diff/1/lily/unpure-pure-container.cc
File lily/unpure-pure-container.cc (right):
https://codereview.appspot.com/42190043/diff/1/lily/unpure-pure-container.cc#newcode45
lily/unpure-pure-container.cc:45:
On 2013/12/14 09:47:33, MikeSol wrote:
Looking good.
Am 14.12.2013 04:57, schrieb Graham Percival:
On Thu, Dec 12, 2013 at 09:34:28PM +0100, Urs Liska wrote:
When I go there I can download the whole website as a PDF. OK, this
makes sense.
Getting it as one big HTML page also makes sense.
[but where can I get it in info format?)
We don't provide l
Am 14.12.2013 05:01, schrieb Graham Percival:
On Fri, Dec 13, 2013 at 03:40:03PM -, Phil Holmes wrote:
I _think_ the odd place of "web" in the manuals hierarchy is down to
it being the only part of the documentation that built using "make
website" - it has something of a split personality be
https://codereview.appspot.com/42190043/diff/1/lily/unpure-pure-container.cc
File lily/unpure-pure-container.cc (right):
https://codereview.appspot.com/42190043/diff/1/lily/unpure-pure-container.cc#newcode45
lily/unpure-pure-container.cc:45:
Looking good.
The only thing is - how do we verify th
https://codereview.appspot.com/40510046/diff/40001/Documentation/web/download.itexi
File Documentation/web/download.itexi (left):
https://codereview.appspot.com/40510046/diff/40001/Documentation/web/download.itexi#oldcode35
Documentation/web/download.itexi:35: @warningTextBased
On 2013/12/14 03:
On Dec 14, 2013, at 9:35 AM, David Kastrup wrote:
> "Keith OHara" writes:
>
>> On Fri, 13 Dec 2013 23:05:49 -0800, David Kastrup wrote:
>>
>>> That does not make sense. If you want call-once behavior, you can just
>>> use a callback.
>>
>> At the moment, the decision on whether to preserve
On Dec 14, 2013, at 9:21 AM, Keith OHara wrote:
> On Fri, 13 Dec 2013 23:05:49 -0800, David Kastrup wrote:
>
>> That does not make sense. If you want call-once behavior, you can just
>> use a callback.
>
> At the moment, the decision on whether to preserve the callback pointer in
> the grob
"Keith OHara" writes:
> On Fri, 13 Dec 2013 23:05:49 -0800, David Kastrup wrote:
>
>> That does not make sense. If you want call-once behavior, you can just
>> use a callback.
>
> At the moment, the decision on whether to preserve the callback
> pointer in the grob property, or fill the propert
32 matches
Mail list logo
