James writes:
> CCing dev list in case anyone who understand the build system knows what
> is going on here
Not really a build system problem.
> On 28/06/14 16:59, Aymeric O. wrote:
>> And the problem comes from "-danti-alias-factor=$(ANTI_ALIAS_FACTOR)"
>> (=2), which is responsible for the c
Janek Warchoł writes:
> I think we should enourage developers to use fixcc more often, and
> then Graham's concern is very valid. I can say that having to move
> past 5 code reformattings when doing git blame is pretty annoying,
git blame -w
--
David Kastrup
_
On Sun, Jun 29, 2014 at 12:08:56AM +0200, Janek Warchoł wrote:
> If "badly formatted" <=> "different than what fixcc.py would produce",
> i would say that LilyPond often gets badly formatted code - as you
> wrote, running fixcc now results in 400 lines of changes.
This could, of course, be complet
Is it worth making the Notation Reference longer?
https://codereview.appspot.com/110240044/diff/40001/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):
https://codereview.appspot.com/110240044/diff/40001/Documentation/notation/pitches.itely#newcode1325
Docu
On 2014/06/27 04:34:36, lemzwerg wrote:
LGTM (without any testing).
Thanks, Werner!
I decided to move code refactoring to another issue, so that this one is
only about changing how various grobs are aligned. It is now Issue 3978
(https://code.google.com/p/lilypond/issues/detail?id=3978), and
2014-06-28 16:53 GMT+02:00 Devon Schudy :
> Graham Percival wrote:
>> However, fixcc.py should reject any version other than the
>> specific version we want. Otherwise, you could run it on your
>> computer (and push it), then I could run it on my computer (and
>> push it), then you could do the sa
CCing dev list in case anyone who understand the build system knows what
is going on here
On 28/06/14 16:59, Aymeric O. wrote:
> I found where the problem is!
>
> In make/lilypond-vars.make, the options used by LilyPond to generate
> the output files are given there:
>
> ## override from cmd line
Now added an example for the horizontal and parenthesis padding for
fretted diagrams
https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#newcode90
Documenta
On 28/06/14 19:19, Thomas Morley wrote:
> 2014-06-28 18:05 GMT+02:00 James :
>> Hello,
>>
>> I just want to check the following for the
>> 'fret-label-horizontal-offset' option we have added.
>>
>> --snip--
>>
>> \version "2.19.8"
>>
>> \new Voice {
>> c''1^\markup {
>> \override #'(fret-diag
2014-06-28 18:05 GMT+02:00 James :
> Hello,
>
> I just want to check the following for the
> 'fret-label-horizontal-offset' option we have added.
>
> --snip--
>
> \version "2.19.8"
>
> \new Voice {
> c''1^\markup {
> \override #'(fret-diagram-details . (
> (fret-label-horizon
Thanks
https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/108130043/diff/1/Documentation/changes.tely#newcode68
Documentation/changes.tely:68: Improved the automatic @q{x-extent}
placement of Acciden
Hello,
I just want to check the following for the
'fret-label-horizontal-offset' option we have added.
--snip--
\version "2.19.8"
\new Voice {
c''1^\markup {
\override #'(fret-diagram-details . (
(fret-label-horizontal-offset . 0))) {
\fret-diagram-verbose #'((mute
Graham Percival wrote:
> However, fixcc.py should reject any version other than the
> specific version we want. Otherwise, you could run it on your
> computer (and push it), then I could run it on my computer (and
> push it), then you could do the same thing, and basically we'd end
> up with an in
Hi Graham & al.,
2014-06-24 7:26 GMT+02:00 Graham Percival :
> On Mon, Jun 23, 2014 at 09:28:24PM -0400, Devon Schudy wrote:
>> The cases where 2.04 does worse than 2.02 are minor; I don't think
>> they're enough that fixcc.py should refuse to use it.
>
> Thanks for the analysis of astyle 2.02 vs.
With Mark P's comments - many thanks. It looks much better now.
https://codereview.appspot.com/106160043/diff/1/ROADMAP
File ROADMAP (right):
https://codereview.appspot.com/106160043/diff/1/ROADMAP#newcode21
ROADMAP:21: | | Note: The Snippets and Internals manual are
auto-generated
On 2014/
15 matches
Mail list logo
