PATCHES: Countdown for July 8th 2014

2014-07-05 Thread james
Hello, Here is the current patch countdown list. The next countdown will be on July 8th. You can always view the most current countdown list here: http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaitingcolspec=Patch%20Owner%20ID%20Summarysort=patch

Re: Doc: Updated Roadmap text file (issue 106160043 by pkx1...@gmail.com)

2014-07-05 Thread pkx166h
Thanks https://codereview.appspot.com/106160043/diff/20001/ROADMAP File ROADMAP (right): https://codereview.appspot.com/106160043/diff/20001/ROADMAP#newcode21 ROADMAP:21: | | Note: Snippets and Internals Reference are auto-generated On 2014/07/04 07:28:48, Mark Polesky wrote: | |

Re: Doc: notation-appendices.itely - added 2 Clefs (issue 104520043 by pkx1...@gmail.com)

2014-07-05 Thread markpolesky
On 2014/07/05 05:28:36, J_lowe wrote: Okay, but \clef tab needs \new TabStaff as well Well I've never used Tab notation before and lilypond will let you compile \clef tab c1 It will let you compile, but the visual output is still wrong. So if you *always* use a \new TabStaff for \clef

Re: PATCHES: Countdown for July 8th 2014

2014-07-05 Thread Janek Warchoł
Hello, 2014-07-05 9:12 GMT+02:00 james pkx1...@gmail.com: REVIEW: Janek Warchoł: Patch: cleanup alignments of various grobs (follow-up to 3254 and 3962) http://code.google.com/p/lilypond/issues/detail?id=3978 this patch was on the previous countdown, and the new version that i uploaded

Re: Changes.tely updated - 2.19.x up to June 2014 (issue 108130043 by pkx1...@gmail.com)

2014-07-05 Thread Mark Polesky
Well, that's unfortunate. Here are 3 more options: 1) We could just use my code with the arrows, omit the verbatim, and label the examples as \fill-line and \justify-line from within the text. 2) We could do this: \markup \typewriter \fill-line \underline { | |

Re: Changes.tely updated - 2.19.x up to June 2014 (issue 108130043 bypkx1...@gmail.com)

2014-07-05 Thread Phil Holmes
The arrows don't seem to show up in the PDF output (that may be my viewer I haven't checked elsewhere) however if we did do this we would have remove the @lilypond verbatim because you cannot really see the 'words' clearly in the construction, it's just a 'bunch' of double quotes. I'll defer

Re: Changes.tely updated - 2.19.x up to June 2014 (issue 108130043 by pkx1...@gmail.com)

2014-07-05 Thread Dan Eble
The arrows don't seem to show up in the PDF output (that may be my viewer I haven't checked elsewhere) however if we did do this we would have remove the @lilypond verbatim because you cannot really see the 'words' clearly in the construction, it's just a 'bunch' of double quotes. I'll

Re: Issue 2245: always align dynamics and lyrics on main notehead (issue 108270044 by janek.lilyp...@gmail.com)

2014-07-05 Thread david . nalesnik
https://codereview.appspot.com/108270044/diff/40001/scm/define-grobs.scm File scm/define-grobs.scm (right): https://codereview.appspot.com/108270044/diff/40001/scm/define-grobs.scm#newcode87 scm/define-grobs.scm:87: (X-extent . ,ly:accidental-interface::width) The old code is used as an example

Re: Issue 3991: \magnifyMusic - reluctantly surrender to issues 3987 and 3990. (issue 101690043 by markpole...@gmail.com)

2014-07-05 Thread paulwmorris
Happened to see another little simplification. https://codereview.appspot.com/101690043/diff/40001/scm/music-functions.scm File scm/music-functions.scm (right): https://codereview.appspot.com/101690043/diff/40001/scm/music-functions.scm#newcode2452 scm/music-functions.scm:2452: (lambda (x)

Re: Issue 3991: \magnifyMusic - reluctantly surrender to issues 3987 and 3990. (issue 101690043 by markpole...@gmail.com)

2014-07-05 Thread markpolesky
Reviewers: J_lowe, pwm, Message: On 2014/07/05 14:17:23, pwm wrote: Happened to see another little simplification. ... Can be simplified: (lambda (x) x) is the same as x Not in this case; guile would complain about unbound variable x. I could have used the guile function `identity', but I

Re: Issue 3991: \magnifyMusic - reluctantly surrender to issues 3987 and 3990. (issue 101690043 by markpole...@gmail.com)

2014-07-05 Thread Paul Morris
markpolesky wrote Can be simplified: (lambda (x) x) is the same as x Not in this case; guile would complain about unbound variable x. I could have used the guile function `identity', but I opted not to since it's not documented in the guile manual. I'll rewrite it though, so that the `if'

Re: fix Issue 2462. (issue 108280044 by janek.lilyp...@gmail.com)

2014-07-05 Thread Keith OHara
On Fri, 04 Jul 2014 14:38:19 -0700, Janek Warchoł janek.lilyp...@gmail.com wrote: 2014-07-04 23:26 GMT+02:00 Janek Warchoł janek.lilyp...@gmail.com: That's actually not what i want to do; I apologize for being unclear. I *want* the columns to behave the same way in case of both accidentals

Re: Changes.tely updated - 2.19.x up to June 2014 (issue 108130043 by pkx1...@gmail.com)

2014-07-05 Thread k-ohara5a5a
https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tely#newcode143 Documentation/changes.tely:143: spaced using only its @emph{left-edge} as reference

Re: Issue 2245: always align dynamics and lyrics on main notehead (issue 108270044 by janek.lilyp...@gmail.com)

2014-07-05 Thread k-ohara5a5a
https://codereview.appspot.com/108270044/diff/40001/scm/define-grobs.scm File scm/define-grobs.scm (right): https://codereview.appspot.com/108270044/diff/40001/scm/define-grobs.scm#newcode87 scm/define-grobs.scm:87: (X-extent . ,ly:accidental-interface::width) I opened a tracker item

Re: AccidentalCautionary in NullVoice

2014-07-05 Thread Dan Eble
On Feb 9, 2014, at 21:19 , Dan Eble d...@faithful.be wrote: Here is a work-around for https://code.google.com/p/lilypond/issues/detail?id=3834 which I suppose suggests both a resolution and a reason not to make a distinction between Accidental and AccidentalCautionary in the first place.

Re: Cleanup in self_alignment_interface (issue 105410046 by janek.lilyp...@gmail.com)

2014-07-05 Thread janek . lilypond
Pushed as merge commit: * 0bc7f77 Issue 3978: Merge alignment cleanup |\ | * d6604b0 define-grobs.scm: reorder properties | * 6f3f8f0 TextScript: use aligned_on_parent | * 1d76502 Replace offset closures with aligned_on_parent | * 09412c2 Clean up DynamicText horizontal alignment. |/