Re: Issue 4083: Implement \tagGroup command (issue 137920043 by d...@gnu.org)

2014-09-05 Thread k-ohara5a5a
LGTM It worked fine on (adapted) examples from the divisi staff issue and emails. Looking at the code, I was confused how it worked without the \cleansed concept of the LSR entries, until I realized un-grouped tags effectively form their own group, so old uses of \keepWithTag ignore tags in the

Re: Issue 4083: Implement \tagGroup command (issue 137920043 by d...@gnu.org)

2014-09-05 Thread dak
On 2014/09/05 06:59:18, Keith wrote: LGTM It worked fine on (adapted) examples from the divisi staff issue and emails. Looking at the code, I was confused how it worked without the \cleansed concept of the LSR entries, until I realized un-grouped tags effectively form their own group, so

Re: Issue 4083: Implement \tagGroup command (issue 137920043 by d...@gnu.org)

2014-09-05 Thread mark . opus11
https://codereview.appspot.com/137920043/diff/20001/Documentation/notation/input.itely File Documentation/notation/input.itely (left): https://codereview.appspot.com/137920043/diff/20001/Documentation/notation/input.itely#oldcode2075 Documentation/notation/input.itely:2075: @funindex

Re: Issue 4083: Implement \tagGroup command (issue 137920043 by d...@gnu.org)

2014-09-05 Thread David Kastrup
mark.opu...@googlemail.com writes: https://codereview.appspot.com/137920043/diff/20001/Documentation/notation/input.itely File Documentation/notation/input.itely (left): https://codereview.appspot.com/137920043/diff/20001/Documentation/notation/input.itely#oldcode2075

Re: Issue 4083: Implement \tagGroup command (issue 137920043 by d...@gnu.org)

2014-09-05 Thread Mark Knoop
At 10:35 on 05 Sep 2014, David Kastrup wrote: mark.opu...@googlemail.com writes: https://codereview.appspot.com/137920043/diff/20001/Documentation/notation/input.itely File Documentation/notation/input.itely (left):

PATCHES: Countdown for September 8th 2014

2014-09-05 Thread James
Hello, Here is the current patch countdown list. The next countdown will be on September 8th. You can always view the most current countdown list here:

lilypad.exe Japanese resource (menu, dialog, etc.)

2014-09-05 Thread Masamichi Hosoda
Hi. Japanese resource (menu, dialog, etc.) of official pre-built lilypad.exe is broken. I installed lilypond-2.19.13-1.mingw.exe (download from http://download.linuxaudio.org/lilypond/binaries/mingw/lilypond-2.19.13-1.mi ngw.exe) and started lilypad.exe. Then, all the Japanese character strings

Re: Cello fingering indications

2014-09-05 Thread James
On 04/09/14 01:46, MarcM wrote: Anyone knows why the following snippet does not print the spanner with version 2.19.10 ? fingering_restez.ly http://lilypond.1069038.n5.nabble.com/file/n166031/fingering_restez.ly Colin Campbell-8 wrote On 11-10-31 08:33 PM, David Nalesnik wrote: Hi Colin,

Re: lilypad.exe Japanese resource (menu, dialog, etc.)

2014-09-05 Thread Phil Holmes
- Original Message - From: Masamichi Hosoda truer...@sea.plala.or.jp To: lilypond-devel@gnu.org Sent: Friday, September 05, 2014 12:18 PM Subject: lilypad.exe Japanese resource (menu, dialog, etc.) Hi. Japanese resource (menu, dialog, etc.) of official pre-built lilypad.exe is

Re: Cello fingering indications

2014-09-05 Thread David Kastrup
James pkx1...@gmail.com writes: On 04/09/14 01:46, MarcM wrote: Anyone knows why the following snippet does not print the spanner with version 2.19.10 ? http://lilypond.1069038.n5.nabble.com/file/n166031/fingering_restez.ly (labelled as 2.19.7 but unlikely to work there). Colin Campbell-8

Re: lilypad.exe Japanese resource (menu, dialog, etc.)

2014-09-05 Thread Masamichi HOSODA
Your attached zipped lilypad.exe works fine. Thanks. From: Phil Holmes m...@philholmes.net Subject Re: lilypad.exe Japanese resource (menu, dialog, etc.) Date Fri, 5 Sep 2014 13:52:07 +0100 Message-ID: 40A388970C6540E08618DFC1C4932F1E@Advent Now with the attachment :-( -- Phil Holmes

Re: Missing make target in origin/master?

2014-09-05 Thread Villum Sejersen
On 04-09-2014 12:17, James wrote: On 04/09/14 08:46, Villum Sejersen wrote: On 04-09-2014 06:46, David Kastrup wrote: Villum Sejersenv...@privat.tdcadsl.dk writes: root@Villums14:/usr/local/src/lilypond/build# git status On branch master Your branch is up-to-date with 'origin/master'.

Re: Issue 4083: Implement \tagGroup command (issue 137920043 by d...@gnu.org)

2014-09-05 Thread tdanielsmusic
Apart from an inconsistency, marked below, LGTM. https://codereview.appspot.com/137920043/diff/40001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/137920043/diff/40001/ly/music-functions-init.ly#newcode562 ly/music-functions-init.ly:562:

Re: Missing make target in origin/master?

2014-09-05 Thread James
On 05/09/14 19:20, Villum Sejersen wrote: On 04-09-2014 12:17, James wrote: On 04/09/14 08:46, Villum Sejersen wrote: On 04-09-2014 06:46, David Kastrup wrote: Villum Sejersenv...@privat.tdcadsl.dk writes: root@Villums14:/usr/local/src/lilypond/build# git status On branch master Your branch

Re: Issue 4083: Implement \tagGroup command (issue 137920043 by d...@gnu.org)

2014-09-05 Thread dak
https://codereview.appspot.com/137920043/diff/40001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/137920043/diff/40001/ly/music-functions-init.ly#newcode562 ly/music-functions-init.ly:562: more than one tag group defined with

Re: Cello fingering indications

2014-09-05 Thread MarcM
This function apparently worked in version 2.14. I tried in 2.18 and the line is not printed so the change is not due to a recent commit. I just want to implement a simple function for the music directive restez (*) which is usually indicated with the text restez and a line that spans a list of

Re: Issue 4083: Implement \tagGroup command (issue 137920043 by d...@gnu.org)

2014-09-05 Thread tdanielsmusic
https://codereview.appspot.com/137920043/diff/40001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/137920043/diff/40001/ly/music-functions-init.ly#newcode562 ly/music-functions-init.ly:562: more than one tag group defined with