Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

2014-10-19 Thread Janek WarchoĊ‚
2014-10-20 6:33 GMT+02:00 : > > https://codereview.appspot.com/156400043/diff/1/ly/property-init.ly#newcode359 >> using \override's for re-establishing the default settings, >> What do others think? > > Yes, \autoLineBreaksOn is an assertive statement, so I would expect > it to set the state of li

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

2014-10-19 Thread k-ohara5a5a
Looks good to me. I'm just suggesting more changes that you might want to do at the same time. https://codereview.appspot.com/156400043/diff/20001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/156400043/diff/20001/Document

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

2014-10-19 Thread k-ohara5a5a
https://codereview.appspot.com/156400043/diff/1/ly/property-init.ly#newcode359 > > ly/property-init.ly:359: lineBreaksOn = using \override's for re-establishing the default settings, What do others think? Yes, \autoLineBreaksOn is an assertive statement, so I would expect it to set the stat

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

2014-10-19 Thread tdanielsmusic
On 2014/10/19 18:04:32, Trevor Daniels wrote: On 2014/10/19 16:58:04, dak wrote: > https://codereview.appspot.com/156400043/diff/1/ly/property-init.ly > File ly/property-init.ly (right): > > https://codereview.appspot.com/156400043/diff/1/ly/property-init.ly#newcode359 > ly/property-init.ly:359

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

2014-10-19 Thread janek . lilypond
thanks, LGTM :) https://codereview.appspot.com/156400043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: GUB update

2014-10-19 Thread David Kastrup
Phil Holmes writes: > Keen observers will have noticed that I've not been able to keep to my > normal schedule of LilyPond releases. The is down to the fact that > some of the recent patches are not compatible with the original GCC > version in te GUB repo. I've been working on updating this, b

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

2014-10-19 Thread tdanielsmusic
On 2014/10/19 16:58:45, janek wrote: Hello, I think it may be a good idea to add "auto" prefix to these commands. They will get longer, but i think the clarification gained is worth it; we also have \autoBeamOn/Off following this convention. Good thinking, especially as these commands ha

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

2014-10-19 Thread tdanielsmusic
Reviewers: janek, Message: On 2014/10/19 16:58:04, dak wrote: https://codereview.appspot.com/156400043/diff/1/ly/property-init.ly File ly/property-init.ly (right): https://codereview.appspot.com/156400043/diff/1/ly/property-init.ly#newcode359 ly/property-init.ly:359: lineBreaksOn = It might

Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

2014-10-19 Thread dak
https://codereview.appspot.com/156400043/diff/1/ly/property-init.ly File ly/property-init.ly (right): https://codereview.appspot.com/156400043/diff/1/ly/property-init.ly#newcode359 ly/property-init.ly:359: lineBreaksOn = It might be more consistent with other overrides in this file to make the c

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

2014-10-19 Thread janek . lilypond
Hello, I think it may be a good idea to add "auto" prefix to these commands. They will get longer, but i think the clarification gained is worth it; we also have \autoBeamOn/Off following this convention. best, Janek https://codereview.appspot.com/156400043/ ___

GUB update

2014-10-19 Thread Phil Holmes
Keen observers will have noticed that I've not been able to keep to my normal schedule of LilyPond releases. The is down to the fact that some of the recent patches are not compatible with the original GCC version in te GUB repo. I've been working on updating this, but having problems getting

Improvements to measure counter (issue 156380043 by david.nales...@gmail.com)

2014-10-19 Thread david . nalesnik
Reviewers: , Message: Please review. Description: Improvements to measure counter Improvements to measure counter This patch adds no new functionality to the measure counter, but there are improvements to the code. The stencil callback has been shortened, as there is no need to search for c

Re: [Lilypond-auto] Issue 3066 in lilypond: tie in TabStaff (using q) displays one of the unisone notes in a chord

2014-10-19 Thread Trevor Daniels
> Comment #16 on issue 3066 by d...@gnu.org: tie in TabStaff (using q) > displays one of the unisone notes in a chord > https://code.google.com/p/lilypond/issues/detail?id=3066 > > As I have several other tie patches on the backburner that may or may not > interact with this one, and this pat