Re: Rewrite chordnames - disentangle data from formatting (issue 223420043 by thomasmorle...@gmail.com)

2015-04-11 Thread marc
Hi Harm, I cannot comment much on the code, but I like the general approach of separating chord information and chord markup very much! Two tiny remarks below. https://codereview.appspot.com/223420043/diff/20001/scm/chord-ignatzek-names.scm File scm/chord-ignatzek-names.scm (right): https://c

Re: Embed LilyPond source files inside generated PDF (issue 225040043 by v.villen...@gmail.com)

2015-04-11 Thread v . villenave
On 2015/04/10 09:42:38, dak wrote: In this particular case, it would appear that Includable_lexer::file_name_strings_ already contains properly expanded file names after the file name search has succeeded, so that would seem to be the smarter thing to reference. Here’s what I came up with;

Re: Rewrite chordnames - disentangle data from formatting (issue 223420043 by thomasmorle...@gmail.com)

2015-04-11 Thread thomasmorley65
Please review. Intended is a pure maintaining change. Maybe a first step for more flexibility, easier customizing etc. If I sorted it correctly, no change in visible output should occur. Apart from the Banter-style (see commit-message) no bug-fixing happens, although I noticed one (see FIXME in

Re: Replace C++ (in)equality checks with proper SCM syntax (issue 226840043 by v.villen...@gmail.com)

2015-04-11 Thread v . villenave
On 2015/04/11 07:43:55, dak wrote: See the Button marked "Delete" in the following screen shot. Thanks. I’ve triple-checked this patch and it doesn’t appear to be breaking anything (I’m running make check again just in case, but I’ll feel reassured once it’s checked by other people as well); h

Re: Voice switching étude

2015-04-11 Thread Dan Eble
> I'm not top-posting. Here is one more revision of my study in combining parts without using the partcombine iterator. This version explores multiple styles, such as showing unisons with multiple heads or keeping rests visible through solo passages. Now I have a question about architecture. Is

Re: cygwin64 - building 2.18.2 doc fails

2015-04-11 Thread Marco Atzeri
On 4/11/2015 2:08 PM, Masamichi HOSODA wrote: Installed contains the results of running the program after installation only on that snippets. As it works, I am very puzzled. $ lilypond --png lily-487dce2c.ly GNU LilyPond 2.18.2 Processing `lily-487dce2c.ly' Parsing... Renaming input to: `out-w

Re: cygwin64 - building 2.18.2 doc fails

2015-04-11 Thread Masamichi HOSODA
> Installed contains the results of running the program > after installation only on that snippets. > As it works, I am very puzzled. > > $ lilypond --png lily-487dce2c.ly > GNU LilyPond 2.18.2 > Processing `lily-487dce2c.ly' > Parsing... > Renaming input to: `out-www/quantize-start-midi.ly' > Int

Re: cygwin64 - building 2.18.2 doc fails

2015-04-11 Thread David Kastrup
Marco Atzeri writes: > On 4/11/2015 12:29 PM, David Kastrup wrote: > >>> >>> I presume that lilypond is calling gs with a not recognized option >>> only on this specific snippet. >> >> So which snippet is it? I don't know all the checksums by heart... >> There likely should be some file >> >> /c

Re: cygwin64 - building 2.18.2 doc fails

2015-04-11 Thread Marco Atzeri
On 4/11/2015 12:29 PM, David Kastrup wrote: I presume that lilypond is calling gs with a not recognized option only on this specific snippet. So which snippet is it? I don't know all the checksums by heart... There likely should be some file /cygdrive/e/cyg_pub/devel/lilypond/lilypond-2.18.

Re: cygwin64 - building 2.18.2 doc fails

2015-04-11 Thread David Kastrup
Marco Atzeri writes: > On 4/11/2015 8:57 AM, Marco Atzeri wrote: >> >> >> On 4/11/2015 8:09 AM, David Kastrup wrote: >>> Marco Atzeri writes: >>> I am trying to build and package 2.18.2 for cygwin 64 bit. I am currently stacked in building the documentation >>> >>> [...] >>> The l

Re: cygwin64 - building 2.18.2 doc fails

2015-04-11 Thread Marco Atzeri
On 4/11/2015 8:57 AM, Marco Atzeri wrote: On 4/11/2015 8:09 AM, David Kastrup wrote: Marco Atzeri writes: I am trying to build and package 2.18.2 for cygwin 64 bit. I am currently stacked in building the documentation [...] The log is not very informative --

Re: Replace C++ (in)equality checks with proper SCM syntax (issue 226840043 by v.villen...@gmail.com)

2015-04-11 Thread David Kastrup
v.villen...@gmail.com writes: > What a mess. I inadvertently uploaded my "round 2" proposal onto this > issue where it doesn’t belong. > > Since Rietveld doesn’t seem to offer a way of undoing it, See the Button marked "Delete" in the following screen shot. > please disregard "patch set #10" (

Re: Replace C++ (in)equality checks with proper SCM syntax (issue 226840043 by v.villen...@gmail.com)

2015-04-11 Thread v . villenave
What a mess. I inadvertently uploaded my "round 2" proposal onto this issue where it doesn’t belong. Since Rietveld doesn’t seem to offer a way of undoing it, please disregard "patch set #10" (#9 is the one actually being reviewed, with all of David’s suggestions taken into account). https://cod